system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-21 10:05:32 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

AK: Prevent bit counter underflows in the new BitStream

Browse source 
Our current `peek_bits` function allows retrieving more bits than we can
actually provide, so whenever someone discards the requested bit count
afterwards we were underflowing the value instead.
This commit is contained in:
Tim Schumacher 2023-04-27 11:33:08 +02:00 committed by Jelle Raaijmakers
parent dffef6bb71
commit 56d861ebe0
1 changed files with 4 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
AK/BitStream.h
View file

@ -222,6 +222,10 @@ public:
ALWAYS_INLINE void discard_previously_peeked_bits(u8 count)
{
// We allow "retrieving" more bits than we can provide, but we need to make sure that we don't underflow the current bit counter.
if (count > m_bit_count)
count = m_bit_count;
m_bit_offset += count;
m_bit_count -= count;
}