system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-04 23:19:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

Terminal: Create config file parent directories before unveil()'ing

Browse source 
Otherwise unveil() will fail, as even with "c" permissions the file's
parent directory must exist.

Fixes #5651.
This commit is contained in:
Linus Groh 2021-03-13 15:34:02 +01:00 committed by Andreas Kling
parent 5e4808878d
commit 4b65ba27ec
1 changed files with 4 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

5
Userland/Applications/Terminal/main.cpp
View file

@ -27,6 +27,8 @@
#include <AK/URL.h>
#include <Applications/Terminal/TerminalSettingsWindowGML.h>
#include <LibCore/ArgsParser.h>
#include <LibCore/ConfigFile.h>
#include <LibCore/File.h>
#include <LibDesktop/Launcher.h>
#include <LibGUI/Action.h>
#include <LibGUI/ActionGroup.h>
@ -347,6 +349,7 @@ int main(int argc, char** argv)
}
RefPtr<Core::ConfigFile> config = Core::ConfigFile::get_for_app("Terminal");
Core::File::ensure_parent_directories(config->file_name());
pid_t shell_pid = 0;
@ -502,7 +505,7 @@ int main(int argc, char** argv)
return 1;
}
if (unveil(config->file_name().characters(), "rwc")) {
if (unveil(config->file_name().characters(), "rwc") < 0) {
perror("unveil");
return 1;
}