system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-24 03:25:02 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

LibTest: Bump up MAX_GEN_ATTEMPTS_PER_VALUE to 30

Browse source 
The original value 15 was too little: it made our
`weighted_boolean_fair_false` test fail every now and then.

This is because a fair coin (P(false) = 0.5) will hit the same value 15
times in a row with a probability (1/2)^15: around once in a 32k tries.

With the bumped up value, this is now once in 1 billion tries. Should
lower the test flakiness enough (if our random number generator is
truly uniform), while 30 tries is still an OK amount of computation for
randomized tests to do, compared to 15.
This commit is contained in:
Martin Janiczek 2023-11-06 10:41:25 +01:00 committed by Andreas Kling
parent 7e3cfaf08c
commit 49dbc4b5a5
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibTest/TestCase.h
View file

@ -46,7 +46,7 @@ public:
{
using namespace Randomized;
constexpr u8 MAX_GEN_ATTEMPTS_PER_VALUE = 15;
constexpr u8 MAX_GEN_ATTEMPTS_PER_VALUE = 30;
TestFunction test_case_function = [test_function = move(test_function)]() {
u64 max_randomized_runs = randomized_runs();