mirror of
https://github.com/SerenityOS/serenity
synced 2024-10-15 20:33:10 +00:00
Kernel: Add some InodeVMObject type assertions in Region::clone()
Let's make sure that we're never cloning shared inode-backed objects as if they were private, and vice versa.
This commit is contained in:
parent
88b334135b
commit
48bbfe51fb
|
@ -42,6 +42,8 @@ public:
|
|||
virtual NonnullRefPtr<VMObject> clone() override;
|
||||
|
||||
private:
|
||||
virtual bool is_private_inode() const override { return true; }
|
||||
|
||||
explicit PrivateInodeVMObject(Inode&, size_t);
|
||||
explicit PrivateInodeVMObject(const PrivateInodeVMObject&);
|
||||
|
||||
|
|
|
@ -71,6 +71,9 @@ NonnullOwnPtr<Region> Region::clone()
|
|||
#ifdef MM_DEBUG
|
||||
dbg() << "Region::clone(): Sharing " << name() << " (" << vaddr() << ")";
|
||||
#endif
|
||||
if (vmobject().is_inode())
|
||||
ASSERT(vmobject().is_shared_inode());
|
||||
|
||||
// Create a new region backed by the same VMObject.
|
||||
auto region = Region::create_user_accessible(m_range, m_vmobject, m_offset_in_vmobject, m_name, m_access);
|
||||
region->set_mmap(m_mmap);
|
||||
|
@ -78,6 +81,9 @@ NonnullOwnPtr<Region> Region::clone()
|
|||
return region;
|
||||
}
|
||||
|
||||
if (vmobject().is_inode())
|
||||
ASSERT(vmobject().is_private_inode());
|
||||
|
||||
#ifdef MM_DEBUG
|
||||
dbg() << "Region::clone(): CoWing " << name() << " (" << vaddr() << ")";
|
||||
#endif
|
||||
|
|
|
@ -42,6 +42,8 @@ public:
|
|||
virtual NonnullRefPtr<VMObject> clone() override;
|
||||
|
||||
private:
|
||||
virtual bool is_shared_inode() const override { return true; }
|
||||
|
||||
explicit SharedInodeVMObject(Inode&, size_t);
|
||||
explicit SharedInodeVMObject(const SharedInodeVMObject&);
|
||||
|
||||
|
|
|
@ -52,6 +52,8 @@ public:
|
|||
virtual bool is_anonymous() const { return false; }
|
||||
virtual bool is_purgeable() const { return false; }
|
||||
virtual bool is_inode() const { return false; }
|
||||
virtual bool is_shared_inode() const { return false; }
|
||||
virtual bool is_private_inode() const { return false; }
|
||||
|
||||
size_t page_count() const { return m_physical_pages.size(); }
|
||||
const FixedArray<RefPtr<PhysicalPage>>& physical_pages() const { return m_physical_pages; }
|
||||
|
|
Loading…
Reference in a new issue