system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-09-06 17:06:31 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Use Checked::saturating_[add|sub] where applicable in PixelUnits

Browse source
This commit is contained in:
Hendiadyoin1 2023-07-26 15:00:03 +02:00 committed by Alexander Kalenik
parent 618f889486
commit 4896ba11dc
1 changed files with 4 additions and 15 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

19
Userland/Libraries/LibWeb/PixelUnits.cpp
View file

@ -66,12 +66,12 @@ bool CSSPixels::operator==(CSSPixels const& other) const
CSSPixels& CSSPixels::operator++()
{
m_value += fixed_point_denominator;
m_value = Checked<int>::saturating_add(m_value, fixed_point_denominator);
return *this;
}
CSSPixels& CSSPixels::operator--()
{
m_value -= fixed_point_denominator;
m_value = Checked<int>::saturating_sub(m_value, fixed_point_denominator);
return *this;
}
@ -91,25 +91,14 @@ CSSPixels CSSPixels::operator-() const
return from_raw(-raw_value());
}
static inline int saturated_addition(int a, int b)
{
i32 overflow = (b > 0 && a > NumericLimits<i32>::max() - b);
i32 underflow = (b < 0 && a < NumericLimits<i32>::min() - b);
return overflow ? NumericLimits<i32>::max() : (underflow ? NumericLimits<i32>::min() : a + b);
}
CSSPixels CSSPixels::operator+(CSSPixels const& other) const
{
CSSPixels result;
result.set_raw_value(saturated_addition(raw_value(), other.raw_value()));
return result;
return from_raw(Checked<int>::saturating_add(raw_value(), other.raw_value()));
}
CSSPixels CSSPixels::operator-(CSSPixels const& other) const
{
CSSPixels result;
result.set_raw_value(saturated_addition(raw_value(), -other.raw_value()));
return result;
return from_raw(Checked<int>::saturating_sub(raw_value(), other.raw_value()));
}
CSSPixels CSSPixels::operator*(CSSPixels const& other) const