system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-01 11:15:37 +00:00
Code Issues Projects Releases Wiki Activity

LibWeb: Prevent select.click() opening the dropdown

Browse Source 
No other browser allows opening the select element dropdown with the
select.click() function.
This change stops this happening in Ladybird.

(cherry picked from commit 564e546ff0bd78cc7ba770b53377457bf1ef88d6)
This commit is contained in:
Luke Warlow 2024-06-13 18:36:18 +02:00 committed by Nico Weber
parent 972f7581e9
commit 47bc8ecb0e
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
Userland/Libraries/LibWeb/HTML/HTMLSelectElement.cpp
View File

@ -431,9 +431,10 @@ WebIDL::ExceptionOr<void> HTMLSelectElement::show_picker()
return {};
}
void HTMLSelectElement::activation_behavior(DOM::Event const&)
void HTMLSelectElement::activation_behavior(DOM::Event const& event)
{
show_the_picker_if_applicable();
if (event.is_trusted())
show_the_picker_if_applicable();
}
void HTMLSelectElement::did_select_item(Optional<u32> const& id)