system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-09 09:40:45 +00:00
Code Issues Projects Releases Wiki Activity

LibProtocol: Exit fatally if the connection to RequestServer disappears

Browse Source 
The default implementation of die() causes the client process to simply
exit cleanly. This prevents any tests from recognizing that something
went wrong, as the process exits with a code of 0. With this patch, we
still just exit when the connection dies, but with a fatal signal. In
the future, we will want to launch a new RequestServer process and
re-establish client connections.

(cherry picked from commit d1ec32e28feee10c2c36f4cd0d496b8a95d375f8)
This commit is contained in:
Timothy Flynn 2024-06-06 07:16:14 -04:00 committed by Nico Weber
parent 7e2c8693b1
commit 46ce6decfe
2 changed files with 9 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
Userland/Libraries/LibProtocol/RequestClient.cpp
View File

@ -14,6 +14,13 @@ RequestClient::RequestClient(NonnullOwnPtr<Core::LocalSocket> socket)
{
}
void RequestClient::die()
{
// FIXME: Gracefully handle this, or relaunch and reconnect to RequestServer.
warnln("\033[31;1mLost connection to RequestServer\033[0m");
VERIFY_NOT_REACHED();
}
void RequestClient::ensure_connection(URL::URL const& url, ::RequestServer::CacheLevel cache_level)
{
async_ensure_connection(url, cache_level);

2
Userland/Libraries/LibProtocol/RequestClient.h
View File

@ -36,6 +36,8 @@ public:
bool set_certificate(Badge<Request>, Request&, ByteString, ByteString);
private:
virtual void die() override;
virtual void request_started(i32, IPC::File const&) override;
virtual void request_progress(i32, Optional<u64> const&, u64) override;
virtual void request_finished(i32, bool, u64) override;