system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-09 09:00:46 +00:00
Code Issues Projects Releases Wiki Activity

LibJS/Bytecode: Rename TypeofVariable => TypeofBinding

Browse Source 
(cherry picked from commit 4302e073463c403f8d7ab09c42e7644089fc33a2)
This commit is contained in:
Andreas Kling 2024-06-14 09:37:26 +02:00 committed by Nico Weber
parent cd7a151aef
commit 3a7da923e6
5 changed files with 11 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
Userland/Libraries/LibJS/Bytecode/ASTCodegen.cpp
View File

@ -362,7 +362,7 @@ Bytecode::CodeGenerationErrorOr<Optional<ScopedOperand>> UnaryExpression::genera
if (is<Identifier>(*m_lhs)) {
auto& identifier = static_cast<Identifier const&>(*m_lhs);
if (!identifier.is_local()) {
generator.emit<Bytecode::Op::TypeofVariable>(dst, generator.intern_identifier(identifier.string()));
generator.emit<Bytecode::Op::TypeofBinding>(dst, generator.intern_identifier(identifier.string()));
break;
}
}

2
Userland/Libraries/LibJS/Bytecode/CommonImplementations.h
View File

@ -389,7 +389,7 @@ inline ThrowCompletionOr<void> throw_if_needed_for_call(Interpreter& interpreter
return {};
}
inline ThrowCompletionOr<Value> typeof_variable(VM& vm, DeprecatedFlyString const& string)
inline ThrowCompletionOr<Value> typeof_binding(VM& vm, DeprecatedFlyString const& string)
{
// 1. Let val be the result of evaluating UnaryExpression.
auto reference = TRY(vm.resolve_binding(string));

2
Userland/Libraries/LibJS/Bytecode/Instruction.h
View File

@ -138,7 +138,7 @@
O(ThrowIfNullish) \
O(ThrowIfTDZ) \
O(Typeof) \
O(TypeofVariable) \
O(TypeofBinding) \
O(UnaryMinus) \
O(UnaryPlus) \
O(UnsignedRightShift) \

10
Userland/Libraries/LibJS/Bytecode/Interpreter.cpp
View File

@ -663,7 +663,7 @@ FLATTEN_ON_CLANG void Interpreter::run_bytecode(size_t entry_point)
HANDLE_INSTRUCTION(ThrowIfNullish);
HANDLE_INSTRUCTION(ThrowIfTDZ);
HANDLE_INSTRUCTION(Typeof);
HANDLE_INSTRUCTION(TypeofVariable);
HANDLE_INSTRUCTION(TypeofBinding);
HANDLE_INSTRUCTION(UnaryMinus);
HANDLE_INSTRUCTION(UnaryPlus);
HANDLE_INSTRUCTION(UnsignedRightShift);
@ -1979,10 +1979,10 @@ ThrowCompletionOr<void> NewClass::execute_impl(Bytecode::Interpreter& interprete
}
// 13.5.3.1 Runtime Semantics: Evaluation, https://tc39.es/ecma262/#sec-typeof-operator-runtime-semantics-evaluation
ThrowCompletionOr<void> TypeofVariable::execute_impl(Bytecode::Interpreter& interpreter) const
ThrowCompletionOr<void> TypeofBinding::execute_impl(Bytecode::Interpreter& interpreter) const
{
auto& vm = interpreter.vm();
interpreter.set(dst(), TRY(typeof_variable(vm, interpreter.current_executable().get_identifier(m_identifier))));
interpreter.set(dst(), TRY(typeof_binding(vm, interpreter.current_executable().get_identifier(m_identifier))));
return {};
}
@ -2685,9 +2685,9 @@ ByteString GetImportMeta::to_byte_string_impl(Bytecode::Executable const& execut
return ByteString::formatted("GetImportMeta {}", format_operand("dst"sv, m_dst, executable));
}
ByteString TypeofVariable::to_byte_string_impl(Bytecode::Executable const& executable) const
ByteString TypeofBinding::to_byte_string_impl(Bytecode::Executable const& executable) const
{
return ByteString::formatted("TypeofVariable {}, {}",
return ByteString::formatted("TypeofBinding {}, {}",
format_operand("dst"sv, m_dst, executable),
executable.identifier_table->get(m_identifier));
}

6
Userland/Libraries/LibJS/Bytecode/Op.h
View File

@ -2623,10 +2623,10 @@ private:
Operand m_dst;
};
class TypeofVariable final : public Instruction {
class TypeofBinding final : public Instruction {
public:
TypeofVariable(Operand dst, IdentifierTableIndex identifier)
: Instruction(Type::TypeofVariable)
TypeofBinding(Operand dst, IdentifierTableIndex identifier)
: Instruction(Type::TypeofBinding)
, m_dst(dst)
, m_identifier(identifier)
{