From 39f7f1e84c72ef841a2e261dbf7d5b32b2c6846e Mon Sep 17 00:00:00 2001 From: Tim Ledbetter Date: Mon, 30 Oct 2023 15:23:40 +0000 Subject: [PATCH] Tests: Use more representative test cases for ILBM regression tests Previously, the regression tests for OSS-Fuzz issues 62033 and 63296 used test case files directly from OSS-Fuzz. These files are invalid in multiple ways because they have been generated by a fuzzer. This commit replaces these files with ones that only expose the issue being tested. --- Tests/LibGfx/TestImageDecoder.cpp | 4 ++-- .../LibGfx/test-inputs/ilbm/missing-body-chunk.iff | Bin 0 -> 96 bytes .../test-inputs/ilbm/oss-fuzz-testcase-62033.iff | Bin 20 -> 0 bytes .../test-inputs/ilbm/oss-fuzz-testcase-63296.iff | Bin 40 -> 0 bytes .../test-inputs/ilbm/truncated-bmhd-chunk.iff | Bin 0 -> 18 bytes 5 files changed, 2 insertions(+), 2 deletions(-) create mode 100644 Tests/LibGfx/test-inputs/ilbm/missing-body-chunk.iff delete mode 100644 Tests/LibGfx/test-inputs/ilbm/oss-fuzz-testcase-62033.iff delete mode 100644 Tests/LibGfx/test-inputs/ilbm/oss-fuzz-testcase-63296.iff create mode 100644 Tests/LibGfx/test-inputs/ilbm/truncated-bmhd-chunk.iff diff --git a/Tests/LibGfx/TestImageDecoder.cpp b/Tests/LibGfx/TestImageDecoder.cpp index 07211bc0cd..f800ae0316 100644 --- a/Tests/LibGfx/TestImageDecoder.cpp +++ b/Tests/LibGfx/TestImageDecoder.cpp @@ -141,7 +141,7 @@ TEST_CASE(test_ilbm_uncompressed) TEST_CASE(test_ilbm_malformed_header) { Array test_inputs = { - TEST_INPUT("ilbm/oss-fuzz-testcase-62033.iff"sv), + TEST_INPUT("ilbm/truncated-bmhd-chunk.iff"sv) }; for (auto test_input : test_inputs) { @@ -154,7 +154,7 @@ TEST_CASE(test_ilbm_malformed_header) TEST_CASE(test_ilbm_malformed_frame) { Array test_inputs = { - TEST_INPUT("ilbm/oss-fuzz-testcase-63296.iff"sv) + TEST_INPUT("ilbm/missing-body-chunk.iff"sv) }; for (auto test_input : test_inputs) { diff --git a/Tests/LibGfx/test-inputs/ilbm/missing-body-chunk.iff b/Tests/LibGfx/test-inputs/ilbm/missing-body-chunk.iff new file mode 100644 index 0000000000000000000000000000000000000000..6a3d0572aed261b31c96d844b527f98965505ff2 GIT binary patch literal 96 zcmZ?s5AtPTkWcdTaq@NY^>ATeU=U$+U^oG!8JHOu8yFaLOh9~RU&jETki?lYXMoiI q|NlEWI#ww$+zn-Tx0`{XgTdL+*BvOq!oVoN;1b}e0A`yo=l}pTl@;y) literal 0 HcmV?d00001 diff --git a/Tests/LibGfx/test-inputs/ilbm/oss-fuzz-testcase-62033.iff b/Tests/LibGfx/test-inputs/ilbm/oss-fuzz-testcase-62033.iff deleted file mode 100644 index 945902c57e4f743dd28f66fa5c38fa97de7104ec..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 20 YcmZ?s5Asz20#6?&UngG=7X}~z05Gxx^Z)<= diff --git a/Tests/LibGfx/test-inputs/ilbm/oss-fuzz-testcase-63296.iff b/Tests/LibGfx/test-inputs/ilbm/oss-fuzz-testcase-63296.iff deleted file mode 100644 index e1390b3277c9e4265311bb2930e426ff39dfa8a2..0000000000000000000000000000000000000000 GIT binary patch literal 0 HcmV?d00001 literal 40 dcmZ?s5Asz20#6?&UngG=7X}6f5fC38005h&28aLv diff --git a/Tests/LibGfx/test-inputs/ilbm/truncated-bmhd-chunk.iff b/Tests/LibGfx/test-inputs/ilbm/truncated-bmhd-chunk.iff new file mode 100644 index 0000000000000000000000000000000000000000..f2471f04a625f4867e6c1b8451dfe8ef3672389c GIT binary patch literal 18 ZcmZ?s5AtPTkWcdTaq@NY^>ATe001a71N8s^ literal 0 HcmV?d00001