system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-21 18:15:58 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

AK: Make it possible to swap() a NonnullRefPtr with itself

Browse source 
The generic swap() is not able to swap a NonnullRefPtr with itself,
due to its use of a temporary and NonnullRefPtr asserting when trying
to move() from an already move()'d instance.
This commit is contained in:
Andreas Kling 2020-01-19 10:29:21 +01:00
parent 604c5cb98e
commit 39b3c0ef7e
2 changed files with 13 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
AK/NonnullRefPtr.h
View file

@ -267,6 +267,12 @@ inline const LogStream& operator<<(const LogStream& stream, const NonnullRefPtr<
return stream << value.ptr();
}
template<typename T, typename U>
inline void swap(NonnullRefPtr<T>& a, NonnullRefPtr<U>& b)
{
a.swap(b);
}
}
using AK::adopt;

7
AK/Tests/TestNonnullRefPtr.cpp
View file

@ -73,4 +73,11 @@ TEST_CASE(assign_owner_of_self)
EXPECT_EQ(child->ref_count(), 1);
}
TEST_CASE(swap_with_self)
{
auto object = adopt(*new Object);
swap(object, object);
EXPECT_EQ(object->ref_count(), 1);
}
TEST_MAIN(String)