system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-22 02:26:11 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

LibWeb: Do not add CSS transforms into clip rect in PaintableWithLines

Browse source 
Painting command executor already accounts for CSS transforms so clip
rect only needs to be adjusted by scroll offset.
This commit is contained in:
Aliaksandr Kalenik 2024-02-03 18:25:31 +01:00 committed by Andreas Kling
parent 7ad0767aa0
commit 36553d4566
3 changed files with 29 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

13
Tests/LibWeb/Ref/overflow-hidden-text-inside-translated-container.html Normal file
View file

@ -0,0 +1,13 @@
<!DOCTYPE html>
<link rel="match" href="reference/overflow-hidden-text-inside-translated-container-ref.html" />
<style>
.text {
overflow: hidden;
font-size: 50px;
}
.container {
transform: translate(0px, -50%);
}
</style>
<div class="container"><div class="text">Verify with something else</div></div>

11
Tests/LibWeb/Ref/reference/overflow-hidden-text-inside-translated-container-ref.html Normal file
View file

@ -0,0 +1,11 @@
<!DOCTYPE html>
<style>
.text {
font-size: 50px;
}
.container {
transform: translate(0px, -50%);
}
</style>
<div class="container"><div class="text">Verify with something else</div></div>

9
Userland/Libraries/LibWeb/Painting/PaintableBox.cpp
View file

@ -599,12 +599,13 @@ void PaintableWithLines::paint(PaintContext& context, PaintPhase phase) const
bool should_clip_overflow = computed_values().overflow_x() != CSS::Overflow::Visible && computed_values().overflow_y() != CSS::Overflow::Visible;
Optional<u32> corner_clip_id;
auto clip_box = context.rounded_device_rect(compute_absolute_padding_rect_with_css_transform_applied());
auto clip_box = absolute_padding_box_rect();
if (enclosing_scroll_frame_offset().has_value())
clip_box.translate_by(enclosing_scroll_frame_offset().value());
if (should_clip_overflow) {
context.recording_painter().save();
// FIXME: Handle overflow-x and overflow-y being different values.
context.recording_painter().add_clip_rect(clip_box.to_type<int>());
context.recording_painter().add_clip_rect(context.rounded_device_rect(clip_box).to_type<int>());
auto scroll_offset = context.rounded_device_point(this->scroll_offset());
context.recording_painter().translate(-scroll_offset.to_type<int>());
@ -617,7 +618,7 @@ void PaintableWithLines::paint(PaintContext& context, PaintPhase phase) const
};
if (corner_radii.has_any_radius()) {
corner_clip_id = context.allocate_corner_clipper_id();
context.recording_painter().sample_under_corners(*corner_clip_id, corner_radii, clip_box.to_type<int>(), CornerClip::Outside);
context.recording_painter().sample_under_corners(*corner_clip_id, corner_radii, context.rounded_device_rect(clip_box).to_type<int>(), CornerClip::Outside);
}
}