From 35617ba2d317ace5f0d38c8a91fffb99773edb17 Mon Sep 17 00:00:00 2001 From: Brian Gianforcaro Date: Sat, 30 Oct 2021 12:13:08 -0700 Subject: [PATCH] Meta: Suppress rule v1047 in PVS-Studio Static Analysis This rule appears to produce a lot of noise, most of them look like false positives (400+). Lets suppress for now to try to move the signal to noise ratio higher for PVS-Studio. Reference: https://pvs-studio.com/en/docs/warnings/v1047/ --- .github/workflows/pvs-studio-static-analysis.yml | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/pvs-studio-static-analysis.yml b/.github/workflows/pvs-studio-static-analysis.yml index 6a4016e613..1eca15daab 100644 --- a/.github/workflows/pvs-studio-static-analysis.yml +++ b/.github/workflows/pvs-studio-static-analysis.yml @@ -100,10 +100,11 @@ jobs: # - We are the system headers: V677 Custom declaration of a standard '' type. The declaration from system header files should be used instead. # - We have no choice: V1061 Extending the 'std' namespace may result in undefined behavior. # - TRY(..) macro breaks this rule: V530 The return value of function 'release_value' is required to be utilized. + # - False positives: V1047 Lifetime of the lambda is greater than lifetime of the local variable captured by reference. - name: Filter PVS Log working-directory: ${{ github.workspace }}/Build/${{ env.PVS_STUDIO_ANALYSIS_ARCH }} run: | - pvs-studio-analyzer suppress -v677 -v1061 -v530 project.plog + pvs-studio-analyzer suppress -v677 -v1061 -v530 -v1047 project.plog pvs-studio-analyzer filter-suppressed project.plog - name: Print PVS Log