system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-07 08:29:58 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibWeb: Flexbox: Take parent's width in the flex container for layouting

Browse source 
If our parent in the FlexFormattingContext also was a flex-container, we
didn't give our children any meaningful width to play with into
layout_inside(), which resulted in way too narrow layouting.
Now the width of the parent gets borrowed if the own width isn't
specified.
This commit is contained in:
Tobias Christiansen 2021-09-17 23:44:58 +02:00 committed by Andreas Kling
parent 3cc6ffd4a6
commit 2f891fd4b8
1 changed files with 3 additions and 0 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/Layout/FlexFormattingContext.cpp
View file

@ -222,6 +222,9 @@ void FlexFormattingContext::run(Box& box, LayoutMode)
// This is particularly important since we take references to the items stored in flex_items
// later, whose addresses won't be stable if we added or removed any items.
Vector<FlexItem> flex_items;
if (!box.has_definite_width())
box.set_width(box.width_of_logical_containing_block());
box.for_each_child_of_type<Box>([&](Box& child_box) {
layout_inside(child_box, LayoutMode::Default);
// Skip anonymous text runs that are only whitespace.