From 2b2e0a4c5a133e60a9416ad18dea49b655d4ea22 Mon Sep 17 00:00:00 2001 From: Ben Wiederhake Date: Fri, 16 Jun 2023 16:13:41 +0200 Subject: [PATCH] Tests: Use AK_MAKE_DEFAULT_MOVABLE to avoid mistakes in default impls --- Tests/AK/TestQuickSort.cpp | 4 +--- Tests/AK/TestTuple.cpp | 2 +- Tests/AK/TestVariant.cpp | 2 +- 3 files changed, 3 insertions(+), 5 deletions(-) diff --git a/Tests/AK/TestQuickSort.cpp b/Tests/AK/TestQuickSort.cpp index fbbd72326e..ffb8e93df2 100644 --- a/Tests/AK/TestQuickSort.cpp +++ b/Tests/AK/TestQuickSort.cpp @@ -14,12 +14,10 @@ TEST_CASE(sorts_without_copy) { struct NoCopy { AK_MAKE_NONCOPYABLE(NoCopy); + AK_MAKE_DEFAULT_MOVABLE(NoCopy); public: NoCopy() = default; - NoCopy(NoCopy&&) = default; - - NoCopy& operator=(NoCopy&&) = default; int value { 0 }; }; diff --git a/Tests/AK/TestTuple.cpp b/Tests/AK/TestTuple.cpp index 75e445f4be..1690f77905 100644 --- a/Tests/AK/TestTuple.cpp +++ b/Tests/AK/TestTuple.cpp @@ -53,9 +53,9 @@ TEST_CASE(no_copy) { struct NoCopy { AK_MAKE_NONCOPYABLE(NoCopy); + AK_MAKE_DEFAULT_MOVABLE(NoCopy); public: - NoCopy(NoCopy&&) = default; NoCopy() = default; }; diff --git a/Tests/AK/TestVariant.cpp b/Tests/AK/TestVariant.cpp index 88a3e5fb7d..0c191584e4 100644 --- a/Tests/AK/TestVariant.cpp +++ b/Tests/AK/TestVariant.cpp @@ -96,10 +96,10 @@ TEST_CASE(move_moves) { struct NoCopy { AK_MAKE_NONCOPYABLE(NoCopy); + AK_MAKE_DEFAULT_MOVABLE(NoCopy); public: NoCopy() = default; - NoCopy(NoCopy&&) = default; }; Variant first_variant { 42 };