system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-21 18:15:58 +00:00
Code Issues Actions 7 Packages Projects Releases Wiki Activity

Meta: Fix wrong 'using namespace X' usages

Browse source 
Apart from causing All AK:: and Crypto:: symbols being suddenly visible even though
they might not be supposed to be, the style guide also says this is wrong:

https://github.com/SerenityOS/serenity/blob/master/Documentation/CodingStyle.md#using-statements
This commit is contained in:
Ben Wiederhake 2020-08-22 20:50:48 +02:00 committed by Andreas Kling
parent 4f77ccbda8
commit 2a2630edc9
3 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
AK/NumberFormat.h
View file

@ -38,7 +38,7 @@ static String number_string_with_one_decimal(float number, const char* suffix)
return String::format("%d.%d %s", (int)number, (int)(decimals * 10), suffix);
}
static String human_readable_size(size_t size)
static inline String human_readable_size(size_t size)
{
if (size < 1 * KiB)
return String::format("%zu B", size);
@ -51,4 +51,4 @@ static String human_readable_size(size_t size)
}
using namespace AK;
using AK::human_readable_size;

2
Libraries/LibTLS/TLSv12.cpp
View file

@ -727,7 +727,7 @@ bool TLSv12::add_client_key(const ByteBuffer& certificate_pem_buffer, const Byte
if (certificate_pem_buffer.is_empty() || rsa_key.is_empty()) {
return true;
}
auto decoded_certificate = decode_pem(certificate_pem_buffer, 0);
auto decoded_certificate = Crypto::decode_pem(certificate_pem_buffer, 0);
if (decoded_certificate.is_empty()) {
dbg() << "Certificate not PEM";
return false;

1
Libraries/LibTLS/TLSv12.h
View file

@ -515,5 +515,4 @@ static constexpr const u8 RSA_SIGN_SHA512_OID[] = { 0x2a, 0x86, 0x48, 0x86, 0xf7
}
using namespace Crypto;
}