diff --git a/AK/String.h b/AK/String.h old mode 100755 new mode 100644 index 2b299841b9..fd0b707a42 --- a/AK/String.h +++ b/AK/String.h @@ -110,6 +110,13 @@ public: return m_impl->to_uppercase(); } + String reversed() const + { + if (!m_impl) + return String(); + return m_impl->reversed(); + } + Vector split_limit(char separator, int limit) const; Vector split(char separator) const; String substring(int start, int length) const; @@ -227,7 +234,6 @@ struct Traits : public GenericTraits { struct CaseInsensitiveStringTraits : public AK::Traits { static unsigned hash(const String& s) { return s.impl() ? s.to_lowercase().impl()->hash() : 0; } static bool equals(const String& a, const String& b) { return a.to_lowercase() == b.to_lowercase(); } - }; inline bool operator<(const char* characters, const String& string) @@ -264,5 +270,5 @@ inline bool operator<=(const char* characters, const String& string) } -using AK::String; using AK::CaseInsensitiveStringTraits; +using AK::String; diff --git a/AK/StringImpl.cpp b/AK/StringImpl.cpp index 5e8c6d9090..a036ef250c 100644 --- a/AK/StringImpl.cpp +++ b/AK/StringImpl.cpp @@ -4,7 +4,7 @@ #include "kmalloc.h" #ifndef __serenity__ -#include +# include #endif //#define DEBUG_STRINGIMPL @@ -172,4 +172,19 @@ void StringImpl::compute_hash() const m_has_hash = true; } +NonnullRefPtr StringImpl::reversed() const +{ + if (m_length == 0) + return the_empty_stringimpl(); + + char* buffer; + const char* pos = &m_inline_buffer[m_length - 1]; + auto new_impl = create_uninitialized(m_length, buffer); + + for (int i = 0; i < m_length; i++) + buffer[i] = *pos--; + + return new_impl; +} + } diff --git a/AK/StringImpl.h b/AK/StringImpl.h index b2b085f81d..d00a8dc857 100644 --- a/AK/StringImpl.h +++ b/AK/StringImpl.h @@ -1,7 +1,7 @@ #pragma once -#include #include +#include #include #include @@ -44,6 +44,8 @@ public: return m_hash; } + NonnullRefPtr reversed() const; + private: enum ConstructTheEmptyStringImplTag { ConstructTheEmptyStringImpl diff --git a/AK/Tests/TestString.cpp b/AK/Tests/TestString.cpp index 9a427d302e..03fbb51641 100644 --- a/AK/Tests/TestString.cpp +++ b/AK/Tests/TestString.cpp @@ -41,6 +41,7 @@ TEST_CASE(compare) EXPECT(!("a" >= String("b"))); EXPECT("a" <= String("a")); EXPECT(!("b" <= String("a"))); + EXPECT(!strcmp(test_string.reversed().characters(), "FEDCBA")); } TEST_CASE(index_access)