system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-23 11:04:40 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity

AK: Inline Optional functions more aggressively

Browse source 
This turns into much less code in the most common cases, here's why:
The normal Optional usage pattern is something like:

    auto foo = get_me_an_optional();
    if (foo.has_value())
        do_stuff_with(foo.value());

In this typical scenario, we check has_value() before calling value().
Without inlining, value() will double-check has_value() itself and
assert if it fails. Inlining allows the compiler to optimize all of
this away.
This commit is contained in:
Andreas Kling 2020-04-12 20:37:51 +02:00
parent c84b8e597a
commit 26a8984d03
1 changed files with 7 additions and 7 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

14
AK/Optional.h
View file

@ -105,12 +105,12 @@ public:
return *this;
}
~Optional()
[[gnu::always_inline]] inline ~Optional()
{
clear();
}
void clear()
[[gnu::always_inline]] inline void clear()
{
if (m_has_value) {
value().~T();
@ -119,17 +119,17 @@ public:
}
SET_TYPESTATE(consumed)
bool has_value() const { return m_has_value; }
[[gnu::always_inline]] inline bool has_value() const { return m_has_value; }
CALLABLE_WHEN(consumed)
T& value()
[[gnu::always_inline]] inline T& value()
{
ASSERT(m_has_value);
return *reinterpret_cast<T*>(&m_storage);
}
CALLABLE_WHEN(consumed)
const T& value() const
[[gnu::always_inline]] inline const T& value() const
{
return value_without_consume_state();
}
@ -144,7 +144,7 @@ public:
return released_value;
}
T value_or(const T& fallback) const
[[gnu::always_inline]] inline T value_or(const T& fallback) const
{
if (m_has_value)
return value();
@ -153,7 +153,7 @@ public:
private:
// Call when we don't want to alter the consume state
const T& value_without_consume_state() const
[[gnu::always_inline]] inline const T& value_without_consume_state() const
{
ASSERT(m_has_value);
return *reinterpret_cast<const T*>(&m_storage);