system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-07 00:19:27 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibJS/JIT: Add fast path for UnsignedRightShift

Browse source
This commit is contained in:
iliadsh 2023-11-07 04:28:12 +00:00 committed by Andreas Kling
parent c956316c98
commit 24d5070520
3 changed files with 56 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

17
Userland/Libraries/LibJIT/X86_64/Assembler.h
View file

@ -583,6 +583,23 @@ struct X86_64Assembler {
}
}
void shift_right32(Operand dest, Optional<Operand> count)
{
VERIFY(dest.type == Operand::Type::Reg);
if (count.has_value()) {
VERIFY(count->type == Operand::Type::Imm);
VERIFY(count->fits_in_u8());
emit_rex_for_slash(dest, REX_W::No);
emit8(0xc1);
emit_modrm_slash(5, dest);
emit8(count->offset_or_immediate);
} else {
emit_rex_for_slash(dest, REX_W::No);
emit8(0xd3);
emit_modrm_slash(5, dest);
}
}
void arithmetic_right_shift32(Operand dest, Optional<Operand> count)
{
VERIFY(dest.type == Operand::Type::Reg);

38
Userland/Libraries/LibJS/JIT/Compiler.cpp
View file

@ -838,6 +838,44 @@ void Compiler::compile_right_shift(Bytecode::Op::RightShift const& op)
end.link(m_assembler);
}
static Value cxx_unsigned_right_shift(VM& vm, Value lhs, Value rhs)
{
return TRY_OR_SET_EXCEPTION(unsigned_right_shift(vm, lhs, rhs));
}
void Compiler::compile_unsigned_right_shift(Bytecode::Op::UnsignedRightShift const& op)
{
load_vm_register(ARG1, op.lhs());
load_accumulator(ARG2);
Assembler::Label end {};
branch_if_both_int32(ARG1, ARG2, [&] {
// RCX = ARG2
m_assembler.mov(
Assembler::Operand::Register(Assembler::Reg::RCX),
Assembler::Operand::Register(ARG2));
// ARG1 >>>= CL (32-bit)
m_assembler.shift_right32(Assembler::Operand::Register(ARG1), {});
// accumulator = ARG1 | SHIFTED_INT32_TAG;
m_assembler.mov(
Assembler::Operand::Register(GPR0),
Assembler::Operand::Imm(SHIFTED_INT32_TAG));
m_assembler.bitwise_or(
Assembler::Operand::Register(ARG1),
Assembler::Operand::Register(GPR0));
store_accumulator(ARG1);
m_assembler.jump(end);
});
native_call((void*)cxx_unsigned_right_shift);
store_accumulator(RET);
check_exception();
end.link(m_assembler);
}
static ThrowCompletionOr<Value> not_(VM&, Value value)
{
return Value(!value.to_boolean());

3
Userland/Libraries/LibJS/JIT/Compiler.h
View file

@ -52,8 +52,7 @@ private:
O(LooselyInequals, abstract_inequals) \
O(LooselyEquals, abstract_equals) \
O(StrictlyInequals, typed_inequals) \
O(StrictlyEquals, typed_equals) \
O(UnsignedRightShift, unsigned_right_shift)
O(StrictlyEquals, typed_equals)
# define JS_ENUMERATE_NEW_BUILTIN_ERROR_BYTECODE_OPS(O) \
O(NewTypeError, new_type_error, TypeError)