system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-15 04:13:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

LibCrypto: Remove some now-unused (and incorrect) methods

Browse source 
Removes the UnsignedBigInteger overloads of
SignedBigInteger::binary_{and,or,xor}(). They're now unused, and they
also didn't work when *this was negative.
This commit is contained in:
Nico Weber 2022-01-17 20:12:06 -05:00 committed by Ali Mohammad Pur
parent d9b6eb29bc
commit 2392f65345
2 changed files with 0 additions and 18 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

15
Userland/Libraries/LibCrypto/BigInt/SignedBigInteger.cpp
View file

@ -143,21 +143,6 @@ FLATTEN SignedBigInteger SignedBigInteger::minus(const UnsignedBigInteger& other
return { other.minus(m_unsigned_data), true };
}
FLATTEN SignedBigInteger SignedBigInteger::bitwise_or(const UnsignedBigInteger& other) const
{
return { unsigned_value().bitwise_or(other), m_sign };
}
FLATTEN SignedBigInteger SignedBigInteger::bitwise_and(const UnsignedBigInteger& other) const
{
return { unsigned_value().bitwise_and(other), false };
}
FLATTEN SignedBigInteger SignedBigInteger::bitwise_xor(const UnsignedBigInteger& other) const
{
return { unsigned_value().bitwise_xor(other), m_sign };
}
FLATTEN SignedBigInteger SignedBigInteger::bitwise_not() const
{
// Bitwise operators assume two's complement, while SignedBigInteger uses sign-magnitude.

3
Userland/Libraries/LibCrypto/BigInt/SignedBigInteger.h
View file

@ -109,9 +109,6 @@ public:
SignedBigInteger plus(const UnsignedBigInteger& other) const;
SignedBigInteger minus(const UnsignedBigInteger& other) const;
SignedBigInteger bitwise_or(const UnsignedBigInteger& other) const;
SignedBigInteger bitwise_and(const UnsignedBigInteger& other) const;
SignedBigInteger bitwise_xor(const UnsignedBigInteger& other) const;
SignedBigInteger multiplied_by(const UnsignedBigInteger& other) const;
SignedDivisionResult divided_by(const UnsignedBigInteger& divisor) const;