system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-14 20:03:29 +00:00
Code Issues Packages Projects Releases Wiki Activity

Tests: Use .is_flag_set() instead of bitwise & in Regex flag tests

Browse source 
The default flag might not be zero, so don't assume masking off flags
will yield zero.
This commit is contained in:
Ali Mohammad Pur 2023-02-15 10:27:57 +03:30 committed by Andreas Kling
parent 5dce916a50
commit 1e022295c4
1 changed files with 35 additions and 35 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

70
Tests/LibRegex/Regex.cpp
View file

@ -36,33 +36,33 @@ TEST_CASE(regex_options_ecmascript)
ECMAScriptOptions eo; ECMAScriptOptions eo;
eo |= ECMAScriptFlags::Global; eo |= ECMAScriptFlags::Global;
EXPECT(eo & ECMAScriptFlags::Global); EXPECT(eo.has_flag_set(ECMAScriptFlags::Global));
EXPECT(!(eo & ECMAScriptFlags::Insensitive)); EXPECT(!eo.has_flag_set(ECMAScriptFlags::Insensitive));
eo = match_test_api_options(ECMAScriptFlags::Global | ECMAScriptFlags::Insensitive | ECMAScriptFlags::Sticky); eo = match_test_api_options(ECMAScriptFlags::Global | ECMAScriptFlags::Insensitive | ECMAScriptFlags::Sticky);
EXPECT(eo & ECMAScriptFlags::Global); EXPECT(eo.has_flag_set(ECMAScriptFlags::Global));
EXPECT(eo & ECMAScriptFlags::Insensitive); EXPECT(eo.has_flag_set(ECMAScriptFlags::Insensitive));
EXPECT(eo & ECMAScriptFlags::Sticky); EXPECT(eo.has_flag_set(ECMAScriptFlags::Sticky));
EXPECT(!(eo & ECMAScriptFlags::Unicode)); EXPECT(!eo.has_flag_set(ECMAScriptFlags::Unicode));
EXPECT(!(eo & ECMAScriptFlags::Multiline)); EXPECT(!eo.has_flag_set(ECMAScriptFlags::Multiline));
EXPECT(!(eo & ECMAScriptFlags::SingleLine)); EXPECT(!eo.has_flag_set(ECMAScriptFlags::SingleLine));
eo &= ECMAScriptFlags::Insensitive; eo &= ECMAScriptFlags::Insensitive;
EXPECT(!(eo & ECMAScriptFlags::Global)); EXPECT(!eo.has_flag_set(ECMAScriptFlags::Global));
EXPECT(eo & ECMAScriptFlags::Insensitive); EXPECT(eo.has_flag_set(ECMAScriptFlags::Insensitive));
EXPECT(!(eo & ECMAScriptFlags::Multiline)); EXPECT(!eo.has_flag_set(ECMAScriptFlags::Multiline));
eo &= ECMAScriptFlags::Sticky; eo &= ECMAScriptFlags::Sticky;
EXPECT(!(eo & ECMAScriptFlags::Global)); EXPECT(!eo.has_flag_set(ECMAScriptFlags::Global));
EXPECT(!(eo & ECMAScriptFlags::Insensitive)); EXPECT(!eo.has_flag_set(ECMAScriptFlags::Insensitive));
EXPECT(!(eo & ECMAScriptFlags::Multiline)); EXPECT(!eo.has_flag_set(ECMAScriptFlags::Multiline));
EXPECT(!(eo & ECMAScriptFlags::Sticky)); EXPECT(!eo.has_flag_set(ECMAScriptFlags::Sticky));
eo = ~ECMAScriptFlags::Insensitive; eo = ~ECMAScriptFlags::Insensitive;
EXPECT(eo & ECMAScriptFlags::Global); EXPECT(eo.has_flag_set(ECMAScriptFlags::Global));
EXPECT(!(eo & ECMAScriptFlags::Insensitive)); EXPECT(!eo.has_flag_set(ECMAScriptFlags::Insensitive));
EXPECT(eo & ECMAScriptFlags::Multiline); EXPECT(eo.has_flag_set(ECMAScriptFlags::Multiline));
EXPECT(eo & ECMAScriptFlags::Sticky); EXPECT(eo.has_flag_set(ECMAScriptFlags::Sticky));
} }
TEST_CASE(regex_options_posix) TEST_CASE(regex_options_posix)
@ -70,30 +70,30 @@ TEST_CASE(regex_options_posix)
PosixOptions eo; PosixOptions eo;
eo |= PosixFlags::Global; eo |= PosixFlags::Global;
EXPECT(eo & PosixFlags::Global); EXPECT(eo.has_flag_set(PosixFlags::Global));
EXPECT(!(eo & PosixFlags::Insensitive)); EXPECT(!eo.has_flag_set(PosixFlags::Insensitive));
eo = match_test_api_options(PosixFlags::Global | PosixFlags::Insensitive | PosixFlags::MatchNotBeginOfLine); eo = match_test_api_options(PosixFlags::Global | PosixFlags::Insensitive | PosixFlags::MatchNotBeginOfLine);
EXPECT(eo & PosixFlags::Global); EXPECT(eo.has_flag_set(PosixFlags::Global));
EXPECT(eo & PosixFlags::Insensitive); EXPECT(eo.has_flag_set(PosixFlags::Insensitive));
EXPECT(eo & PosixFlags::MatchNotBeginOfLine); EXPECT(eo.has_flag_set(PosixFlags::MatchNotBeginOfLine));
EXPECT(!(eo & PosixFlags::Unicode)); EXPECT(!eo.has_flag_set(PosixFlags::Unicode));
EXPECT(!(eo & PosixFlags::Multiline)); EXPECT(!eo.has_flag_set(PosixFlags::Multiline));
eo &= PosixFlags::Insensitive; eo &= PosixFlags::Insensitive;
EXPECT(!(eo & PosixFlags::Global)); EXPECT(!eo.has_flag_set(PosixFlags::Global));
EXPECT(eo & PosixFlags::Insensitive); EXPECT(eo.has_flag_set(PosixFlags::Insensitive));
EXPECT(!(eo & PosixFlags::Multiline)); EXPECT(!eo.has_flag_set(PosixFlags::Multiline));
eo &= PosixFlags::MatchNotBeginOfLine; eo &= PosixFlags::MatchNotBeginOfLine;
EXPECT(!(eo & PosixFlags::Global)); EXPECT(!eo.has_flag_set(PosixFlags::Global));
EXPECT(!(eo & PosixFlags::Insensitive)); EXPECT(!eo.has_flag_set(PosixFlags::Insensitive));
EXPECT(!(eo & PosixFlags::Multiline)); EXPECT(!eo.has_flag_set(PosixFlags::Multiline));
eo = ~PosixFlags::Insensitive; eo = ~PosixFlags::Insensitive;
EXPECT(eo & PosixFlags::Global); EXPECT(eo.has_flag_set(PosixFlags::Global));
EXPECT(!(eo & PosixFlags::Insensitive)); EXPECT(!eo.has_flag_set(PosixFlags::Insensitive));
EXPECT(eo & PosixFlags::Multiline); EXPECT(eo.has_flag_set(PosixFlags::Multiline));
} }
TEST_CASE(regex_lexer) TEST_CASE(regex_lexer)