From 19a87fce36edc1fcfb57c6fedaaf2e43a40036b3 Mon Sep 17 00:00:00 2001 From: Brian Gianforcaro Date: Wed, 28 Dec 2022 15:03:30 -0800 Subject: [PATCH] Meta: Disable PVS Studio v1052 static analysis rule in github actions This rule conflicts with the projects style guide, and ends up being just a bunch of unnecessary noise. So lets just suppress it. --- .github/workflows/pvs-studio-static-analysis.yml | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/.github/workflows/pvs-studio-static-analysis.yml b/.github/workflows/pvs-studio-static-analysis.yml index c8da2ebf5a..099cb8c4e6 100644 --- a/.github/workflows/pvs-studio-static-analysis.yml +++ b/.github/workflows/pvs-studio-static-analysis.yml @@ -124,11 +124,14 @@ jobs: # Our TRY(..) macro seems to breaks this rule and trigger weird behavior in PVS Studio. # # - v677: Custom declaration of a standard '' type. The declaration from system header files should be used instead. - # This rule doesn't make sense for Serenity, as We are the system headers. + # This rule doesn't make sense for Serenity, as we are the system headers. # # - v1061: Extending the 'std' namespace may result in undefined behavior. # We have no choice, some features of C++ require us to. # + # - V1052: Declaring virtual methods in a class marked as 'final' is pointless. + # This rule contradicts the serenity style rules. + # # - False Positives: # v591: Non-void function should return a value. # v603: Object was created but is not being used. @@ -138,7 +141,7 @@ jobs: - name: Filter PVS Log working-directory: ${{ github.workspace }}/Build/${{ env.PVS_STUDIO_ANALYSIS_ARCH }} run: | - pvs-studio-analyzer suppress -v530 -v591 -v603 -v677 -v1047 -v1061 -v1076 project.plog + pvs-studio-analyzer suppress -v530 -v591 -v603 -v677 -v1047 -v1052 -v1061 -v1076 project.plog pvs-studio-analyzer filter-suppressed project.plog - name: Print PVS Log