system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-15 04:13:11 +00:00
Code Issues Packages Projects Releases Wiki Activity

BufferStream: It's not an error to read up to the very end of a buffer

Browse source 
Don't signal an error before we've reached the very end of the buffer.
This commit is contained in:
Andreas Kling 2019-08-03 19:20:05 +02:00
parent 6e956f2a0b
commit 18aeda2e0d
1 changed files with 8 additions and 8 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

16
AK/BufferStream.h
View file

@ -24,7 +24,7 @@ public:
}
BufferStream& operator>>(i8& value)
{
if (m_offset + sizeof(value) >= unsigned(m_buffer.size())) {
if (m_offset + sizeof(value) > unsigned(m_buffer.size())) {
m_read_failure = true;
return *this;
}
@ -39,7 +39,7 @@ public:
}
BufferStream& operator>>(u8& value )
{
if (m_offset + sizeof(value) >= unsigned(m_buffer.size())) {
if (m_offset + sizeof(value) > unsigned(m_buffer.size())) {
m_read_failure = true;
return *this;
}
@ -54,7 +54,7 @@ public:
}
BufferStream& operator>>(bool& value )
{
if (m_offset + sizeof(value) >= unsigned(m_buffer.size())) {
if (m_offset + sizeof(value) > unsigned(m_buffer.size())) {
m_read_failure = true;
return *this;
}
@ -69,7 +69,7 @@ public:
}
BufferStream& operator>>(char& value)
{
if (m_offset + sizeof(value) >= unsigned(m_buffer.size())) {
if (m_offset + sizeof(value) > unsigned(m_buffer.size())) {
m_read_failure = true;
return *this;
}
@ -85,7 +85,7 @@ public:
}
BufferStream& operator>>(u16& value)
{
if (m_offset + sizeof(value) >= unsigned(m_buffer.size())) {
if (m_offset + sizeof(value) > unsigned(m_buffer.size())) {
m_read_failure = true;
return *this;
}
@ -105,7 +105,7 @@ public:
}
BufferStream& operator>>(i16& value)
{
if (m_offset + sizeof(value) >= unsigned(m_buffer.size())) {
if (m_offset + sizeof(value) > unsigned(m_buffer.size())) {
m_read_failure = true;
return *this;
}
@ -127,7 +127,7 @@ public:
}
BufferStream& operator>>(u32& value)
{
if (m_offset + sizeof(value) >= unsigned(m_buffer.size())) {
if (m_offset + sizeof(value) > unsigned(m_buffer.size())) {
m_read_failure = true;
return *this;
}
@ -153,7 +153,7 @@ public:
}
BufferStream& operator>>(i32& value)
{
if (m_offset + sizeof(value) >= unsigned(m_buffer.size())) {
if (m_offset + sizeof(value) > unsigned(m_buffer.size())) {
m_read_failure = true;
return *this;
}