Applications: Use default constructors/destructors

https://isocpp.github.io/CppCoreGuidelines/CppCoreGuidelines#cother-other-default-operation-rules

"The compiler is more likely to get the default semantics right and
you cannot implement these functions better than the compiler."

Userland/Applications/3DFileViewer/MeshLoader.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2021, Jesse Buhagiar <jooster669@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -14,8 +15,8 @@
 
 class MeshLoader {
 public:
-    MeshLoader() { }
-    virtual ~MeshLoader() { }
+    MeshLoader() = default;
+    virtual ~MeshLoader() = default;
 
     virtual RefPtr<Mesh> load(Core::File& file) = 0;
 };

Userland/Applications/3DFileViewer/WavefrontOBJLoader.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2021, Jesse Buhagiar <jooster669@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -14,8 +15,8 @@
 
 class WavefrontOBJLoader final : public MeshLoader {
 public:
-    WavefrontOBJLoader() { }
-    ~WavefrontOBJLoader() override { }
+    WavefrontOBJLoader() = default;
+    ~WavefrontOBJLoader() override = default;
 
     RefPtr<Mesh> load(Core::File& file) override;
 };

Userland/Applications/Browser/BrowserWindow.cpp

@@ -2,6 +2,7 @@
  * Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2021, Jakob-Niklas See <git@nwex.de>
  * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -131,10 +132,6 @@ BrowserWindow::BrowserWindow(CookieJar& cookie_jar, URL url)
     create_new_tab(move(url), true);
 }
 
-BrowserWindow::~BrowserWindow()
-{
-}
-
 void BrowserWindow::build_menus()
 {
     auto& file_menu = add_menu("&File");

Userland/Applications/Browser/BrowserWindow.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -21,7 +22,7 @@ class BrowserWindow final : public GUI::Window {
     C_OBJECT(BrowserWindow);
 
 public:
-    virtual ~BrowserWindow() override;
+    virtual ~BrowserWindow() override = default;
 
     GUI::TabWidget& tab_widget();
     Tab& active_tab();

Userland/Applications/Browser/ConsoleWidget.cpp

@@ -2,6 +2,7 @@
  * Copyright (c) 2020, Hunter Salyer <thefalsehonesty@gmail.com>
  * Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -68,10 +69,6 @@ ConsoleWidget::ConsoleWidget()
     };
 }
 
-ConsoleWidget::~ConsoleWidget()
-{
-}
-
 void ConsoleWidget::request_console_messages()
 {
     VERIFY(!m_waiting_for_messages);

Userland/Applications/Browser/ConsoleWidget.h

@@ -2,6 +2,7 @@
  * Copyright (c) 2020, Hunter Salyer <thefalsehonesty@gmail.com>
  * Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -17,7 +18,7 @@ namespace Browser {
 class ConsoleWidget final : public GUI::Widget {
     C_OBJECT(ConsoleWidget)
 public:
-    virtual ~ConsoleWidget();
+    virtual ~ConsoleWidget() = default;
 
     void notify_about_new_console_message(i32 message_index);
     void handle_console_messages(i32 start_index, Vector<String> const& message_types, Vector<String> const& messages);

Userland/Applications/Browser/DownloadWidget.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020-2021, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -110,10 +111,6 @@ DownloadWidget::DownloadWidget(const URL& url)
     };
 }
 
-DownloadWidget::~DownloadWidget()
-{
-}
-
 void DownloadWidget::did_progress(Optional<u32> total_size, u32 downloaded_size)
 {
     m_progressbar->set_min(0);

Userland/Applications/Browser/DownloadWidget.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -20,7 +21,7 @@ class DownloadWidget final : public GUI::Widget {
     C_OBJECT(DownloadWidget);
 
 public:
-    virtual ~DownloadWidget() override;
+    virtual ~DownloadWidget() override = default;
 
 private:
     explicit DownloadWidget(const URL&);

Userland/Applications/Browser/InspectorWidget.cpp

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -95,10 +96,6 @@ InspectorWidget::InspectorWidget()
     m_dom_tree_view->set_focus(true);
 }
 
-InspectorWidget::~InspectorWidget()
-{
-}
-
 void InspectorWidget::select_default_node()
 {
     clear_style_json();

Userland/Applications/Browser/InspectorWidget.h

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -15,7 +16,7 @@ namespace Browser {
 class InspectorWidget final : public GUI::Widget {
     C_OBJECT(InspectorWidget)
 public:
-    virtual ~InspectorWidget();
+    virtual ~InspectorWidget() = default;
 
     void set_web_view(NonnullRefPtr<Web::OutOfProcessWebView> web_view) { m_web_view = web_view; }
     void set_dom_json(String);

Userland/Applications/Browser/Tab.cpp

@@ -2,6 +2,7 @@
  * Copyright (c) 2020-2021, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2021, Maciej Zygmanowski <sppmacd@pm.me>
  * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -351,10 +352,6 @@ Tab::Tab(BrowserWindow& window)
     };
 }
 
-Tab::~Tab()
-{
-}
-
 void Tab::load(const URL& url, LoadType load_type)
 {
     m_is_history_navigation = (load_type == LoadType::HistoryNavigation);

Userland/Applications/Browser/Tab.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020-2021, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -32,7 +33,7 @@ class Tab final : public GUI::Widget {
     friend class BrowserWindow;
 
 public:
-    virtual ~Tab() override;
+    virtual ~Tab() override = default;
 
     URL url() const;
 

Userland/Applications/BrowserSettings/BrowserSettingsWidget.cpp

@@ -105,10 +105,6 @@ BrowserSettingsWidget::BrowserSettingsWidget()
     m_auto_close_download_windows_checkbox->set_checked(Config::read_bool("Browser", "Preferences", "CloseDownloadWidgetOnFinish", default_auto_close_download_windows), GUI::AllowCallback::No);
 }
 
-BrowserSettingsWidget::~BrowserSettingsWidget()
-{
-}
-
 void BrowserSettingsWidget::set_color_scheme(StringView color_scheme)
 {
     bool found_color_scheme = false;

Userland/Applications/BrowserSettings/BrowserSettingsWidget.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -14,7 +15,7 @@
 class BrowserSettingsWidget final : public GUI::SettingsWindow::Tab {
     C_OBJECT(BrowserSettingsWidget)
 public:
-    virtual ~BrowserSettingsWidget() override;
+    virtual ~BrowserSettingsWidget() override = default;
 
     virtual void apply_settings() override;
     virtual void reset_default_values() override;

Userland/Applications/Calculator/Calculator.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -9,14 +10,6 @@
 #include <AK/Assertions.h>
 #include <AK/Math.h>
 
-Calculator::Calculator()
-{
-}
-
-Calculator::~Calculator()
-{
-}
-
 KeypadValue Calculator::begin_operation(Operation operation, KeypadValue argument)
 {
     KeypadValue res = 0;

Userland/Applications/Calculator/Calculator.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -17,8 +18,8 @@
 
 class Calculator final {
 public:
-    Calculator();
-    ~Calculator();
+    Calculator() = default;
+    ~Calculator() = default;
 
     enum class Operation {
         None,

Userland/Applications/Calculator/CalculatorWidget.cpp

@@ -2,6 +2,7 @@
  * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
  * Copyright (c) 2021, Glenford Williams <gw_dev@outlook.com>
  * Copyright (c) 2021, Max Wipfli <mail@maxwipfli.ch>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -104,10 +105,6 @@ CalculatorWidget::CalculatorWidget()
     };
 }
 
-CalculatorWidget::~CalculatorWidget()
-{
-}
-
 void CalculatorWidget::add_operation_button(GUI::Button& button, Calculator::Operation operation)
 {
     button.on_click = [this, operation](auto) {

Userland/Applications/Calculator/CalculatorWidget.h

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
  * Copyright (c) 2021, Glenford Williams <gw_dev@outlook.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -16,7 +17,7 @@
 class CalculatorWidget final : public GUI::Widget {
     C_OBJECT(CalculatorWidget)
 public:
-    virtual ~CalculatorWidget() override;
+    virtual ~CalculatorWidget() override = default;
     String get_entry();
     void set_entry(KeypadValue);
 

Userland/Applications/Calculator/Keypad.cpp

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
  * Copyright (c) 2021, Max Wipfli <mail@maxwipfli.ch>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -10,14 +11,6 @@
 #include <AK/IntegralMath.h>
 #include <AK/StringBuilder.h>
 
-Keypad::Keypad()
-{
-}
-
-Keypad::~Keypad()
-{
-}
-
 void Keypad::type_digit(int digit)
 {
     u64 previous_value = 0;

Userland/Applications/Calculator/Keypad.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -16,8 +17,8 @@
 
 class Keypad final {
 public:
-    Keypad();
-    ~Keypad();
+    Keypad() = default;
+    ~Keypad() = default;
 
     void type_digit(int digit);
     void type_decimal_point();

Userland/Applications/Calendar/AddEventDialog.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2019-2020, Ryan Grieb <ryan.m.grieb@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -86,18 +87,6 @@ AddEventDialog::AddEventDialog(Core::DateTime date_time, Window* parent_window)
     event_title_textbox.set_focus(true);
 }
 
-AddEventDialog::~AddEventDialog()
-{
-}
-
-AddEventDialog::MonthListModel::MonthListModel()
-{
-}
-
-AddEventDialog::MonthListModel::~MonthListModel()
-{
-}
-
 int AddEventDialog::MonthListModel::row_count(const GUI::ModelIndex&) const
 {
     return 12;

Userland/Applications/Calendar/AddEventDialog.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2019-2020, Ryan Grieb <ryan.m.grieb@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -14,7 +15,7 @@
 class AddEventDialog final : public GUI::Dialog {
     C_OBJECT(AddEventDialog)
 public:
-    virtual ~AddEventDialog() override;
+    virtual ~AddEventDialog() override = default;
 
     static void show(Core::DateTime date_time, Window* parent_window = nullptr)
     {
@@ -33,7 +34,7 @@ private:
         };
 
         static NonnullRefPtr<MonthListModel> create() { return adopt_ref(*new MonthListModel); }
-        virtual ~MonthListModel() override;
+        virtual ~MonthListModel() override = default;
 
         virtual int row_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override;
         virtual int column_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override { return Column::__Count; }
@@ -41,7 +42,7 @@ private:
         virtual GUI::Variant data(const GUI::ModelIndex&, GUI::ModelRole) const override;
 
     private:
-        MonthListModel();
+        MonthListModel() = default;
     };
 
     Core::DateTime m_date_time;

Userland/Applications/CharacterMap/CharacterMapWidget.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -123,10 +124,6 @@ CharacterMapWidget::CharacterMapWidget()
     update_statusbar();
 }
 
-CharacterMapWidget::~CharacterMapWidget()
-{
-}
-
 void CharacterMapWidget::initialize_menubar(GUI::Window& window)
 {
     auto& file_menu = window.add_menu("&File");

Userland/Applications/CharacterMap/CharacterMapWidget.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -14,7 +15,7 @@ class CharacterMapWidget final : public GUI::Widget {
     C_OBJECT(CharacterMapWidget);
 
 public:
-    virtual ~CharacterMapWidget() override;
+    virtual ~CharacterMapWidget() override = default;
 
     void initialize_menubar(GUI::Window& window);
 

Userland/Applications/CharacterMap/CharacterSearchWidget.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -16,7 +17,7 @@ struct SearchResult {
 
 class CharacterSearchModel final : public GUI::Model {
 public:
-    CharacterSearchModel() { }
+    CharacterSearchModel() = default;
 
     int row_count(GUI::ModelIndex const&) const override { return m_data.size(); }
     int column_count(GUI::ModelIndex const&) const override { return 2; }
@@ -72,10 +73,6 @@ CharacterSearchWidget::CharacterSearchWidget()
     };
 }
 
-CharacterSearchWidget::~CharacterSearchWidget()
-{
-}
-
 void CharacterSearchWidget::search()
 {
     // TODO: Sort the results nicely. They're sorted by code-point for now, which is easy, but not the most useful.

Userland/Applications/CharacterMap/CharacterSearchWidget.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2022, Sam Atkins <atkinssj@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -15,7 +16,7 @@ class CharacterSearchWidget final : public GUI::Widget {
     C_OBJECT(CharacterSearchWidget);
 
 public:
-    virtual ~CharacterSearchWidget() override;
+    virtual ~CharacterSearchWidget() override = default;
 
     Function<void(u32)> on_character_selected;
 

Userland/Applications/DisplaySettings/BackgroundSettingsWidget.cpp

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2019-2020, Jesse Buhagiar <jooster669@gmail.com>
  * Copyright (c) 2020-2021, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -40,10 +41,6 @@ BackgroundSettingsWidget::BackgroundSettingsWidget()
     load_current_settings();
 }
 
-BackgroundSettingsWidget::~BackgroundSettingsWidget()
-{
-}
-
 void BackgroundSettingsWidget::create_frame()
 {
     load_from_gml(background_settings_gml);

Userland/Applications/DisplaySettings/BackgroundSettingsWidget.h

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2019-2020, Jesse Buhagiar <jooster669@gmail.com>
  * Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -21,7 +22,7 @@ class BackgroundSettingsWidget : public GUI::SettingsWindow::Tab {
     C_OBJECT(BackgroundSettingsWidget);
 
 public:
-    virtual ~BackgroundSettingsWidget() override;
+    virtual ~BackgroundSettingsWidget() override = default;
 
     virtual void apply_settings() override;
 

Userland/Applications/DisplaySettings/DesktopSettingsWidget.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2020, the SerenityOS developers.
+ * Copyright (c) 2020-2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -21,10 +21,6 @@ DesktopSettingsWidget::DesktopSettingsWidget()
     load_current_settings();
 }
 
-DesktopSettingsWidget::~DesktopSettingsWidget()
-{
-}
-
 void DesktopSettingsWidget::create_frame()
 {
     load_from_gml(desktop_settings_gml);

Userland/Applications/DisplaySettings/DesktopSettingsWidget.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2020, the SerenityOS developers.
+ * Copyright (c) 2020-2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -16,7 +16,7 @@ class DesktopSettingsWidget : public GUI::SettingsWindow::Tab {
     C_OBJECT(DesktopSettingsWidget);
 
 public:
-    virtual ~DesktopSettingsWidget() override;
+    virtual ~DesktopSettingsWidget() override = default;
 
     virtual void apply_settings() override;
 

Userland/Applications/DisplaySettings/FontSettingsWidget.cpp

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2021, Thomas Keppler <winfr34k@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -45,10 +46,6 @@ FontSettingsWidget::FontSettingsWidget()
     };
 }
 
-FontSettingsWidget::~FontSettingsWidget()
-{
-}
-
 static void update_label_with_font(GUI::Label& label, Gfx::Font const& font)
 {
     label.set_text(font.human_readable_name());

Userland/Applications/DisplaySettings/FontSettingsWidget.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -15,7 +16,7 @@ class FontSettingsWidget final : public GUI::SettingsWindow::Tab {
     C_OBJECT(FontSettingsWidget);
 
 public:
-    virtual ~FontSettingsWidget() override;
+    virtual ~FontSettingsWidget() override = default;
 
     virtual void apply_settings() override;
 

Userland/Applications/FileManager/DesktopWidget.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -9,14 +10,6 @@
 
 namespace FileManager {
 
-DesktopWidget::DesktopWidget()
-{
-}
-
-DesktopWidget::~DesktopWidget()
-{
-}
-
 void DesktopWidget::paint_event(GUI::PaintEvent& event)
 {
     GUI::Painter painter(*this);

Userland/Applications/FileManager/DesktopWidget.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -14,12 +15,12 @@ class DesktopWidget final : public GUI::Widget {
     C_OBJECT(DesktopWidget);
 
 public:
-    virtual ~DesktopWidget() override;
+    virtual ~DesktopWidget() override = default;
 
 private:
     virtual void paint_event(GUI::PaintEvent&) override;
 
-    DesktopWidget();
+    DesktopWidget() = default;
 };
 
 }

Userland/Applications/FileManager/PropertiesWindow.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -162,10 +163,6 @@ PropertiesWindow::PropertiesWindow(String const& path, bool disable_rename, Wind
     update();
 }
 
-PropertiesWindow::~PropertiesWindow()
-{
-}
-
 void PropertiesWindow::update()
 {
     m_icon->set_bitmap(GUI::FileIconProvider::icon_for_path(make_full_path(m_name), m_mode).bitmap_for_size(32));

Userland/Applications/FileManager/PropertiesWindow.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -18,7 +19,7 @@ class PropertiesWindow final : public GUI::Window {
     C_OBJECT(PropertiesWindow);
 
 public:
-    virtual ~PropertiesWindow() override;
+    virtual ~PropertiesWindow() override = default;
 
 private:
     PropertiesWindow(String const& path, bool disable_rename, Window* parent = nullptr);

Userland/Applications/FontEditor/FontEditor.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -437,10 +438,6 @@ FontEditorWidget::FontEditorWidget()
     set_scale(scale);
 }
 
-FontEditorWidget::~FontEditorWidget()
-{
-}
-
 void FontEditorWidget::initialize(String const& path, RefPtr<Gfx::BitmapFont>&& edited_font)
 {
     if (m_edited_font == edited_font)

Userland/Applications/FontEditor/FontEditor.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -21,7 +22,7 @@ class FontEditorWidget final
     , public Config::Listener {
     C_OBJECT(FontEditorWidget)
 public:
-    virtual ~FontEditorWidget() override;
+    virtual ~FontEditorWidget() override = default;
 
     bool open_file(String const&);
     bool save_file(String const&);

Userland/Applications/FontEditor/GlyphEditorWidget.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -13,10 +14,6 @@
 #include <LibGfx/Palette.h>
 #include <string.h>
 
-GlyphEditorWidget::~GlyphEditorWidget()
-{
-}
-
 void GlyphEditorWidget::initialize(Gfx::BitmapFont& mutable_font)
 {
     if (m_font == mutable_font)

Userland/Applications/FontEditor/GlyphEditorWidget.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -23,7 +24,7 @@ public:
         Counterclockwise
     };
 
-    virtual ~GlyphEditorWidget() override;
+    virtual ~GlyphEditorWidget() override = default;
 
     void initialize(Gfx::BitmapFont&);
 

Userland/Applications/Help/ManualNode.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -11,7 +12,7 @@
 
 class ManualNode {
 public:
-    virtual ~ManualNode() { }
+    virtual ~ManualNode() = default;
 
     virtual NonnullOwnPtrVector<ManualNode>& children() const = 0;
     virtual const ManualNode* parent() const = 0;

Userland/Applications/Help/ManualPageNode.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */

Userland/Applications/Help/ManualPageNode.h

@@ -12,7 +12,7 @@ class ManualSectionNode;
 
 class ManualPageNode : public ManualNode {
 public:
-    virtual ~ManualPageNode() override { }
+    virtual ~ManualPageNode() override = default;
 
     ManualPageNode(const ManualSectionNode& section, StringView page)
         : m_section(section)

Userland/Applications/Help/ManualSectionNode.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2019-2020, Sergey Bugaev <bugaevc@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -10,7 +11,7 @@
 
 class ManualSectionNode : public ManualNode {
 public:
-    virtual ~ManualSectionNode() override { }
+    virtual ~ManualSectionNode() override = default;
 
     ManualSectionNode(String section, String name)
         : m_section(section)

Userland/Applications/HexEditor/FindDialog.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, the SerenityOS developers.
+ * Copyright (c) 2021-2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -150,7 +150,3 @@ FindDialog::FindDialog()
         done(ExecResult::ExecCancel);
     };
 }
-
-FindDialog::~FindDialog()
-{
-}

Userland/Applications/HexEditor/FindDialog.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, the SerenityOS developers.
+ * Copyright (c) 2021-2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -29,7 +29,7 @@ private:
     bool find_all() const { return m_find_all; }
 
     FindDialog();
-    virtual ~FindDialog() override;
+    virtual ~FindDialog() override = default;
 
     RefPtr<GUI::TextEditor> m_text_editor;
     RefPtr<GUI::Button> m_find_button;

Userland/Applications/HexEditor/GoToOffsetDialog.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, the SerenityOS developers.
+ * Copyright (c) 2021-2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -146,7 +146,3 @@ GoToOffsetDialog::GoToOffsetDialog()
 
     update_statusbar();
 }
-
-GoToOffsetDialog::~GoToOffsetDialog()
-{
-}

Userland/Applications/HexEditor/GoToOffsetDialog.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, the SerenityOS developers.
+ * Copyright (c) 2021-2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -18,7 +18,7 @@ public:
 
 private:
     GoToOffsetDialog();
-    virtual ~GoToOffsetDialog() override;
+    virtual ~GoToOffsetDialog() override = default;
     void update_statusbar();
     int process_input();
     int calculate_new_offset(int offset);

Userland/Applications/HexEditor/HexEditor.cpp

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -47,10 +48,6 @@ HexEditor::HexEditor()
     m_blink_timer->start();
 }
 
-HexEditor::~HexEditor()
-{
-}
-
 void HexEditor::set_readonly(bool readonly)
 {
     if (m_readonly == readonly)

Userland/Applications/HexEditor/HexEditor.h

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -28,7 +29,7 @@ public:
         Text
     };
 
-    virtual ~HexEditor() override;
+    virtual ~HexEditor() override = default;
 
     bool is_readonly() const { return m_readonly; }
     void set_readonly(bool);

Userland/Applications/HexEditor/HexEditorWidget.cpp

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -202,10 +203,6 @@ HexEditorWidget::HexEditorWidget()
     m_editor->set_focus(true);
 }
 
-HexEditorWidget::~HexEditorWidget()
-{
-}
-
 void HexEditorWidget::initialize_menubar(GUI::Window& window)
 {
     auto& file_menu = window.add_menu("&File");

Userland/Applications/HexEditor/HexEditorWidget.h

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -21,7 +22,7 @@ class HexEditor;
 class HexEditorWidget final : public GUI::Widget {
     C_OBJECT(HexEditorWidget)
 public:
-    virtual ~HexEditorWidget() override;
+    virtual ~HexEditorWidget() override = default;
     void open_file(NonnullRefPtr<Core::File>);
     void initialize_menubar(GUI::Window&);
     bool request_close();

Userland/Applications/ImageViewer/ViewWidget.cpp

@@ -3,6 +3,7 @@
  * Copyright (c) 2021, Linus Groh <linusg@serenityos.org>
  * Copyright (c) 2021, Mohsan Ali <mohsan0073@gmail.com>
  * Copyright (c) 2022, Mustafa Quraish <mustafa@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -28,10 +29,6 @@ ViewWidget::ViewWidget()
     set_fill_with_background_color(false);
 }
 
-ViewWidget::~ViewWidget()
-{
-}
-
 void ViewWidget::clear()
 {
     m_timer->stop();

Userland/Applications/ImageViewer/ViewWidget.h

@@ -3,6 +3,7 @@
  * Copyright (c) 2021, Linus Groh <linusg@serenityos.org>
  * Copyright (c) 2021, Mohsan Ali <mohsan0073@gmail.com>
  * Copyright (c) 2022, Mustafa Quraish <mustafa@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -26,7 +27,7 @@ public:
         Last
     };
 
-    virtual ~ViewWidget() override;
+    virtual ~ViewWidget() override = default;
 
     const Gfx::Bitmap* bitmap() const { return m_bitmap.ptr(); }
     const String& path() const { return m_path; }

Userland/Applications/KeyboardMapper/KeyButton.cpp

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2020, Hüseyin Aslıtürk <asliturk@hotmail.com>
  * Copyright (c) 2021, Rasmus Nylander <RasmusNylander.SerenityOS@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -11,10 +12,6 @@
 #include <LibGfx/Font.h>
 #include <LibGfx/Palette.h>
 
-KeyButton::~KeyButton()
-{
-}
-
 void KeyButton::paint_event(GUI::PaintEvent& event)
 {
     GUI::Painter painter(*this);

Userland/Applications/KeyboardMapper/KeyButton.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020, Hüseyin Aslıtürk <asliturk@hotmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -12,7 +13,7 @@ class KeyButton final : public GUI::AbstractButton {
     C_OBJECT(KeyButton)
 
 public:
-    virtual ~KeyButton() override;
+    virtual ~KeyButton() override = default;
 
     void set_pressed(bool value) { m_pressed = value; }
 

Userland/Applications/KeyboardMapper/KeyboardMapperWidget.cpp

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2020, Hüseyin Aslıtürk <asliturk@hotmail.com>
  * Copyright (c) 2021, Rasmus Nylander <RasmusNylander.SerenityOS@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -20,10 +21,6 @@ KeyboardMapperWidget::KeyboardMapperWidget()
     create_frame();
 }
 
-KeyboardMapperWidget::~KeyboardMapperWidget()
-{
-}
-
 void KeyboardMapperWidget::create_frame()
 {
     set_fill_with_background_color(true);

Userland/Applications/KeyboardMapper/KeyboardMapperWidget.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020, Hüseyin Aslıtürk <asliturk@hotmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -14,7 +15,7 @@ class KeyboardMapperWidget final : public GUI::Widget {
     C_OBJECT(KeyboardMapperWidget)
 
 public:
-    virtual ~KeyboardMapperWidget() override;
+    virtual ~KeyboardMapperWidget() override = default;
 
     void create_frame();
     ErrorOr<void> load_map_from_file(const String&);

Userland/Applications/KeyboardSettings/KeyboardSettingsWidget.cpp

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2020, Hüseyin Aslıtürk <asliturk@hotmail.com>
  * Copyright (c) 2021, Sam Atkins <atkinssj@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -28,7 +29,7 @@
 class KeymapSelectionDialog final : public GUI::Dialog {
     C_OBJECT(KeymapSelectionDialog)
 public:
-    virtual ~KeymapSelectionDialog() override {};
+    virtual ~KeymapSelectionDialog() override = default;
 
     static String select_keymap(Window* parent_window, Vector<String> const& selected_keymaps)
     {

Userland/Applications/Magnifier/MagnifierWidget.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2021, Valtteri Koskivuori <vkoskiv@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -16,10 +17,6 @@ MagnifierWidget::MagnifierWidget()
     GUI::DisplayLink::register_callback([this](auto) { sync(); });
 }
 
-MagnifierWidget::~MagnifierWidget()
-{
-}
-
 void MagnifierWidget::set_scale_factor(int scale_factor)
 {
     VERIFY(scale_factor == 2 || scale_factor == 4 || scale_factor == 8);

Userland/Applications/Magnifier/MagnifierWidget.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2021, Valtteri Koskivuori <vkoskiv@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -14,7 +15,7 @@ class MagnifierWidget final : public GUI::Frame {
     C_OBJECT(MagnifierWidget);
 
 public:
-    virtual ~MagnifierWidget();
+    virtual ~MagnifierWidget() override = default;
     void set_scale_factor(int scale_factor);
     void set_color_filter(OwnPtr<Gfx::ColorBlindnessFilter>);
     void pause_capture(bool pause)

Userland/Applications/Mail/AccountHolder.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2021, Luke Wilde <lukew@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -11,10 +12,6 @@ AccountHolder::AccountHolder()
     m_mailbox_tree_model = MailboxTreeModel::create(*this);
 }
 
-AccountHolder::~AccountHolder()
-{
-}
-
 void AccountHolder::add_account_with_name_and_mailboxes(String name, Vector<IMAP::ListItem> const& mailboxes)
 {
     auto account = AccountNode::create(move(name));

Userland/Applications/Mail/AccountHolder.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2021, Luke Wilde <lukew@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -86,7 +87,7 @@ private:
 
 class AccountHolder {
 public:
-    ~AccountHolder();
+    ~AccountHolder() = default;
 
     static NonnullOwnPtr<AccountHolder> create()
     {

Userland/Applications/Mail/InboxModel.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2021, Luke Wilde <lukew@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -11,10 +12,6 @@ InboxModel::InboxModel(Vector<InboxEntry> entries)
 {
 }
 
-InboxModel::~InboxModel()
-{
-}
-
 int InboxModel::row_count(GUI::ModelIndex const&) const
 {
     return m_entries.size();

Userland/Applications/Mail/InboxModel.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2021, Luke Wilde <lukew@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -27,7 +28,7 @@ public:
         return adopt_ref(*new InboxModel(move(inbox_entries)));
     }
 
-    virtual ~InboxModel() override;
+    virtual ~InboxModel() override = default;
 
     virtual int row_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override;
     virtual int column_count(const GUI::ModelIndex& = GUI::ModelIndex()) const override { return Column::__Count; }

Userland/Applications/Mail/MailWidget.cpp

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2021, Luke Wilde <lukew@serenityos.org>
  * Copyright (c) 2021, Undefine <cqundefine@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -95,10 +96,6 @@ MailWidget::MailWidget()
     };
 }
 
-MailWidget::~MailWidget()
-{
-}
-
 bool MailWidget::connect_and_login()
 {
     auto server = Config::read_string("Mail", "Connection", "Server", {});

Userland/Applications/Mail/MailWidget.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2021, Luke Wilde <lukew@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -17,7 +18,7 @@
 class MailWidget final : public GUI::Widget {
     C_OBJECT(MailWidget)
 public:
-    virtual ~MailWidget() override;
+    virtual ~MailWidget() override = default;
 
     bool connect_and_login();
 

Userland/Applications/Mail/MailboxTreeModel.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2021, Luke Wilde <lukew@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -15,10 +16,6 @@ MailboxTreeModel::MailboxTreeModel(AccountHolder const& account_holder)
     m_account_icon.set_bitmap_for_size(16, Gfx::Bitmap::try_load_from_file("/res/icons/16x16/home-directory.png").release_value_but_fixme_should_propagate_errors());
 }
 
-MailboxTreeModel::~MailboxTreeModel()
-{
-}
-
 GUI::ModelIndex MailboxTreeModel::index(int row, int column, GUI::ModelIndex const& parent) const
 {
     if (!parent.is_valid()) {

Userland/Applications/Mail/MailboxTreeModel.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2021, Luke Wilde <lukew@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -18,7 +19,7 @@ public:
         return adopt_ref(*new MailboxTreeModel(account_holder));
     }
 
-    virtual ~MailboxTreeModel() override;
+    virtual ~MailboxTreeModel() override = default;
 
     virtual int row_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override;
     virtual int column_count(GUI::ModelIndex const& = GUI::ModelIndex()) const override;

Userland/Applications/MouseSettings/DoubleClickArrowWidget.cpp

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2021, Mathias Jakobsen <mathias@jbcoding.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -13,10 +14,6 @@ REGISTER_WIDGET(MouseSettings, DoubleClickArrowWidget);
 
 namespace MouseSettings {
 
-DoubleClickArrowWidget::~DoubleClickArrowWidget()
-{
-}
-
 void DoubleClickArrowWidget::set_double_click_speed(int speed)
 {
     if (m_double_click_speed == speed)

Userland/Applications/MouseSettings/DoubleClickArrowWidget.h

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2021, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2021, Mathias Jakobsen <mathias@jbcoding.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -16,7 +17,7 @@ class DoubleClickArrowWidget final : public GUI::Widget {
     C_OBJECT(DoubleClickArrowWidget);
 
 public:
-    virtual ~DoubleClickArrowWidget() override;
+    virtual ~DoubleClickArrowWidget() override = default;
     void set_double_click_speed(int);
 
 private:

Userland/Applications/MouseSettings/MouseWidget.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, the SerenityOS developers.
+ * Copyright (c) 2021-2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -65,7 +65,3 @@ void MouseWidget::reset_default_values()
     m_double_click_speed_slider->set_value(double_click_speed_default);
     m_switch_buttons_checkbox->set_checked(false);
 }
-
-MouseWidget::~MouseWidget()
-{
-}

Userland/Applications/MouseSettings/MouseWidget.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, the SerenityOS developers.
+ * Copyright (c) 2021-2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -14,7 +14,7 @@
 class MouseWidget final : public GUI::SettingsWindow::Tab {
     C_OBJECT(MouseWidget)
 public:
-    virtual ~MouseWidget() override;
+    virtual ~MouseWidget() override = default;
 
     virtual void apply_settings() override;
     virtual void reset_default_values() override;

Userland/Applications/MouseSettings/ThemeWidget.cpp

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, the SerenityOS developers.
+ * Copyright (c) 2021-2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -137,7 +137,3 @@ void ThemeWidget::reset_default_values()
 {
     m_theme_name_box->set_text("Default");
 }
-
-ThemeWidget::~ThemeWidget()
-{
-}

Userland/Applications/MouseSettings/ThemeWidget.h

@@ -1,5 +1,5 @@
 /*
- * Copyright (c) 2021, the SerenityOS developers.
+ * Copyright (c) 2021-2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -14,7 +14,7 @@
 class MouseCursorModel final : public GUI::Model {
 public:
     static NonnullRefPtr<MouseCursorModel> create() { return adopt_ref(*new MouseCursorModel); }
-    virtual ~MouseCursorModel() override { }
+    virtual ~MouseCursorModel() override = default;
 
     enum Column {
         Bitmap,
@@ -36,7 +36,7 @@ public:
     }
 
 private:
-    MouseCursorModel() { }
+    MouseCursorModel() = default;
 
     struct Cursor {
         RefPtr<Gfx::Bitmap> bitmap;
@@ -65,7 +65,7 @@ private:
 class ThemeWidget final : public GUI::SettingsWindow::Tab {
     C_OBJECT(ThemeWidget)
 public:
-    virtual ~ThemeWidget() override;
+    virtual ~ThemeWidget() override = default;
 
     virtual void apply_settings() override;
     virtual void reset_default_values() override;

Userland/Applications/Piano/KeysWidget.cpp

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -17,10 +18,6 @@ KeysWidget::KeysWidget(TrackManager& track_manager)
     set_fill_with_background_color(true);
 }
 
-KeysWidget::~KeysWidget()
-{
-}
-
 int KeysWidget::mouse_note() const
 {
     if (m_mouse_down && m_mouse_note + m_track_manager.octave_base() < note_count)

Userland/Applications/Piano/KeysWidget.h

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -15,7 +16,7 @@ class TrackManager;
 class KeysWidget final : public GUI::Frame {
     C_OBJECT(KeysWidget)
 public:
-    virtual ~KeysWidget() override;
+    virtual ~KeysWidget() override = default;
 
     int key_code_to_key(int key_code) const;
     int mouse_note() const;

Userland/Applications/Piano/KnobsWidget.cpp

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -103,10 +104,6 @@ KnobsWidget::KnobsWidget(TrackManager& track_manager, MainWidget& main_widget)
     }
 }
 
-KnobsWidget::~KnobsWidget()
-{
-}
-
 void KnobsWidget::cycle_waveform()
 {
     m_synth_waveform->set_selected_index((m_synth_waveform->selected_index() + 1) % m_synth_waveform->model()->row_count());

Userland/Applications/Piano/KnobsWidget.h

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -22,7 +23,7 @@ class MainWidget;
 class KnobsWidget final : public GUI::Frame {
     C_OBJECT(KnobsWidget)
 public:
-    virtual ~KnobsWidget() override;
+    virtual ~KnobsWidget() override = default;
 
     void update_knobs();
     void cycle_waveform();

Userland/Applications/Piano/MainWidget.cpp

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -52,10 +53,6 @@ MainWidget::MainWidget(TrackManager& track_manager, AudioPlayerLoop& loop)
     m_roll_widget->set_keys_widget(m_keys_widget);
 }
 
-MainWidget::~MainWidget()
-{
-}
-
 void MainWidget::add_track_actions(GUI::Menu& menu)
 {
     menu.add_action(GUI::Action::create("&Add Track", { Mod_Ctrl, Key_T }, [&](auto&) {

Userland/Applications/Piano/MainWidget.h

@@ -2,6 +2,7 @@
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
  * Copyright (c) 2021, JJ Roberts-White <computerfido@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -23,7 +24,7 @@ class PlayerWidget;
 class MainWidget final : public GUI::Widget {
     C_OBJECT(MainWidget)
 public:
-    virtual ~MainWidget() override;
+    virtual ~MainWidget() override = default;
 
     void add_track_actions(GUI::Menu&);
 

Userland/Applications/Piano/PlayerWidget.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2021, JJ Roberts-White <computerfido@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -95,10 +96,6 @@ PlayerWidget::PlayerWidget(TrackManager& manager, AudioPlayerLoop& loop)
     };
 }
 
-PlayerWidget::~PlayerWidget()
-{
-}
-
 void PlayerWidget::add_track()
 {
     m_track_manager.add_track();

Userland/Applications/Piano/PlayerWidget.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2021, JJ Roberts-White <computerfido@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -14,7 +15,7 @@ class TrackManager;
 class PlayerWidget final : public GUI::Toolbar {
     C_OBJECT(PlayerWidget)
 public:
-    virtual ~PlayerWidget() override;
+    virtual ~PlayerWidget() override = default;
 
     void add_track();
     void next_track();

Userland/Applications/Piano/RollWidget.cpp

@@ -2,6 +2,7 @@
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
  * Copyright (c) 2021, kleines Filmröllchen <filmroellchen@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -28,10 +29,6 @@ RollWidget::RollWidget(TrackManager& track_manager)
     vertical_scrollbar().set_value(roll_height / 2);
 }
 
-RollWidget::~RollWidget()
-{
-}
-
 void RollWidget::paint_event(GUI::PaintEvent& event)
 {
     m_roll_width = widget_inner_rect().width() * m_zoom_level;

Userland/Applications/Piano/RollWidget.h

@@ -2,6 +2,7 @@
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
  * Copyright (c) 2021, kleines Filmröllchen <filmroellchen@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -19,7 +20,7 @@ using LibDSP::RollNote;
 class RollWidget final : public GUI::AbstractScrollableWidget {
     C_OBJECT(RollWidget)
 public:
-    virtual ~RollWidget() override;
+    virtual ~RollWidget() override = default;
 
     const KeysWidget* keys_widget() const { return m_keys_widget; }
     void set_keys_widget(const KeysWidget* widget) { m_keys_widget = widget; }

Userland/Applications/Piano/SamplerWidget.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020, William McPherson <willmcpherson2@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -18,10 +19,6 @@ WaveEditor::WaveEditor(TrackManager& track_manager)
 {
 }
 
-WaveEditor::~WaveEditor()
-{
-}
-
 int WaveEditor::sample_to_y(double percentage) const
 {
     double portion_of_half_height = percentage * ((frame_inner_rect().height() - 1) / 2.0);
@@ -100,7 +97,3 @@ SamplerWidget::SamplerWidget(TrackManager& track_manager)
     m_wave_editor = add<WaveEditor>(m_track_manager);
     m_wave_editor->set_fixed_height(100);
 }
-
-SamplerWidget::~SamplerWidget()
-{
-}

Userland/Applications/Piano/SamplerWidget.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020, William McPherson <willmcpherson2@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -13,7 +14,7 @@ class TrackManager;
 class WaveEditor final : public GUI::Frame {
     C_OBJECT(WaveEditor)
 public:
-    virtual ~WaveEditor() override;
+    virtual ~WaveEditor() override = default;
 
 private:
     explicit WaveEditor(TrackManager&);
@@ -28,7 +29,7 @@ private:
 class SamplerWidget final : public GUI::Frame {
     C_OBJECT(SamplerWidget)
 public:
-    virtual ~SamplerWidget() override;
+    virtual ~SamplerWidget() override = default;
 
 private:
     explicit SamplerWidget(TrackManager&);

Userland/Applications/Piano/Track.cpp

@@ -2,6 +2,7 @@
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
  * Copyright (c) 2021, kleines Filmröllchen <filmroellchen@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -24,10 +25,6 @@ Track::Track(const u32& time)
     set_volume(volume_max);
 }
 
-Track::~Track()
-{
-}
-
 void Track::fill_sample(Sample& sample)
 {
     m_temporary_transport->time() = m_time;

Userland/Applications/Piano/Track.h

@@ -2,6 +2,7 @@
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
  * Copyright (c) 2021, kleines Filmröllchen <filmroellchen@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -26,7 +27,7 @@ class Track {
 
 public:
     explicit Track(const u32& time);
-    ~Track();
+    ~Track() = default;
 
     const Vector<Audio::Sample>& recorded_sample() const { return m_recorded_sample; }
     const SinglyLinkedList<RollNote>& roll_notes(int note) const { return m_roll_notes[note]; }

Userland/Applications/Piano/TrackManager.cpp

@@ -2,6 +2,7 @@
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
  * Copyright (c) 2021, JJ Roberts-White <computerfido@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -14,10 +15,6 @@ TrackManager::TrackManager()
     add_track();
 }
 
-TrackManager::~TrackManager()
-{
-}
-
 void TrackManager::time_forward(int amount)
 {
     int new_value = (static_cast<int>(m_time) + amount) % roll_length;

Userland/Applications/Piano/TrackManager.h

@@ -2,6 +2,7 @@
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
  * Copyright (c) 2021, JJ Roberts-White <computerfido@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -21,7 +22,7 @@ class TrackManager {
 
 public:
     TrackManager();
-    ~TrackManager();
+    ~TrackManager() = default;
 
     Track& current_track() { return *m_tracks[m_current_track]; }
     Span<const Sample> buffer() const { return m_current_front_buffer; }

Userland/Applications/Piano/WaveWidget.cpp

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -15,10 +16,6 @@ WaveWidget::WaveWidget(TrackManager& track_manager)
 {
 }
 
-WaveWidget::~WaveWidget()
-{
-}
-
 int WaveWidget::sample_to_y(int sample) const
 {
     constexpr int nice_scale_factor = 4;

Userland/Applications/Piano/WaveWidget.h

@@ -1,6 +1,7 @@
 /*
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2019-2020, William McPherson <willmcpherson2@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -14,7 +15,7 @@ class TrackManager;
 class WaveWidget final : public GUI::Frame {
     C_OBJECT(WaveWidget)
 public:
-    virtual ~WaveWidget() override;
+    virtual ~WaveWidget() override = default;
 
 private:
     explicit WaveWidget(TrackManager&);

Userland/Applications/PixelPaint/Layer.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020-2021, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -29,7 +30,7 @@ public:
     static ErrorOr<NonnullRefPtr<Layer>> try_create_with_bitmap(Image&, NonnullRefPtr<Gfx::Bitmap>, String name);
     static ErrorOr<NonnullRefPtr<Layer>> try_create_snapshot(Image&, Layer const&);
 
-    ~Layer() { }
+    ~Layer() = default;
 
     Gfx::IntPoint const& location() const { return m_location; }
     void set_location(Gfx::IntPoint const& location) { m_location = location; }

Userland/Applications/PixelPaint/LayerPropertiesWidget.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -65,10 +66,6 @@ LayerPropertiesWidget::LayerPropertiesWidget()
     };
 }
 
-LayerPropertiesWidget::~LayerPropertiesWidget()
-{
-}
-
 void LayerPropertiesWidget::set_layer(Layer* layer)
 {
     if (m_layer == layer)

Userland/Applications/PixelPaint/LayerPropertiesWidget.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020, Andreas Kling <kling@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -16,7 +17,7 @@ class LayerPropertiesWidget final : public GUI::Widget {
     C_OBJECT(LayerPropertiesWidget);
 
 public:
-    virtual ~LayerPropertiesWidget() override;
+    virtual ~LayerPropertiesWidget() override = default;
 
     void set_layer(Layer*);
 

Userland/Applications/PixelPaint/PaletteWidget.cpp

@@ -2,6 +2,7 @@
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2021, Felix Rauch <noreply@felixrau.ch>
  * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -25,9 +26,7 @@ class ColorWidget : public GUI::Frame {
     C_OBJECT(ColorWidget);
 
 public:
-    virtual ~ColorWidget() override
-    {
-    }
+    virtual ~ColorWidget() override = default;
 
     virtual Color color() { return m_color; }
 
@@ -66,7 +65,7 @@ class SelectedColorWidget : public GUI::Frame {
     C_OBJECT(SelectedColorWidget);
 
 public:
-    virtual ~SelectedColorWidget() override { }
+    virtual ~SelectedColorWidget() override = default;
 
     virtual void mousedown_event(GUI::MouseEvent& event) override
     {
@@ -162,10 +161,6 @@ void PaletteWidget::set_image_editor(ImageEditor* editor)
     };
 }
 
-PaletteWidget::~PaletteWidget()
-{
-}
-
 void PaletteWidget::set_primary_color(Color color)
 {
     if (m_editor)

Userland/Applications/PixelPaint/PaletteWidget.h

@@ -2,6 +2,7 @@
  * Copyright (c) 2018-2020, Andreas Kling <kling@serenityos.org>
  * Copyright (c) 2021, Felix Rauch <noreply@felixrau.ch>
  * Copyright (c) 2021, Mustafa Quraish <mustafa@serenityos.org>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -21,7 +22,7 @@ class PaletteWidget final : public GUI::Frame {
     C_OBJECT(PaletteWidget);
 
 public:
-    virtual ~PaletteWidget() override;
+    virtual ~PaletteWidget() override = default;
 
     void set_primary_color(Color);
     void set_secondary_color(Color);

Userland/Applications/PixelPaint/ToolPropertiesWidget.cpp

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020, Ben Jilks <benjyjilks@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -42,9 +43,4 @@ void ToolPropertiesWidget::set_active_tool(Tool* tool)
 
     m_tool_widget_stack->set_active_widget(m_active_tool_widget);
 }
-
-ToolPropertiesWidget::~ToolPropertiesWidget()
-{
-}
-
 }

Userland/Applications/PixelPaint/ToolPropertiesWidget.h

@@ -1,5 +1,6 @@
 /*
  * Copyright (c) 2020, Ben Jilks <benjyjilks@gmail.com>
+ * Copyright (c) 2022, the SerenityOS developers.
  *
  * SPDX-License-Identifier: BSD-2-Clause
  */
@@ -19,7 +20,7 @@ class ToolPropertiesWidget final : public GUI::Widget {
     C_OBJECT(ToolPropertiesWidget);
 
 public:
-    virtual ~ToolPropertiesWidget() override;
+    virtual ~ToolPropertiesWidget() override = default;
 
     void set_active_tool(Tool*);