system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-10-07 16:40:59 +00:00
Code Issues Packages Projects Releases Wiki Activity

WebContent: Return empty JSON object if element has no box model

Browse source 
The blank string "" does not parse as JSON, and so the InspectorWidget
would fail to update the box-model information when inspecting elements
with no box, (for example, `<head>`) showing stale values instead. Now,
they show all 0s.

You could argue that InspectorWidget should be more resilient when given
invalid JSON strings, but making sure we only pass valid ones works
too.
This commit is contained in:
Sam Atkins 2022-03-10 11:29:09 +00:00 committed by Andreas Kling
parent b5ea14b884
commit 10429e1043
1 changed files with 1 additions and 1 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

2
Userland/Services/WebContent/ConnectionFromClient.cpp
View file

@ -304,7 +304,7 @@ Messages::WebContentServer::InspectDomNodeResponse ConnectionFromClient::inspect
};
auto serialize_node_box_sizing_json = [](Web::Layout::Node const* layout_node) -> String {
if (!layout_node || !layout_node->is_box()) {
return "";
return "{}";
}
auto* box = static_cast<Web::Layout::Box const*>(layout_node);
auto box_model = box->box_model();