system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-22 10:36:24 +00:00
Code Issues Actions 5 Packages Projects Releases Wiki Activity

PDFViewer: Create OutlineModel items with the correct pointer

Browse source 
This fixes a bug where we would construct a ModelIndex with a pointer to
NonnullRefPtr<OutlineItem>, instead of a pointer to the underlying
OutlineItem, which caused a crash later on when we would try to
dereference that pointer.
This commit is contained in:
Julian Offenhäuser 2023-03-22 17:51:55 +01:00 committed by Andreas Kling
parent fcd4e68959
commit 0d46c27741
1 changed files with 2 additions and 2 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

4
Userland/Applications/PDFViewer/OutlineModel.cpp
View file

@ -130,8 +130,8 @@ GUI::ModelIndex OutlineModel::parent_index(const GUI::ModelIndex& index) const
GUI::ModelIndex OutlineModel::index(int row, int column, const GUI::ModelIndex& parent) const
{
if (!parent.is_valid())
return create_index(row, column, &m_outline->children[row]);
return create_index(row, column, m_outline->children[row].ptr());
auto parent_outline_item = static_cast<PDF::OutlineItem*>(parent.internal_data());
return create_index(row, column, &parent_outline_item->children[row]);
return create_index(row, column, parent_outline_item->children[row].ptr());
}