From 0388c828be70e7c841f8fded915b6fb82765d861 Mon Sep 17 00:00:00 2001
From: Dan Klishch <danilklishch@gmail.com>
Date: Tue, 14 Nov 2023 00:17:08 -0500
Subject: [PATCH] LibGUI: Remove GUI::Variant::Variant(JsonValue const&)

Let's force callers of Variant constructor to know the type of the
object they are constructing.
---
 Userland/Libraries/LibGUI/JsonArrayModel.cpp |  2 +-
 Userland/Libraries/LibGUI/Variant.cpp        | 48 --------------------
 Userland/Libraries/LibGUI/Variant.h          |  2 -
 3 files changed, 1 insertion(+), 51 deletions(-)

diff --git a/Userland/Libraries/LibGUI/JsonArrayModel.cpp b/Userland/Libraries/LibGUI/JsonArrayModel.cpp
index 6e75988e4b..352538ca2e 100644
--- a/Userland/Libraries/LibGUI/JsonArrayModel.cpp
+++ b/Userland/Libraries/LibGUI/JsonArrayModel.cpp
@@ -137,7 +137,7 @@ Variant JsonArrayModel::data(ModelIndex const& index, ModelRole role) const
         if (!data.has_value())
             return "";
         if (data->is_number())
-            return data.value();
+            return data->serialized<StringBuilder>();
         return data->as_string();
     }
 
diff --git a/Userland/Libraries/LibGUI/Variant.cpp b/Userland/Libraries/LibGUI/Variant.cpp
index 516df7312a..ca0efc349b 100644
--- a/Userland/Libraries/LibGUI/Variant.cpp
+++ b/Userland/Libraries/LibGUI/Variant.cpp
@@ -13,54 +13,6 @@
 
 namespace GUI {
 
-Variant::Variant(JsonValue const& value)
-{
-    *this = value;
-}
-
-Variant& Variant::operator=(JsonValue const& value)
-{
-    if (value.is_null())
-        return *this;
-
-    if (value.is_i32()) {
-        set(value.as_i32());
-        return *this;
-    }
-
-    if (value.is_u32()) {
-        set(value.as_u32());
-        return *this;
-    }
-
-    if (value.is_i64()) {
-        set(value.as_i64());
-        return *this;
-    }
-
-    if (value.is_u64()) {
-        set(value.as_u64());
-        return *this;
-    }
-
-    if (value.is_double()) {
-        set(value.as_double());
-        return *this;
-    }
-
-    if (value.is_string()) {
-        set(value.as_string());
-        return *this;
-    }
-
-    if (value.is_bool()) {
-        set(Detail::Boolean { value.as_bool() });
-        return *this;
-    }
-
-    VERIFY_NOT_REACHED();
-}
-
 bool Variant::operator==(Variant const& other) const
 {
     return visit([&]<typename T>(T const& own_value) {
diff --git a/Userland/Libraries/LibGUI/Variant.h b/Userland/Libraries/LibGUI/Variant.h
index a99924bb26..5a68292944 100644
--- a/Userland/Libraries/LibGUI/Variant.h
+++ b/Userland/Libraries/LibGUI/Variant.h
@@ -29,8 +29,6 @@ public:
     using Detail::VariantUnderlyingType::Variant;
     using Detail::VariantUnderlyingType::operator=;
 
-    Variant(JsonValue const&);
-    Variant& operator=(JsonValue const&);
     Variant(bool v)
         : Variant(Detail::Boolean { v })
     {