system/serenity
system/serenity
1
0
Fork 0
mirror of https://github.com/SerenityOS/serenity synced 2024-07-22 18:46:18 +00:00
Code Issues Actions 4 Packages Projects Releases Wiki Activity
serenity/Tests/AK/TestMemory.cpp

87 lines
3.3 KiB
C++
Raw Normal View History

AK: Implement memmem() for iterator haystacks This uses the KMP algorithm to implement the search. Also replaces the slow route of the normal memmem() with KMP, which should be fairly faster (O(n + m) as opposed to O(n * m)) :^)
2020-12-05 00:59:09 +00:00
/*
AK: Add naive implementations of AK::timing_safe_compare For security critical code we need to have some way of performing constant time buffer comparisons.
2022-03-13 05:42:01 +00:00
* Copyright (c) 2020-2022, the SerenityOS developers.
AK: Implement memmem() for iterator haystacks This uses the KMP algorithm to implement the search. Also replaces the slow route of the normal memmem() with KMP, which should be fairly faster (O(n + m) as opposed to O(n * m)) :^)
2020-12-05 00:59:09 +00:00
*
Everything: Move to SPDX license identifiers in all files. SPDX License Identifiers are a more compact / standardized way of representing file license information. See: https://spdx.dev/resources/use/#identifiers This was done with the `ambr` search and replace tool. ambr --no-parent-ignore --key-from-file --rep-from-file key.txt rep.txt *
2021-04-22 08:24:48 +00:00
* SPDX-License-Identifier: BSD-2-Clause
AK: Implement memmem() for iterator haystacks This uses the KMP algorithm to implement the search. Also replaces the slow route of the normal memmem() with KMP, which should be fairly faster (O(n + m) as opposed to O(n * m)) :^)
2020-12-05 00:59:09 +00:00
*/
AK+Userland: Move AK/TestSuite.h into LibTest and rework Tests' CMake As many macros as possible are moved to Macros.h, while the macros to create a test case are moved to TestCase.h. TestCase is now the only user-facing header for creating a test case. TestSuite and its helpers have moved into a .cpp file. Instead of requiring a TEST_MAIN macro to be instantiated into the test file, a TestMain.cpp file is provided instead that will be linked against each test. This has the side effect that, if we wanted to have test cases split across multiple files, it's as simple as adding them all to the same executable. The test main should be portable to kernel mode as well, so if there's a set of tests that should be run in self-test mode in kernel space, we can accomodate that. A new serenity_test CMake function streamlines adding a new test with arguments for the test source file, subdirectory under /usr/Tests to install the test application and an optional list of libraries to link against the test application. To accomodate future test where the provided TestMain.cpp is not suitable (e.g. test-js), a CUSTOM_MAIN parameter can be passed to the function to not link against the boilerplate main function.
2021-04-25 05:53:23 +00:00
#include <LibTest/TestCase.h>
AK: Implement memmem() for iterator haystacks This uses the KMP algorithm to implement the search. Also replaces the slow route of the normal memmem() with KMP, which should be fairly faster (O(n + m) as opposed to O(n * m)) :^)
2020-12-05 00:59:09 +00:00
Everywhere: Rename {Deprecated => Byte}String This commit un-deprecates DeprecatedString, and repurposes it as a byte string. As the null state has already been removed, there are no other particularly hairy blockers in repurposing this type as a byte string (what it _really_ is). This commit is auto-generated: $ xs=$(ack -l \bDeprecatedString\b\|deprecated_string AK Userland \ Meta Ports Ladybird Tests Kernel) $ perl -pie 's/\bDeprecatedString\b/ByteString/g; s/deprecated_string/byte_string/g' $xs $ clang-format --style=file -i \ $(git diff --name-only | grep \.cpp\|\.h) $ gn format $(git ls-files '*.gn' '*.gni')
2023-12-16 14:19:34 +00:00
#include <AK/ByteString.h>
AK: Implement memmem() for iterator haystacks This uses the KMP algorithm to implement the search. Also replaces the slow route of the normal memmem() with KMP, which should be fairly faster (O(n + m) as opposed to O(n * m)) :^)
2020-12-05 00:59:09 +00:00
#include <AK/MemMem.h>
AK: Add naive implementations of AK::timing_safe_compare For security critical code we need to have some way of performing constant time buffer comparisons.
2022-03-13 05:42:01 +00:00
#include <AK/Memory.h>
AK: Implement memmem() for iterator haystacks This uses the KMP algorithm to implement the search. Also replaces the slow route of the normal memmem() with KMP, which should be fairly faster (O(n + m) as opposed to O(n * m)) :^)
2020-12-05 00:59:09 +00:00
TEST_CASE(bitap)
{
Array<u8, 8> haystack { 1, 0, 1, 2, 3, 4, 5, 0 };
Array<u8, 4> needle_0 { 2, 3, 4, 5 };
Array<u8, 4> needle_1 { 1, 2, 3, 4 };
Array<u8, 4> needle_2 { 3, 4, 5, 0 };
Array<u8, 4> needle_3 { 3, 4, 5, 6 };
auto result_0 = AK::memmem(haystack.data(), haystack.size(), needle_0.data(), needle_0.size());
auto result_1 = AK::memmem(haystack.data(), haystack.size(), needle_1.data(), needle_1.size());
auto result_2 = AK::memmem(haystack.data(), haystack.size(), needle_2.data(), needle_2.size());
auto result_3 = AK::memmem(haystack.data(), haystack.size(), needle_3.data(), needle_3.size());
EXPECT_EQ(result_0, &haystack[3]);
EXPECT_EQ(result_1, &haystack[2]);
EXPECT_EQ(result_2, &haystack[4]);
EXPECT_EQ(result_3, nullptr);
AK: Use the correct data types in bitap_bitwise() Otherwise the bit twiddling goes all wrong and breaks some boundary cases. Fixes `StringView::contains(31-chars)`.
2022-07-14 02:53:36 +00:00
auto haystack_string = "Main function must return c_int\n"sv;
auto needle_string = "Main function must return c_int"sv;
auto result = AK::Detail::bitap_bitwise(haystack_string.characters_without_null_termination(), haystack_string.length(), needle_string.characters_without_null_termination(), needle_string.length());
EXPECT_NE(result, nullptr);
AK: Implement memmem() for iterator haystacks This uses the KMP algorithm to implement the search. Also replaces the slow route of the normal memmem() with KMP, which should be fairly faster (O(n + m) as opposed to O(n * m)) :^)
2020-12-05 00:59:09 +00:00
}
TEST_CASE(kmp_one_chunk)
{
Array<u8, 8> haystack { 1, 0, 1, 2, 3, 4, 5, 0 };
Array<Array<u8, 8>, 1> haystack_arr { haystack };
Array<u8, 4> needle_0 { 2, 3, 4, 5 };
Array<u8, 4> needle_1 { 1, 2, 3, 4 };
Array<u8, 4> needle_2 { 3, 4, 5, 0 };
Array<u8, 4> needle_3 { 3, 4, 5, 6 };
auto result_0 = AK::memmem(haystack_arr.begin(), haystack_arr.end(), needle_0);
auto result_1 = AK::memmem(haystack_arr.begin(), haystack_arr.end(), needle_1);
auto result_2 = AK::memmem(haystack_arr.begin(), haystack_arr.end(), needle_2);
auto result_3 = AK::memmem(haystack_arr.begin(), haystack_arr.end(), needle_3);
EXPECT_EQ(result_0.value_or(9), 3u);
EXPECT_EQ(result_1.value_or(9), 2u);
EXPECT_EQ(result_2.value_or(9), 4u);
EXPECT(!result_3.has_value());
}
TEST_CASE(kmp_two_chunks)
{
Array<u8, 4> haystack_first_half { 1, 0, 1, 2 }, haystack_second_half { 3, 4, 5, 0 };
Array<Array<u8, 4>, 2> haystack { haystack_first_half, haystack_second_half };
Array<u8, 4> needle_0 { 2, 3, 4, 5 };
Array<u8, 4> needle_1 { 1, 2, 3, 4 };
Array<u8, 4> needle_2 { 3, 4, 5, 0 };
Array<u8, 4> needle_3 { 3, 4, 5, 6 };
auto result_0 = AK::memmem(haystack.begin(), haystack.end(), needle_0);
auto result_1 = AK::memmem(haystack.begin(), haystack.end(), needle_1);
auto result_2 = AK::memmem(haystack.begin(), haystack.end(), needle_2);
auto result_3 = AK::memmem(haystack.begin(), haystack.end(), needle_3);
EXPECT_EQ(result_0.value_or(9), 3u);
EXPECT_EQ(result_1.value_or(9), 2u);
EXPECT_EQ(result_2.value_or(9), 4u);
EXPECT(!result_3.has_value());
}
AK: Add naive implementations of AK::timing_safe_compare For security critical code we need to have some way of performing constant time buffer comparisons.
2022-03-13 05:42:01 +00:00
TEST_CASE(timing_safe_compare)
{
Everywhere: Rename {Deprecated => Byte}String This commit un-deprecates DeprecatedString, and repurposes it as a byte string. As the null state has already been removed, there are no other particularly hairy blockers in repurposing this type as a byte string (what it _really_ is). This commit is auto-generated: $ xs=$(ack -l \bDeprecatedString\b\|deprecated_string AK Userland \ Meta Ports Ladybird Tests Kernel) $ perl -pie 's/\bDeprecatedString\b/ByteString/g; s/deprecated_string/byte_string/g' $xs $ clang-format --style=file -i \ $(git diff --name-only | grep \.cpp\|\.h) $ gn format $(git ls-files '*.gn' '*.gni')
2023-12-16 14:19:34 +00:00
ByteString data_set = "abcdefghijklmnopqrstuvwxyz123456789";
AK: Add naive implementations of AK::timing_safe_compare For security critical code we need to have some way of performing constant time buffer comparisons.
2022-03-13 05:42:01 +00:00
EXPECT_EQ(true, AK::timing_safe_compare(data_set.characters(), data_set.characters(), data_set.length()));
Everywhere: Rename {Deprecated => Byte}String This commit un-deprecates DeprecatedString, and repurposes it as a byte string. As the null state has already been removed, there are no other particularly hairy blockers in repurposing this type as a byte string (what it _really_ is). This commit is auto-generated: $ xs=$(ack -l \bDeprecatedString\b\|deprecated_string AK Userland \ Meta Ports Ladybird Tests Kernel) $ perl -pie 's/\bDeprecatedString\b/ByteString/g; s/deprecated_string/byte_string/g' $xs $ clang-format --style=file -i \ $(git diff --name-only | grep \.cpp\|\.h) $ gn format $(git ls-files '*.gn' '*.gni')
2023-12-16 14:19:34 +00:00
ByteString reversed = data_set.reverse();
AK: Add naive implementations of AK::timing_safe_compare For security critical code we need to have some way of performing constant time buffer comparisons.
2022-03-13 05:42:01 +00:00
EXPECT_EQ(false, AK::timing_safe_compare(data_set.characters(), reversed.characters(), reversed.length()));
}
Reference in a new issue Copy permalink