mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 09:55:55 +00:00
![Markus Armbruster](/assets/img/avatar_default.png)
The only way object_property_add() can fail is when a property with the same name already exists. Since our property names are all hardcoded, failure is a programming error, and the appropriate way to handle it is passing &error_abort. Same for its variants, except for object_property_add_child(), which additionally fails when the child already has a parent. Parentage is also under program control, so this is a programming error, too. We have a bit over 500 callers. Almost half of them pass &error_abort, slightly fewer ignore errors, one test case handles errors, and the remaining few callers pass them to their own callers. The previous few commits demonstrated once again that ignoring programming errors is a bad idea. Of the few ones that pass on errors, several violate the Error API. The Error ** argument must be NULL, &error_abort, &error_fatal, or a pointer to a variable containing NULL. Passing an argument of the latter kind twice without clearing it in between is wrong: if the first call sets an error, it no longer points to NULL for the second call. ich9_pm_add_properties(), sparc32_ledma_realize(), sparc32_dma_realize(), xilinx_axidma_realize(), xilinx_enet_realize() are wrong that way. When the one appropriate choice of argument is &error_abort, letting users pick the argument is a bad idea. Drop parameter @errp and assert the preconditions instead. There's one exception to "duplicate property name is a programming error": the way object_property_add() implements the magic (and undocumented) "automatic arrayification". Don't drop @errp there. Instead, rename object_property_add() to object_property_try_add(), and add the obvious wrapper object_property_add(). Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Reviewed-by: Paolo Bonzini <pbonzini@redhat.com> Message-Id: <20200505152926.18877-15-armbru@redhat.com> [Two semantic rebase conflicts resolved]
139 lines
3.9 KiB
C
139 lines
3.9 KiB
C
/*
|
|
* QEMU IPMI emulation
|
|
*
|
|
* Copyright (c) 2015 Corey Minyard, MontaVista Software, LLC
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "hw/ipmi/ipmi.h"
|
|
#include "hw/qdev-properties.h"
|
|
#include "qom/object_interfaces.h"
|
|
#include "sysemu/runstate.h"
|
|
#include "qapi/error.h"
|
|
#include "qemu/module.h"
|
|
#include "hw/nmi.h"
|
|
|
|
static uint32_t ipmi_current_uuid = 1;
|
|
|
|
uint32_t ipmi_next_uuid(void)
|
|
{
|
|
return ipmi_current_uuid++;
|
|
}
|
|
|
|
static int ipmi_do_hw_op(IPMIInterface *s, enum ipmi_op op, int checkonly)
|
|
{
|
|
switch (op) {
|
|
case IPMI_RESET_CHASSIS:
|
|
if (checkonly) {
|
|
return 0;
|
|
}
|
|
qemu_system_reset_request(SHUTDOWN_CAUSE_GUEST_RESET);
|
|
return 0;
|
|
|
|
case IPMI_POWEROFF_CHASSIS:
|
|
if (checkonly) {
|
|
return 0;
|
|
}
|
|
qemu_system_shutdown_request(SHUTDOWN_CAUSE_GUEST_SHUTDOWN);
|
|
return 0;
|
|
|
|
case IPMI_SEND_NMI:
|
|
if (checkonly) {
|
|
return 0;
|
|
}
|
|
/* We don't care what CPU we use. */
|
|
nmi_monitor_handle(0, NULL);
|
|
return 0;
|
|
|
|
case IPMI_SHUTDOWN_VIA_ACPI_OVERTEMP:
|
|
if (checkonly) {
|
|
return 0;
|
|
}
|
|
qemu_system_powerdown_request();
|
|
return 0;
|
|
|
|
case IPMI_POWERCYCLE_CHASSIS:
|
|
case IPMI_PULSE_DIAG_IRQ:
|
|
case IPMI_POWERON_CHASSIS:
|
|
default:
|
|
return IPMI_CC_COMMAND_NOT_SUPPORTED;
|
|
}
|
|
}
|
|
|
|
static void ipmi_interface_class_init(ObjectClass *class, void *data)
|
|
{
|
|
IPMIInterfaceClass *ik = IPMI_INTERFACE_CLASS(class);
|
|
|
|
ik->do_hw_op = ipmi_do_hw_op;
|
|
}
|
|
|
|
static TypeInfo ipmi_interface_type_info = {
|
|
.name = TYPE_IPMI_INTERFACE,
|
|
.parent = TYPE_INTERFACE,
|
|
.class_size = sizeof(IPMIInterfaceClass),
|
|
.class_init = ipmi_interface_class_init,
|
|
};
|
|
|
|
static void isa_ipmi_bmc_check(const Object *obj, const char *name,
|
|
Object *val, Error **errp)
|
|
{
|
|
IPMIBmc *bmc = IPMI_BMC(val);
|
|
|
|
if (bmc->intf)
|
|
error_setg(errp, "BMC object is already in use");
|
|
}
|
|
|
|
void ipmi_bmc_find_and_link(Object *obj, Object **bmc)
|
|
{
|
|
object_property_add_link(obj, "bmc", TYPE_IPMI_BMC, bmc,
|
|
isa_ipmi_bmc_check,
|
|
OBJ_PROP_LINK_STRONG);
|
|
}
|
|
|
|
static Property ipmi_bmc_properties[] = {
|
|
DEFINE_PROP_UINT8("slave_addr", IPMIBmc, slave_addr, 0x20),
|
|
DEFINE_PROP_END_OF_LIST(),
|
|
};
|
|
|
|
static void bmc_class_init(ObjectClass *oc, void *data)
|
|
{
|
|
DeviceClass *dc = DEVICE_CLASS(oc);
|
|
|
|
device_class_set_props(dc, ipmi_bmc_properties);
|
|
}
|
|
|
|
static TypeInfo ipmi_bmc_type_info = {
|
|
.name = TYPE_IPMI_BMC,
|
|
.parent = TYPE_DEVICE,
|
|
.instance_size = sizeof(IPMIBmc),
|
|
.abstract = true,
|
|
.class_size = sizeof(IPMIBmcClass),
|
|
.class_init = bmc_class_init,
|
|
};
|
|
|
|
static void ipmi_register_types(void)
|
|
{
|
|
type_register_static(&ipmi_interface_type_info);
|
|
type_register_static(&ipmi_bmc_type_info);
|
|
}
|
|
|
|
type_init(ipmi_register_types)
|