Zide Chen 05fc711c3a target/i386: Advertise MWAIT iff host supports ... host_cpu_realizefn() sets CPUID_EXT_MONITOR without consulting host/KVM capabilities. This may cause problems: - If MWAIT/MONITOR is not available on the host, advertising this feature to the guest and executing MWAIT/MONITOR from the guest triggers #UD and the guest doesn't boot. This is because typically #UD takes priority over VM-Exit interception checks and KVM doesn't emulate MONITOR/MWAIT on #UD. - If KVM doesn't support KVM_X86_DISABLE_EXITS_MWAIT, MWAIT/MONITOR from the guest are intercepted by KVM, which is not what cpu-pm=on intends to do. In these cases, MWAIT/MONITOR should not be exposed to the guest. The logic in kvm_arch_get_supported_cpuid() to handle CPUID_EXT_MONITOR is correct and sufficient, and we can't set CPUID_EXT_MONITOR after x86_cpu_filter_features(). This was not an issue before commit 662175b91f ("i386: reorder call to cpu_exec_realizefn") because the feature added in the accel-specific realizefn could be checked against host availability and filtered out. Additionally, it seems not a good idea to handle guest CPUID leaves in host_cpu_realizefn(), and this patch merges host_cpu_enable_cpu_pm() into kvm_cpu_realizefn(). Fixes: f5cc5a5c16 ("i386: split cpu accelerators from cpu.c, using AccelCPUClass") Fixes: 662175b91f ("i386: reorder call to cpu_exec_realizefn") Signed-off-by: Zide Chen <zide.chen@intel.com> Reviewed-by: Zhao Liu <zhao1.liu@intel.com> Reviewed-by: Xiaoyao Li <xiaoyao.li@intel.com> Reviewed-by: Igor Mammedov <imammedo@redhat.com> Reviewed-by: Michael Tokarev <mjt@tls.msk.ru> Signed-off-by: Michael Tokarev <mjt@tls.msk.ru>		2024-06-30 19:51:44 +03:00
..
alpha
arm	gdbstub: move enums into separate header	2024-06-24 10:14:17 +01:00
avr
cris
hexagon	target/hexagon: idef-parser simplify predicate init	2024-06-08 17:49:36 -07:00
hppa	target/hppa:	2024-05-15 11:46:58 +02:00
i386	target/i386: Advertise MWAIT iff host supports	2024-06-30 19:51:44 +03:00
loongarch	target/loongarch: fix a wrong print in cpu dump	2024-06-06 11:58:06 +08:00
m68k
microblaze
mips	target/mips: Remove unused 'hw/misc/mips_itu.h' header	2024-06-04 10:02:39 +02:00
openrisc
ppc	gdbstub: move enums into separate header	2024-06-24 10:14:17 +01:00
riscv	target/riscv: Apply modularized matching conditions for icount trigger	2024-06-27 13:09:16 +10:00
rx
s390x	maintainer updates (plugins, gdbstub):	2024-06-24 13:51:11 -07:00
sh4
sparc	target/sparc: use signed denominator in sdiv helper	2024-06-19 13:50:22 -07:00
tricore
xtensa
Kconfig
meson.build