qemu/hw/audio
Manos Pitsidianakis 731655f87f virtio-snd: rewrite invalid tx/rx message handling
The current handling of invalid virtqueue elements inside the TX/RX virt
queue handlers is wrong.

They are added in a per-stream invalid queue to be processed after the
handler is done examining each message, but the invalid message might
not be specifying any stream_id; which means it's invalid to add it to
any stream->invalid queue since stream could be NULL at this point.

This commit moves the invalid queue to the VirtIOSound struct which
guarantees there will always be a valid temporary place to store them
inside the tx/rx handlers. The queue will be emptied before the handler
returns, so the queue must be empty at any other point of the device's
lifetime.

Signed-off-by: Manos Pitsidianakis <manos.pitsidianakis@linaro.org>
Message-Id: <virtio-snd-rewrite-invalid-tx-rx-message-handling-v1.manos.pitsidianakis@linaro.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
2024-04-09 02:31:16 -04:00
..
ac97.c
ac97.h
adlib.c
asc.c
cs4231.c
cs4231a.c
es1370.c
fmopl.c
fmopl.h
gus.c
gusemu.h
gusemu_hal.c
gusemu_mixer.c
gustate.h
hda-codec-common.h
hda-codec.c
intel-hda-defs.h
intel-hda.c
intel-hda.h
Kconfig
lm4549.c
lm4549.h
marvell_88w8618.c
meson.build
pcspk.c
pl041.c
pl041.h
pl041.hx
sb16.c
soundhw.c
trace-events
trace.h
via-ac97.c
virtio-snd-pci.c
virtio-snd.c virtio-snd: rewrite invalid tx/rx message handling 2024-04-09 02:31:16 -04:00
wm8750.c