mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-11-05 20:35:44 +00:00
015715f554
When you build QMP input manually like this cmd = g_strdup_printf("{ 'execute': 'migrate'," "'arguments': { 'uri': '%s' } }", uri); rsp = qmp(cmd); g_free(cmd); you're responsible for escaping the interpolated values for JSON. Not done here, and therefore works only for sufficiently nice @uri. For instance, if @uri contained a single "'", qobject_from_vjsonf_nofail() would abort. A sufficiently nasty @uri could even inject unwanted members into the arguments object. Leaving interpolation into JSON to qmp() is more robust: rsp = qmp("{ 'execute': 'migrate', 'arguments': { 'uri': %s } }", uri); It's also more concise. Clean up the simple cases where we interpolate exactly a JSON value. Bonus: gets rid of non-literal format strings. A step towards compile-time format string checking without triggering -Wformat-nonliteral. Signed-off-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org> Reviewed-by: Eric Blake <eblake@redhat.com> Message-Id: <20180806065344.7103-13-armbru@redhat.com>
173 lines
4.1 KiB
C
173 lines
4.1 KiB
C
/*
|
|
* libqos PCI bindings for PC
|
|
*
|
|
* Copyright IBM, Corp. 2012-2013
|
|
*
|
|
* Authors:
|
|
* Anthony Liguori <aliguori@us.ibm.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "libqtest.h"
|
|
#include "libqos/pci-pc.h"
|
|
#include "qapi/qmp/qdict.h"
|
|
#include "hw/pci/pci_regs.h"
|
|
|
|
#include "qemu-common.h"
|
|
|
|
|
|
#define ACPI_PCIHP_ADDR 0xae00
|
|
#define PCI_EJ_BASE 0x0008
|
|
|
|
typedef struct QPCIBusPC
|
|
{
|
|
QPCIBus bus;
|
|
} QPCIBusPC;
|
|
|
|
static uint8_t qpci_pc_pio_readb(QPCIBus *bus, uint32_t addr)
|
|
{
|
|
return inb(addr);
|
|
}
|
|
|
|
static void qpci_pc_pio_writeb(QPCIBus *bus, uint32_t addr, uint8_t val)
|
|
{
|
|
outb(addr, val);
|
|
}
|
|
|
|
static uint16_t qpci_pc_pio_readw(QPCIBus *bus, uint32_t addr)
|
|
{
|
|
return inw(addr);
|
|
}
|
|
|
|
static void qpci_pc_pio_writew(QPCIBus *bus, uint32_t addr, uint16_t val)
|
|
{
|
|
outw(addr, val);
|
|
}
|
|
|
|
static uint32_t qpci_pc_pio_readl(QPCIBus *bus, uint32_t addr)
|
|
{
|
|
return inl(addr);
|
|
}
|
|
|
|
static void qpci_pc_pio_writel(QPCIBus *bus, uint32_t addr, uint32_t val)
|
|
{
|
|
outl(addr, val);
|
|
}
|
|
|
|
static uint64_t qpci_pc_pio_readq(QPCIBus *bus, uint32_t addr)
|
|
{
|
|
return (uint64_t)inl(addr) + ((uint64_t)inl(addr + 4) << 32);
|
|
}
|
|
|
|
static void qpci_pc_pio_writeq(QPCIBus *bus, uint32_t addr, uint64_t val)
|
|
{
|
|
outl(addr, val & 0xffffffff);
|
|
outl(addr + 4, val >> 32);
|
|
}
|
|
|
|
static void qpci_pc_memread(QPCIBus *bus, uint32_t addr, void *buf, size_t len)
|
|
{
|
|
memread(addr, buf, len);
|
|
}
|
|
|
|
static void qpci_pc_memwrite(QPCIBus *bus, uint32_t addr,
|
|
const void *buf, size_t len)
|
|
{
|
|
memwrite(addr, buf, len);
|
|
}
|
|
|
|
static uint8_t qpci_pc_config_readb(QPCIBus *bus, int devfn, uint8_t offset)
|
|
{
|
|
outl(0xcf8, (1U << 31) | (devfn << 8) | offset);
|
|
return inb(0xcfc);
|
|
}
|
|
|
|
static uint16_t qpci_pc_config_readw(QPCIBus *bus, int devfn, uint8_t offset)
|
|
{
|
|
outl(0xcf8, (1U << 31) | (devfn << 8) | offset);
|
|
return inw(0xcfc);
|
|
}
|
|
|
|
static uint32_t qpci_pc_config_readl(QPCIBus *bus, int devfn, uint8_t offset)
|
|
{
|
|
outl(0xcf8, (1U << 31) | (devfn << 8) | offset);
|
|
return inl(0xcfc);
|
|
}
|
|
|
|
static void qpci_pc_config_writeb(QPCIBus *bus, int devfn, uint8_t offset, uint8_t value)
|
|
{
|
|
outl(0xcf8, (1U << 31) | (devfn << 8) | offset);
|
|
outb(0xcfc, value);
|
|
}
|
|
|
|
static void qpci_pc_config_writew(QPCIBus *bus, int devfn, uint8_t offset, uint16_t value)
|
|
{
|
|
outl(0xcf8, (1U << 31) | (devfn << 8) | offset);
|
|
outw(0xcfc, value);
|
|
}
|
|
|
|
static void qpci_pc_config_writel(QPCIBus *bus, int devfn, uint8_t offset, uint32_t value)
|
|
{
|
|
outl(0xcf8, (1U << 31) | (devfn << 8) | offset);
|
|
outl(0xcfc, value);
|
|
}
|
|
|
|
QPCIBus *qpci_init_pc(QTestState *qts, QGuestAllocator *alloc)
|
|
{
|
|
QPCIBusPC *ret = g_new0(QPCIBusPC, 1);
|
|
|
|
assert(qts);
|
|
|
|
ret->bus.pio_readb = qpci_pc_pio_readb;
|
|
ret->bus.pio_readw = qpci_pc_pio_readw;
|
|
ret->bus.pio_readl = qpci_pc_pio_readl;
|
|
ret->bus.pio_readq = qpci_pc_pio_readq;
|
|
|
|
ret->bus.pio_writeb = qpci_pc_pio_writeb;
|
|
ret->bus.pio_writew = qpci_pc_pio_writew;
|
|
ret->bus.pio_writel = qpci_pc_pio_writel;
|
|
ret->bus.pio_writeq = qpci_pc_pio_writeq;
|
|
|
|
ret->bus.memread = qpci_pc_memread;
|
|
ret->bus.memwrite = qpci_pc_memwrite;
|
|
|
|
ret->bus.config_readb = qpci_pc_config_readb;
|
|
ret->bus.config_readw = qpci_pc_config_readw;
|
|
ret->bus.config_readl = qpci_pc_config_readl;
|
|
|
|
ret->bus.config_writeb = qpci_pc_config_writeb;
|
|
ret->bus.config_writew = qpci_pc_config_writew;
|
|
ret->bus.config_writel = qpci_pc_config_writel;
|
|
|
|
ret->bus.qts = qts;
|
|
ret->bus.pio_alloc_ptr = 0xc000;
|
|
ret->bus.mmio_alloc_ptr = 0xE0000000;
|
|
ret->bus.mmio_limit = 0x100000000ULL;
|
|
|
|
return &ret->bus;
|
|
}
|
|
|
|
void qpci_free_pc(QPCIBus *bus)
|
|
{
|
|
QPCIBusPC *s = container_of(bus, QPCIBusPC, bus);
|
|
|
|
g_free(s);
|
|
}
|
|
|
|
void qpci_unplug_acpi_device_test(const char *id, uint8_t slot)
|
|
{
|
|
QDict *response;
|
|
|
|
response = qmp("{'execute': 'device_del', 'arguments': {'id': %s}}",
|
|
id);
|
|
g_assert(response);
|
|
g_assert(!qdict_haskey(response, "error"));
|
|
qobject_unref(response);
|
|
|
|
outb(ACPI_PCIHP_ADDR + PCI_EJ_BASE, 1 << slot);
|
|
|
|
qmp_eventwait("DEVICE_DELETED");
|
|
}
|