mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-11-05 20:35:44 +00:00
d99598cc99
Coverity defects 1005733 & 1005734 complain about passing a negative value to closesocket in the error paths on incoming migration. Stash the error value and print it in the message (previously we gave no indication of the reason for the failure) Use error_report Signed-off-by: Dr. David Alan Gilbert <dgilbert@redhat.com> Reviewed-by: Markus Armbruster <armbru@redhat.com> Signed-off-by: Juan Quintela <quintela@redhat.com>
103 lines
2.4 KiB
C
103 lines
2.4 KiB
C
/*
|
|
* QEMU live migration
|
|
*
|
|
* Copyright IBM, Corp. 2008
|
|
*
|
|
* Authors:
|
|
* Anthony Liguori <aliguori@us.ibm.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2. See
|
|
* the COPYING file in the top-level directory.
|
|
*
|
|
* Contributions after 2012-01-13 are licensed under the terms of the
|
|
* GNU GPL, version 2 or (at your option) any later version.
|
|
*/
|
|
|
|
#include <string.h>
|
|
|
|
#include "qemu-common.h"
|
|
#include "qemu/error-report.h"
|
|
#include "qemu/sockets.h"
|
|
#include "migration/migration.h"
|
|
#include "migration/qemu-file.h"
|
|
#include "block/block.h"
|
|
#include "qemu/main-loop.h"
|
|
|
|
//#define DEBUG_MIGRATION_TCP
|
|
|
|
#ifdef DEBUG_MIGRATION_TCP
|
|
#define DPRINTF(fmt, ...) \
|
|
do { printf("migration-tcp: " fmt, ## __VA_ARGS__); } while (0)
|
|
#else
|
|
#define DPRINTF(fmt, ...) \
|
|
do { } while (0)
|
|
#endif
|
|
|
|
static void tcp_wait_for_connect(int fd, void *opaque)
|
|
{
|
|
MigrationState *s = opaque;
|
|
|
|
if (fd < 0) {
|
|
DPRINTF("migrate connect error\n");
|
|
s->file = NULL;
|
|
migrate_fd_error(s);
|
|
} else {
|
|
DPRINTF("migrate connect success\n");
|
|
s->file = qemu_fopen_socket(fd, "wb");
|
|
migrate_fd_connect(s);
|
|
}
|
|
}
|
|
|
|
void tcp_start_outgoing_migration(MigrationState *s, const char *host_port, Error **errp)
|
|
{
|
|
inet_nonblocking_connect(host_port, tcp_wait_for_connect, s, errp);
|
|
}
|
|
|
|
static void tcp_accept_incoming_migration(void *opaque)
|
|
{
|
|
struct sockaddr_in addr;
|
|
socklen_t addrlen = sizeof(addr);
|
|
int s = (intptr_t)opaque;
|
|
QEMUFile *f;
|
|
int c, err;
|
|
|
|
do {
|
|
c = qemu_accept(s, (struct sockaddr *)&addr, &addrlen);
|
|
err = socket_error();
|
|
} while (c < 0 && err == EINTR);
|
|
qemu_set_fd_handler2(s, NULL, NULL, NULL, NULL);
|
|
closesocket(s);
|
|
|
|
DPRINTF("accepted migration\n");
|
|
|
|
if (c < 0) {
|
|
error_report("could not accept migration connection (%s)",
|
|
strerror(err));
|
|
return;
|
|
}
|
|
|
|
f = qemu_fopen_socket(c, "rb");
|
|
if (f == NULL) {
|
|
error_report("could not qemu_fopen socket");
|
|
goto out;
|
|
}
|
|
|
|
process_incoming_migration(f);
|
|
return;
|
|
|
|
out:
|
|
closesocket(c);
|
|
}
|
|
|
|
void tcp_start_incoming_migration(const char *host_port, Error **errp)
|
|
{
|
|
int s;
|
|
|
|
s = inet_listen(host_port, NULL, 256, SOCK_STREAM, 0, errp);
|
|
if (s < 0) {
|
|
return;
|
|
}
|
|
|
|
qemu_set_fd_handler2(s, NULL, tcp_accept_incoming_migration, NULL,
|
|
(void *)(intptr_t)s);
|
|
}
|