mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-20 03:01:32 +00:00
9e57b81861
Unlike pam_update() which takes the subject -- PAMMemoryRegion -- as first argument, init_pam() takes it as fifth (!) argument. This makes it quite hard to figure out what an init_pam() invocation actually initializes. By moving the subject to the front this should become clearer. While at it, lower the DeviceState parameter to Object, also communicating more clearly that this parameter is just the owner rather than some (heavy?) dependency. Signed-off-by: Bernhard Beschow <shentey@gmail.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Message-Id: <20230213162004.2797-8-shentey@gmail.com> Reviewed-by: Michael S. Tsirkin <mst@redhat.com> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
71 lines
2.8 KiB
C
71 lines
2.8 KiB
C
/*
|
|
* QEMU Smram/pam logic implementation
|
|
*
|
|
* Copyright (c) 2006 Fabrice Bellard
|
|
* Copyright (c) 2011 Isaku Yamahata <yamahata at valinux co jp>
|
|
* VA Linux Systems Japan K.K.
|
|
* Copyright (c) 2012 Jason Baron <jbaron@redhat.com>
|
|
*
|
|
* Split out from piix.c
|
|
*
|
|
* Permission is hereby granted, free of charge, to any person obtaining a copy
|
|
* of this software and associated documentation files (the "Software"), to deal
|
|
* in the Software without restriction, including without limitation the rights
|
|
* to use, copy, modify, merge, publish, distribute, sublicense, and/or sell
|
|
* copies of the Software, and to permit persons to whom the Software is
|
|
* furnished to do so, subject to the following conditions:
|
|
*
|
|
* The above copyright notice and this permission notice shall be included in
|
|
* all copies or substantial portions of the Software.
|
|
*
|
|
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
|
|
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY,
|
|
* FITNESS FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL
|
|
* THE AUTHORS OR COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER
|
|
* LIABILITY, WHETHER IN AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM,
|
|
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN
|
|
* THE SOFTWARE.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "hw/pci-host/pam.h"
|
|
|
|
void init_pam(PAMMemoryRegion *mem, Object *owner, MemoryRegion *ram_memory,
|
|
MemoryRegion *system_memory, MemoryRegion *pci_address_space,
|
|
uint32_t start, uint32_t size)
|
|
{
|
|
int i;
|
|
|
|
/* RAM */
|
|
memory_region_init_alias(&mem->alias[3], owner, "pam-ram", ram_memory,
|
|
start, size);
|
|
/* ROM (XXX: not quite correct) */
|
|
memory_region_init_alias(&mem->alias[1], owner, "pam-rom", ram_memory,
|
|
start, size);
|
|
memory_region_set_readonly(&mem->alias[1], true);
|
|
|
|
/* XXX: should distinguish read/write cases */
|
|
memory_region_init_alias(&mem->alias[0], owner, "pam-pci", pci_address_space,
|
|
start, size);
|
|
memory_region_init_alias(&mem->alias[2], owner, "pam-pci", ram_memory,
|
|
start, size);
|
|
|
|
memory_region_transaction_begin();
|
|
for (i = 0; i < 4; ++i) {
|
|
memory_region_set_enabled(&mem->alias[i], false);
|
|
memory_region_add_subregion_overlap(system_memory, start,
|
|
&mem->alias[i], 1);
|
|
}
|
|
memory_region_transaction_commit();
|
|
mem->current = 0;
|
|
}
|
|
|
|
void pam_update(PAMMemoryRegion *pam, int idx, uint8_t val)
|
|
{
|
|
assert(0 <= idx && idx < PAM_REGIONS_COUNT);
|
|
|
|
memory_region_set_enabled(&pam->alias[pam->current], false);
|
|
pam->current = (val >> ((!(idx & 1)) * 4)) & PAM_ATTR_MASK;
|
|
memory_region_set_enabled(&pam->alias[pam->current], true);
|
|
}
|