qemu/target/s390x
Ilya Leoshkevich 86131c71b1 target/s390x: Fix translation exception on illegal instruction
Hitting an uretprobe in a s390x TCG guest causes a SIGSEGV. What
happens is:

* uretprobe maps a userspace page containing an invalid instruction.
* uretprobe replaces the target function's return address with the
  address of that page.
* When tb_gen_code() is called on that page, tb->size ends up being 0
  (because the page starts with the invalid instruction), which causes
  virt_page2 to point to the previous page.
* The previous page is not mapped, so this causes a spurious
  translation exception.

tb->size must never be 0: even if there is an illegal instruction, the
instruction bytes that have been looked at must count towards tb->size.
So adjust s390x's translate_one() to act this way for both illegal
instructions and instructions that are known to generate exceptions.

Signed-off-by: Ilya Leoshkevich <iii@linux.ibm.com>
Reviewed-by: David Hildenbrand <david@redhat.com>
Message-Id: <20210416154939.32404-2-iii@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>
2021-05-20 14:19:30 +02:00
..
arch_dump.c target/s390x/arch_dump: Fix warning for the name field in the PT_NOTE section 2021-03-04 11:23:35 +01:00
cc_helper.c target/s390x: Improve SUB LOGICAL WITH BORROW 2020-12-21 18:11:33 +01:00
cpu-param.h tcg: Split out target/arch/cpu-param.h 2019-06-10 07:03:34 -07:00
cpu-qom.h qom: Remove module_obj_name parameter from OBJECT_DECLARE* macros 2020-09-18 14:12:32 -04:00
cpu.c Do not include sysemu/sysemu.h if it's not really necessary 2021-05-02 17:24:50 +02:00
cpu.h s390x: move S390_ADAPTER_SUPPRESSIBLE 2021-03-26 09:33:50 +01:00
cpu_features.c s390x: pv: Fence additional unavailable SCLP facilities for PV guests 2020-12-21 18:11:32 +01:00
cpu_features.h s390x: pv: Fix diag318 PV fencing 2020-10-22 15:47:27 +02:00
cpu_features_def.h meson: rename .inc.h files to .h.inc 2020-08-21 06:18:35 -04:00
cpu_features_def.h.inc s390x/cpumodel: S390_FEAT_MISC_INSTRUCTION_EXT -> S390_FEAT_MISC_INSTRUCTION_EXT2 2020-10-02 13:52:49 +02:00
cpu_models.c s390x/cpu_model: use official name for 8562 2021-03-15 11:01:23 +01:00
cpu_models.h meson: convert target/s390x/gen-features.h 2020-08-21 06:30:17 -04:00
crypto_helper.c target/s390x: Use tcg_s390_program_interrupt in TCG helpers 2019-10-09 12:49:01 +02:00
diag.c Do not include exec/address-spaces.h if it's not really necessary 2021-05-02 17:24:51 +02:00
excp_helper.c Do not include sysemu/sysemu.h if it's not really necessary 2021-05-02 17:24:50 +02:00
fpu_helper.c softfloat: Name compare relation enum 2020-05-19 08:41:45 -07:00
gdbstub.c gdbstub: extend GByteArray to read register helpers 2020-03-17 17:38:38 +00:00
gen-features.c s390x/tcg: Implement CIPHER MESSAGE WITH AUTHENTICATION (KMA) 2020-10-02 13:52:49 +02:00
helper.c target/s390x: Improve SUB LOGICAL WITH BORROW 2020-12-21 18:11:33 +01:00
helper.h target/s390x: Store r1/r2 for page-translation exceptions during MVPG 2021-03-15 11:03:20 +01:00
insn-data.def target/s390x: Store r1/r2 for page-translation exceptions during MVPG 2021-03-15 11:03:20 +01:00
insn-format.def s390x/tcg: Define vector instruction formats 2019-03-11 09:31:01 +01:00
int_helper.c target/s390x: Use tcg_s390_program_interrupt in TCG helpers 2019-10-09 12:49:01 +02:00
internal.h target/s390x: Improve SUB LOGICAL WITH BORROW 2020-12-21 18:11:33 +01:00
interrupt.c hw: Do not include qemu/log.h if it is not necessary 2021-05-02 17:24:50 +02:00
ioinst.c css: SCHIB measurement block origin must be aligned 2021-03-04 11:23:35 +01:00
kvm-stub.c s390/kvm: fix diag318 propagation and reset functionality 2020-11-18 16:57:48 +01:00
kvm.c s390x/kvm: Get rid of legacy_s390_alloc() 2021-03-15 11:01:23 +01:00
kvm_s390x.h s390/kvm: fix diag318 propagation and reset functionality 2020-11-18 16:57:48 +01:00
machine.c s390: guest support for diagnose 0x318 2020-10-02 13:52:49 +02:00
mem_helper.c target/s390x: fix s390_probe_access to check PAGE_WRITE_ORG for writeability 2021-04-23 14:10:56 +01:00
meson.build target/s390x: fix meson.build issue 2020-08-21 11:55:13 -04:00
misc_helper.c s390x: Use strpadcpy for copying vm name 2021-01-21 11:19:45 +01:00
mmu_helper.c s390x: do not use ram_size global 2020-12-10 12:15:09 -05:00
s390-tod.h target/s390x: Split out s390-tod.h 2019-02-18 11:25:43 +01:00
sigp.c s390x: sigp: Fix sense running reporting 2020-01-27 12:13:10 +01:00
tcg-stub.c target/s390x: Remove ilen parameter from tcg_s390_program_interrupt 2019-10-09 12:49:01 +02:00
tcg_s390x.h target/s390x: Remove ilen parameter from tcg_s390_program_interrupt 2019-10-09 12:49:01 +02:00
trace-events trace-events: Shorten file names in comments 2019-03-22 16:18:07 +00:00
trace.h trace: switch position of headers to what Meson requires 2020-08-21 06:18:24 -04:00
translate.c target/s390x: Fix translation exception on illegal instruction 2021-05-20 14:19:30 +02:00
translate_vx.c.inc meson: rename included C source files to .c.inc 2020-08-21 06:18:30 -04:00
vec.h s390x/tcg: Implement VECTOR STRING RANGE COMPARE 2019-06-07 14:53:25 +02:00
vec_fpu_helper.c softfloat: Inline float64 compare specializations 2020-05-19 08:42:45 -07:00
vec_helper.c Include qemu-common.h exactly where needed 2019-06-12 13:20:20 +02:00
vec_int_helper.c target/s390x: Use tcg_gen_gvec_rotl{i,s,v} 2020-06-02 08:42:37 -07:00
vec_string_helper.c s390x/tcg: Implement VECTOR STRING RANGE COMPARE 2019-06-07 14:53:25 +02:00