Thomas Huth fe823b6f87 io/channel-command: Do not kill the child process after closing the pipe ... We are currently facing some migration failure on s390x when running certain avocado-vt tests, e.g. when running the test type_specific.io-github-autotest-qemu.migrate.with_reboot.exec.gzip_exec. This test is using 'migrate -d "exec:nc localhost 5200"' for the migration. The problem is detected at the receiving side, where the migration stream apparently ends too early. However, the cause for the problem is at the sending side: After writing the migration stream into the pipe to netcat, the source QEMU calls qio_channel_command_close() which closes the pipe and immediately (!) kills the child process afterwards (via the function qio_channel_command_abort()). So if the sending netcat did not read the final bytes from the pipe yet, or if it did not manage to send out all its buffers yet, it is killed before the whole migration stream is passed to the destination side. QEMU can not know how much time is required by the child process to send over all migration data, so we should not kill it, neither directly nor after a delay. Let's simply wait for the child process to exit gracefully instead (this was also the behaviour of pclose() that was used in "exec:" migration before the QIOChannel rework). Signed-off-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com>		2018-02-15 16:54:57 +00:00
..
channel-buffer.c	io: avoid double-free when closing QIOChannelBuffer	2016-05-26 11:31:09 +05:30
channel-command.c	io/channel-command: Do not kill the child process after closing the pipe	2018-02-15 16:54:57 +00:00
channel-file.c	io: Add /dev/fdset/ support to QIOChannelFile	2018-02-15 16:54:57 +00:00
channel-socket.c	util: remove the obsolete non-blocking connect	2017-09-05 13:21:58 +01:00
channel-tls.c	io: add methods to set I/O handlers on AioContext	2017-02-21 11:14:07 +00:00
channel-util.c	all: Clean up includes	2016-02-23 12:43:05 +00:00
channel-watch.c	io: add methods to set I/O handlers on AioContext	2017-02-21 11:14:07 +00:00
channel-websock.c	io/channel-websock: handle continuous reads without any data	2018-02-15 16:54:57 +00:00
channel.c	io: Add new qio_channel_read{, v}_all_eof functions	2017-09-06 10:11:54 -05:00
dns-resolver.c	io: preserve ipv4/ipv6 flags when resolving InetSocketAddress	2017-07-14 14:28:29 +01:00
Makefile.objs	io: introduce a network socket listener API	2017-12-15 15:07:26 +00:00
net-listener.c	io: fix QIONetListener memory leak	2018-02-15 16:54:57 +00:00
task.c	io: fix possible double free of task error object	2017-01-26 10:26:18 +00:00
trace-events	io: add trace points for websocket HTTP protocol headers	2017-10-16 16:57:08 +01:00