Fangrui Song 25f74087c6 util/cutils: Fix incorrect integer->float conversion caught by clang ... Clang does not like do_strtosz()'s code to guard against overflow: qemu/util/cutils.c:245:23: error: implicit conversion from 'unsigned long' to 'double' changes value from 18446744073709550592 to 18446744073709551616 [-Werror,-Wimplicit-int-float-conversion] The warning will be enabled by default in clang 10. It is not available for clang <= 9. val * mul >= 0xfffffffffffffc00 is indeed wrong. 0xfffffffffffffc00 is not representable exactly as double. It's half-way between the representable values 0xfffffffffffff800 and 0x10000000000000000. Which one we get is implementation-defined. Bad. We want val * mul > (the largest uint64_t exactly representable as double). That's 0xfffffffffffff800. Write it as nextafter(0x1p64, 0) with a suitable comment. Signed-off-by: Fangrui Song <i@maskray.me> Reviewed-by: Markus Armbruster <armbru@redhat.com> [Patch split, commit message improved] Signed-off-by: Markus Armbruster <armbru@redhat.com> Message-Id: <20191122080039.12771-3-armbru@redhat.com> Reviewed-by: Richard Henderson <richard.henderson@linaro.org> Reviewed-by: Juan Quintela <quintela@redhat.com>		2019-11-25 06:00:05 +01:00
..
aio-posix.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
aio-wait.c
aio-win32.c	aio-posix: Fix concurrent aio_poll/set_fd_handler.	2019-01-14 14:09:41 +00:00
aiocb.c
async.c	util/async: avoid useless cast	2019-10-24 19:26:05 +02:00
atomic64.c
base64.c
bitmap.c	bitmap: Add bitmap_copy_with_{src|dst}_offset()	2019-07-15 15:39:02 +02:00
bitops.c	avoid TABs in files that only contain a few	2019-01-11 15:46:56 +01:00
buffer.c
bufferiszero.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
cacheinfo.c	Fix cacheline detection on FreeBSD/powerpc.	2019-09-19 14:42:13 +02:00
compatfd.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
coroutine-sigaltstack.c
coroutine-ucontext.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
coroutine-win32.c
crc32c.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
cutils.c	util/cutils: Fix incorrect integer->float conversion caught by clang	2019-11-25 06:00:05 +01:00
drm.c
envlist.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
error.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
event_notifier-posix.c	event_notifier: avoid dandling file descriptor in event_notifier_cleanup	2019-10-24 19:26:52 +02:00
event_notifier-win32.c
fifo8.c	Include migration/vmstate.h less	2019-08-16 13:31:52 +02:00
filemonitor-inotify.c	filemon: fix watch IDs to avoid potential wraparound issues	2019-04-02 13:52:02 +01:00
filemonitor-stub.c	filemon: fix watch IDs to avoid potential wraparound issues	2019-04-02 13:52:02 +01:00
getauxval.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
guest-random.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
hbitmap.c	hbitmap: handle set/reset with zero length	2019-10-28 11:22:30 +01:00
hexdump.c
host-utils.c
id.c	qemu-common: Move qemu_isalnum() etc. to qemu/ctype.h	2019-06-11 20:22:09 +02:00
iov.c	util/ioc.c: try to reassure Coverity about qemu_iovec_init_extended	2019-10-08 14:27:35 +01:00
iova-tree.c
keyval.c
lockcnt.c
log.c	plugin: add qemu_plugin_outs helper	2019-10-28 15:12:38 +00:00
main-loop.c	Do not use %m in common code to print error messages	2019-10-22 09:38:42 +02:00
Makefile.objs	util: introduce SharedResource	2019-10-28 11:22:31 +01:00
memfd.c	linux-user: add memfd_create	2019-09-11 08:46:17 +02:00
mmap-alloc.c	core: replace getpagesize() with qemu_real_host_page_size	2019-10-26 15:38:06 +02:00
module.c	module: return success on module load	2019-08-21 16:29:57 +02:00
notify.c	xen / notify: introduce a new XenWatchList abstraction	2019-09-24 12:18:47 +01:00
osdep.c	slirp: prefer c99 types over BSD kind	2019-02-07 15:49:08 +02:00
oslib-posix.c	core: replace getpagesize() with qemu_real_host_page_size	2019-10-26 15:38:06 +02:00
oslib-win32.c	core: replace getpagesize() with qemu_real_host_page_size	2019-10-26 15:38:06 +02:00
pagesize.c
path.c	util/path: Do not cache all filenames at startup	2019-06-24 22:19:30 +02:00
qdist.c
qemu-co-shared-resource.c	util: introduce SharedResource	2019-10-28 11:22:31 +01:00
qemu-config.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
qemu-coroutine-io.c	yield_until_fd_readable: make it work with any AioContect	2019-10-25 14:38:29 +02:00
qemu-coroutine-lock.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
qemu-coroutine-sleep.c	qemu-coroutine-sleep: Silence Coverity warning	2019-11-18 16:01:34 -06:00
qemu-coroutine.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
qemu-error.c	monitor error: Make printf()-like functions return a value	2019-04-18 22:18:59 +02:00
qemu-openpty.c
qemu-option.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
qemu-print.c	qemu-print: New qemu_fprintf(), qemu_vfprintf()	2019-04-18 22:18:59 +02:00
qemu-progress.c
qemu-sockets.c	util/qemu-sockets: fix keep_alive handling in inet_connect_saddr	2019-09-25 08:15:44 -05:00
qemu-thread-common.h	Clean up includes	2018-12-20 10:29:08 +01:00
qemu-thread-posix.c	qemu-thread: Add qemu_cond_timedwait	2019-09-16 17:13:06 +02:00
qemu-thread-win32.c	qemu-thread: Add qemu_cond_timedwait	2019-09-16 17:13:06 +02:00
qemu-timer-common.c
qemu-timer.c	qemu-timer: reuse MIN macro in qemu_timeout_ns_to_ms	2019-10-24 20:10:18 +02:00
qht.c
qsp.c	qemu-thread: Add qemu_cond_timedwait	2019-09-16 17:13:06 +02:00
range.c	Don't talk about the LGPL if the file is licensed under the GPL	2019-01-30 10:51:20 +01:00
rcu.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
readline.c	qemu-common: Move qemu_isalnum() etc. to qemu/ctype.h	2019-06-11 20:22:09 +02:00
stats64.c
sys_membarrier.c
systemd.c	Do not use %m in common code to print error messages	2019-10-22 09:38:42 +02:00
thread-pool.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
throttle.c
timed-average.c
trace-events	socket: Add backlog parameter to socket_listen	2019-09-03 23:24:42 +02:00
unicode.c
uri.c
uuid.c	Include qemu-common.h exactly where needed	2019-06-12 13:20:20 +02:00
vfio-helpers.c	core: replace getpagesize() with qemu_real_host_page_size	2019-10-26 15:38:06 +02:00