qemu/hw/pci-host
Markus Armbruster d10e54329b isa: Clean up error handling around isa_bus_new()
We can have at most one ISA bus.  If you try to create another one,
isa_bus_new() complains to stderr and returns null.

isa_bus_new() is called in two contexts, machine's init() and device's
realize() methods.  Since complaining to stderr is not proper in the
latter context, convert isa_bus_new() to Error.

Machine's init():

* mips_jazz_init(), called from the init() methods of machines
  "magnum" and "pica"

* mips_r4k_init(), the init() method of machine "mips"

* pc_init1() called from the init() methods of non-q35 PC machines

* typhoon_init(), called from clipper_init(), the init() method of
  machine "clipper"

These callers always create the first ISA bus, hence isa_bus_new()
can't fail.  Simply pass &error_abort.

Device's realize():

* i82378_realize(), of PCI device "i82378"

* ich9_lpc_realize(), of PCI device "ICH9-LPC"

* pci_ebus_realize(), of PCI device "ebus"

* piix3_realize(), of PCI device "pci-piix3", abstract parent of
  "PIIX3" and "PIIX3-xen"

* piix4_realize(), of PCI device "PIIX4"

* vt82c686b_realize(), of PCI device "VT82C686B"

Propagate the error.  Note that these devices are typically created
only by machine init() methods with qdev_init_nofail() or similar.  If
we screwed up and created an ISA bus before that call, we now give up
right away.  Before, we'd hobble on, and typically die in
isa_bus_irqs().  Similar if someone finds a way to hot-plug one of
these critters.

Cc: Richard Henderson <rth@twiddle.net>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: "Hervé Poussineau" <hpoussin@reactos.org>
Cc: Aurelien Jarno <aurelien@aurel32.net>
Cc: Mark Cave-Ayland <mark.cave-ayland@ilande.co.uk>
Signed-off-by: Markus Armbruster <armbru@pond.sub.org>
Reviewed-by: Marcel Apfelbaum <marcel@redhat.com>
Reviewed-by: Hervé Poussineau <hpoussin@reactos.org>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Message-Id: <1450370121-5768-11-git-send-email-armbru@redhat.com>
2016-01-13 11:58:59 +01:00
..
apb.c Switch non-CPU callers from ld/st*_phys to address_space_ld/st* 2015-04-26 16:49:24 +01:00
bonito.c PCI Bonito: QOMify and cleanup 2016-01-11 11:39:28 +03:00
gpex.c pci: Add generic PCIe host bridge 2015-02-13 05:46:07 +00:00
grackle.c grackle: add to bridge category 2015-10-23 12:35:18 +11:00
Makefile.objs pci: Add generic PCIe host bridge 2015-02-13 05:46:07 +00:00
pam.c hw/i386: remove smram_update 2015-06-05 17:36:39 +02:00
piix.c isa: Clean up error handling around isa_bus_new() 2016-01-13 11:58:59 +01:00
ppce500.c PPC: e500 pci host: Fix ATMUs register reads 2015-09-20 22:48:39 +02:00
prep.c raven: Mark use of hw_error() in realize() FIXME 2016-01-13 11:58:58 +01:00
q35.c q35: Check propery to determine if iommu is set 2015-11-17 15:41:13 +02:00
uninorth.c uninorth: add to bridge category 2015-10-23 12:35:18 +11:00
versatile.c qdev: Protect device-list-properties against broken devices 2015-10-09 15:25:57 +02:00