qemu/monitor
Paolo Bonzini cfb5387a1d hmp: remove "change vnc TARGET" command
The HMP command \"change vnc TARGET\" is messy:

- it takes an ugly shortcut to determine if the option has an "id",
with incorrect results if "id=" is not preceded by an unescaped
comma.

- it deletes the existing QemuOpts and does not try to rollback
if the parsing fails (which is not causing problems, but only due to
how VNC options are parsed)

- because it uses the same parsing function as "-vnc", it forces
the latter to not support "-vnc help".

On top of this, it uses a deprecated QMP command, thus getting in
the way of removing the QMP command.  Since the usecase for the
command is not clear, just remove it and send "change vnc password"
directly to the QMP "change-vnc-password" command.

Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Gerd Hoffmann <kraxel@redhat.com>
Message-Id: <20210120144235.345983-2-pbonzini@redhat.com>
Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
2021-01-23 15:55:07 -05:00
..
hmp-cmds.c hmp: remove "change vnc TARGET" command 2021-01-23 15:55:07 -05:00
hmp.c machine: introduce MachineInitPhase 2020-12-15 12:51:52 -05:00
meson.build meson: add spice_headers dependency. 2020-10-15 11:14:40 +02:00
misc.c remove TCG includes from common code 2021-01-02 21:03:36 +01:00
monitor-internal.h monitor: Use GString instead of QString for output buffer 2020-12-19 10:38:35 +01:00
monitor.c monitor: Use GString instead of QString for output buffer 2020-12-19 10:38:35 +01:00
qmp-cmds-control.c qapi: Use QAPI_LIST_PREPEND() where possible 2020-12-19 10:20:14 +01:00
qmp-cmds.c qmp: generalize watchdog-set-action to -no-reboot/-no-shutdown 2020-12-15 12:51:57 -05:00
qmp.c qmp: Fix tracing of non-string command IDs 2020-12-19 10:38:43 +01:00
trace-events monitor: Split out monitor/monitor.c 2019-06-18 08:14:17 +02:00
trace.h trace: switch position of headers to what Meson requires 2020-08-21 06:18:24 -04:00