mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 01:43:39 +00:00
![Thomas Huth](/assets/img/avatar_default.png)
GCC 9.3.0 on Ubuntu complains: In file included from /usr/include/string.h:495, from /home/travis/build/huth/qemu/include/qemu/osdep.h:87, from ../migration/global_state.c:13: In function ‘strncpy’, inlined from ‘global_state_store_running’ at ../migration/global_state.c:47:5: /usr/include/x86_64-linux-gnu/bits/string_fortified.h:106:10: error: ‘__builtin_strncpy’ specified bound 100 equals destination size [-Werror=stringop-truncation] 106 | return __builtin___strncpy_chk (__dest, __src, __len, __bos (__dest)); | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ ... but we apparently really want to do a strncpy here - the size is already checked with the assert() statement right in front of it. To silence the warning, simply replace it with our strpadcpy() function. Suggested-by: Philippe Mathieu-Daudé <philmd@redhat.com> (two years ago) Signed-off-by: Thomas Huth <thuth@redhat.com> Signed-off-by: Alex Bennée <alex.bennee@linaro.org> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> Message-Id: <20200918103430.297167-4-thuth@redhat.com> Message-Id: <20200925154027.12672-5-alex.bennee@linaro.org>
149 lines
3.7 KiB
C
149 lines
3.7 KiB
C
/*
|
|
* Global State configuration
|
|
*
|
|
* Copyright (c) 2014-2017 Red Hat Inc
|
|
*
|
|
* Authors:
|
|
* Juan Quintela <quintela@redhat.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qemu/cutils.h"
|
|
#include "qemu/error-report.h"
|
|
#include "sysemu/runstate.h"
|
|
#include "qapi/error.h"
|
|
#include "migration.h"
|
|
#include "migration/global_state.h"
|
|
#include "migration/vmstate.h"
|
|
#include "trace.h"
|
|
|
|
typedef struct {
|
|
uint32_t size;
|
|
uint8_t runstate[100];
|
|
RunState state;
|
|
bool received;
|
|
} GlobalState;
|
|
|
|
static GlobalState global_state;
|
|
|
|
int global_state_store(void)
|
|
{
|
|
if (!runstate_store((char *)global_state.runstate,
|
|
sizeof(global_state.runstate))) {
|
|
error_report("runstate name too big: %s", global_state.runstate);
|
|
trace_migrate_state_too_big();
|
|
return -EINVAL;
|
|
}
|
|
return 0;
|
|
}
|
|
|
|
void global_state_store_running(void)
|
|
{
|
|
const char *state = RunState_str(RUN_STATE_RUNNING);
|
|
assert(strlen(state) < sizeof(global_state.runstate));
|
|
strpadcpy((char *)global_state.runstate, sizeof(global_state.runstate),
|
|
state, '\0');
|
|
}
|
|
|
|
bool global_state_received(void)
|
|
{
|
|
return global_state.received;
|
|
}
|
|
|
|
RunState global_state_get_runstate(void)
|
|
{
|
|
return global_state.state;
|
|
}
|
|
|
|
static bool global_state_needed(void *opaque)
|
|
{
|
|
GlobalState *s = opaque;
|
|
char *runstate = (char *)s->runstate;
|
|
|
|
/* If it is not optional, it is mandatory */
|
|
|
|
if (migrate_get_current()->store_global_state) {
|
|
return true;
|
|
}
|
|
|
|
/* If state is running or paused, it is not needed */
|
|
|
|
if (strcmp(runstate, "running") == 0 ||
|
|
strcmp(runstate, "paused") == 0) {
|
|
return false;
|
|
}
|
|
|
|
/* for any other state it is needed */
|
|
return true;
|
|
}
|
|
|
|
static int global_state_post_load(void *opaque, int version_id)
|
|
{
|
|
GlobalState *s = opaque;
|
|
Error *local_err = NULL;
|
|
int r;
|
|
char *runstate = (char *)s->runstate;
|
|
|
|
s->received = true;
|
|
trace_migrate_global_state_post_load(runstate);
|
|
|
|
if (strnlen((char *)s->runstate,
|
|
sizeof(s->runstate)) == sizeof(s->runstate)) {
|
|
/*
|
|
* This condition should never happen during migration, because
|
|
* all runstate names are shorter than 100 bytes (the size of
|
|
* s->runstate). However, a malicious stream could overflow
|
|
* the qapi_enum_parse() call, so we force the last character
|
|
* to a NUL byte.
|
|
*/
|
|
s->runstate[sizeof(s->runstate) - 1] = '\0';
|
|
}
|
|
r = qapi_enum_parse(&RunState_lookup, runstate, -1, &local_err);
|
|
|
|
if (r == -1) {
|
|
if (local_err) {
|
|
error_report_err(local_err);
|
|
}
|
|
return -EINVAL;
|
|
}
|
|
s->state = r;
|
|
|
|
return 0;
|
|
}
|
|
|
|
static int global_state_pre_save(void *opaque)
|
|
{
|
|
GlobalState *s = opaque;
|
|
|
|
trace_migrate_global_state_pre_save((char *)s->runstate);
|
|
s->size = strnlen((char *)s->runstate, sizeof(s->runstate)) + 1;
|
|
assert(s->size <= sizeof(s->runstate));
|
|
|
|
return 0;
|
|
}
|
|
|
|
static const VMStateDescription vmstate_globalstate = {
|
|
.name = "globalstate",
|
|
.version_id = 1,
|
|
.minimum_version_id = 1,
|
|
.post_load = global_state_post_load,
|
|
.pre_save = global_state_pre_save,
|
|
.needed = global_state_needed,
|
|
.fields = (VMStateField[]) {
|
|
VMSTATE_UINT32(size, GlobalState),
|
|
VMSTATE_BUFFER(runstate, GlobalState),
|
|
VMSTATE_END_OF_LIST()
|
|
},
|
|
};
|
|
|
|
void register_global_state(void)
|
|
{
|
|
/* We would use it independently that we receive it */
|
|
strcpy((char *)&global_state.runstate, "");
|
|
global_state.received = false;
|
|
vmstate_register(NULL, 0, &vmstate_globalstate, &global_state);
|
|
}
|