Stefan Hajnoczi c74831a02c rtl8139: keep Tx command mode 0 and 1 separate ... There are two Tx Descriptor formats called mode 0 and mode 1. The mode is determined by the Large Send bit. CP_TX_IPCS (bit 18) is defined in mode 1 but the code checks the bit unconditionally. In mode 0 bit 18 is part of the Large Send MSS value. Explicitly check the Large Send bit to distinguish Tx command modes. This avoids bugs where modes are confused. Note that I didn't find any actual bugs aside from needlessly computing the IP checksum when the Large Send bit is enabled. Acked-by: Jason Wang <jasowang@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org> Signed-off-by: Stefan Hajnoczi <stefanha@redhat.com> Message-Id: <20221117165554.1773409-3-stefanha@redhat.com>		2022-11-21 09:28:43 -05:00
..
9pfs	Pull request	2022-10-25 11:37:17 -04:00
acpi	hw/acpi/erst.c: Fix memory handling issues	2022-11-07 14:08:17 -05:00
adc	hw/adc: Make adci[*] R/W in NPCM7XX ADC	2022-07-18 13:20:14 +01:00
alpha	hw: Remove unused MAX_IDE_BUS define	2022-10-31 11:32:07 +01:00
arm	pci,pc,virtio: features, tests, fixes, cleanups	2022-11-07 18:43:56 -05:00
audio	hw/audio/cs4231a: Const'ify global tables	2022-06-11 11:44:50 +02:00
avr	Remove qemu-common.h include from most units	2022-04-06 14:31:55 +02:00
block	Revert "hw/block/pflash_cfi: Error out if dev length isn't power of 2"	2022-11-08 15:53:40 -05:00
char	Drop useless casts from g_malloc() & friends to pointer	2022-10-22 23:15:40 +02:00
core	pci,pc,virtio: features, tests, fixes, cleanups	2022-11-07 18:43:56 -05:00
cpu	cpu/core: Fix "help" of CPU core device types	2021-04-09 16:05:16 -04:00
cris	Do not include exec/address-spaces.h if it's not really necessary	2021-05-02 17:24:51 +02:00
cxl	hw/cxl/cdat: CXL CDAT Data Object Exchange implementation	2022-11-07 13:12:19 -05:00
display	display: include dependencies explicitly	2022-11-10 10:17:18 -05:00
dma	treewide: Remove the unnecessary space before semicolon	2022-10-24 13:41:10 +02:00
gpio	hw/gpio/meson: Introduce dedicated config switch for hw/gpio/mpc8xxx	2022-10-17 16:15:09 -03:00
hppa	hw: Remove unused MAX_IDE_BUS define	2022-10-31 11:32:07 +01:00
hyperv	hw/hyperv/hyperv.c: Use device_cold_reset() instead of device_legacy_reset()	2022-10-27 10:27:23 +01:00
i2c	hw/i2c/aspeed: Fix old reg slave receive	2022-10-24 11:20:15 +02:00
i386	pci,pc,virtio: features, tests, fixes, cleanups	2022-11-07 18:43:56 -05:00
ide	hw/ppc/mac.h: Rename to include/hw/nvram/mac_nvram.h	2022-10-31 18:48:23 +00:00
input	pckbd: remove legacy i8042_mm_init() function	2022-07-18 19:28:46 +01:00
intc	hw/intc: add implementation of GICD_IIDR to Arm GIC	2022-11-21 11:45:13 +00:00
ipack	qbus: Rename qbus_create_inplace() to qbus_init()	2021-09-30 13:42:10 +01:00
ipmi	ipmi:smbus: Add a check around a memcpy	2022-08-01 06:40:50 -05:00
isa	acpi: pc/q35: drop ad-hoc PCI-ISA bridge AML routines and let bus ennumeration generate AML	2022-11-07 14:08:17 -05:00
loongarch	hw/loongarch: Fix loongarch fdt addr confict	2022-11-12 11:05:52 +10:00
m68k	m68k/q800: do not re-randomize RNG seed on snapshot load	2022-10-27 11:34:31 +01:00
mem	hw/mem/cxl-type3: Add CXL CDAT Data Object Exchange	2022-11-07 13:12:19 -05:00
microblaze	hw/microblaze: pass random seed to fdt	2022-09-21 19:59:56 +02:00
mips	hw/mips/malta: Use bootloader helper to set BAR registers	2022-10-31 11:32:56 +01:00
misc	mac_nvram: Use NVRAM_SIZE constant	2022-10-31 18:48:23 +00:00
net	rtl8139: keep Tx command mode 0 and 1 separate	2022-11-21 09:28:43 -05:00
nios2	hw/nios2: set machine->fdt in nios2_load_dtb()	2022-10-17 16:15:10 -03:00
nubus	qbus: Rename qbus_create_inplace() to qbus_init()	2021-09-30 13:42:10 +01:00
nvme	pci,pc,virtio: features, tests, fixes, cleanups	2022-11-07 18:43:56 -05:00
nvram	hw/ppc/mac.h: Rename to include/hw/nvram/mac_nvram.h	2022-10-31 18:48:23 +00:00
openrisc	openrisc: re-randomize rng-seed on reboot	2022-10-27 11:34:31 +01:00
pci	msix: Assert that specified vector is in range	2022-11-07 14:08:17 -05:00
pci-bridge	hw/pci-bridge/cxl-upstream: Add a CDAT table access DOE	2022-11-07 13:12:19 -05:00
pci-host	hw/pci-host/pnv_phb: Avoid quitting QEMU if hotplug of pnv-phb-root-port fails	2022-11-10 18:22:10 -03:00
pcmcia	hw/pcmcia: Do not register PCMCIA type if not required	2021-05-02 17:24:50 +02:00
ppc	mac_newworld: Turn CORE99_VIA_CONFIG defines into an enum	2022-10-31 18:48:23 +00:00
rdma	msix: Assert that specified vector is in range	2022-11-07 14:08:17 -05:00
remote	msix: Assert that specified vector is in range	2022-11-07 14:08:17 -05:00
riscv	riscv: re-randomize rng-seed on reboot	2022-10-27 11:34:31 +01:00
rtc	goldfish_rtc: Add big-endian property	2022-09-04 07:02:56 +01:00
rx	rx: re-randomize rng-seed on reboot	2022-10-27 11:34:31 +01:00
s390x	s390x: Fix spelling errors	2022-11-16 10:15:26 +01:00
scsi	Fix several typos in documentation (found by codespell)	2022-11-11 09:39:25 +01:00
sd	hw/sd: Fix sun4i allwinner-sdhost for U-Boot	2022-11-21 11:45:12 +00:00
sensor	hw/sensor: Add Renesas ISL69259 device model	2022-07-14 16:24:38 +02:00
sh4	Use g_new() & friends where that makes obvious sense	2022-03-21 15:44:44 +01:00
smbios	hw/smbios: add core_count2 to smbios table type 4	2022-11-07 14:08:17 -05:00
sparc	machine: make memory-backend a link property	2022-05-12 12:29:44 +02:00
sparc64	hw: Remove unused MAX_IDE_BUS define	2022-10-31 11:32:07 +01:00
ssi	aspeed/smc: Cache AspeedSMCClass	2022-10-24 11:20:15 +02:00
timer	target/imx: reload cmp timer outside of the reload ptimer transaction	2022-10-27 10:27:23 +01:00
tpm	tpm_crb: Avoid backend startup just before shutdown under Xen	2022-09-09 17:55:59 -04:00
tricore	hw/tricore: fix inclusion of tricore_testboard	2021-07-20 20:10:21 +02:00
usb	host-libusb: Remove unused variable	2022-11-11 09:12:10 +01:00
vfio	pci,pc,virtio: features, tests, fixes, cleanups	2022-11-07 18:43:56 -05:00
virtio	hw/virtio: introduce virtio_device_should_start	2022-11-07 14:08:18 -05:00
watchdog	watchdog: remove -watchdog option	2022-09-29 11:40:28 +02:00
xen	xen/pt: fix syntax error that causes FTBFS in some configurations	2022-11-05 20:35:45 +01:00
xenpv	Warn user if the vga flag is passed but no vga device is created	2022-05-09 08:21:14 +02:00
xtensa	hw/xtensa: fix reset value of MIROUT register of MX PIC	2022-05-06 15:27:40 -07:00
Kconfig	hw/loongarch: Add support loongson3 virt machine type.	2022-06-06 18:09:03 +00:00
meson.build	hw/loongarch: Add support loongson3 virt machine type.	2022-06-06 18:09:03 +00:00