mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-11-05 20:35:44 +00:00
1f4a0d81af
The tests that check something for all machine types currently spend a lot of time checking old machine types (like "pc-i440fx-2.0" for example). The chances that we find something new there in addition to checking the latest version of a machine type are pretty low, so we should not waste the time of the developers by testing this again and again in the "quick" testing mode. Thus let's add some code to determine whether we are testing a current machine type or an old one, and only test the old types if we are running in "SPEED=slow" mode. This decreases the testing time quite a bit now, e.g. the qom-test now finishes within 4 seconds for qemu-system-x86_64 instead of 30 seconds when testing all machines. Signed-off-by: Thomas Huth <thuth@redhat.com> Message-Id: <1534419358-10932-6-git-send-email-thuth@redhat.com> Signed-off-by: Paolo Bonzini <pbonzini@redhat.com>
129 lines
3.3 KiB
C
129 lines
3.3 KiB
C
/*
|
|
* QTest testcase for QOM
|
|
*
|
|
* Copyright (c) 2013 SUSE LINUX Products GmbH
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
|
|
#include "qemu-common.h"
|
|
#include "qapi/qmp/qdict.h"
|
|
#include "qapi/qmp/qlist.h"
|
|
#include "qemu/cutils.h"
|
|
#include "libqtest.h"
|
|
|
|
static const char *blacklist_x86[] = {
|
|
"xenfv", "xenpv", NULL
|
|
};
|
|
|
|
static const struct {
|
|
const char *arch;
|
|
const char **machine;
|
|
} blacklists[] = {
|
|
{ "i386", blacklist_x86 },
|
|
{ "x86_64", blacklist_x86 },
|
|
};
|
|
|
|
static bool is_blacklisted(const char *arch, const char *mach)
|
|
{
|
|
int i;
|
|
const char **p;
|
|
|
|
for (i = 0; i < ARRAY_SIZE(blacklists); i++) {
|
|
if (!strcmp(blacklists[i].arch, arch)) {
|
|
for (p = blacklists[i].machine; *p; p++) {
|
|
if (!strcmp(*p, mach)) {
|
|
return true;
|
|
}
|
|
}
|
|
}
|
|
}
|
|
return false;
|
|
}
|
|
|
|
static void test_properties(const char *path, bool recurse)
|
|
{
|
|
char *child_path;
|
|
QDict *response, *tuple, *tmp;
|
|
QList *list;
|
|
QListEntry *entry;
|
|
|
|
g_test_message("Obtaining properties of %s", path);
|
|
response = qmp("{ 'execute': 'qom-list',"
|
|
" 'arguments': { 'path': %s } }", path);
|
|
g_assert(response);
|
|
|
|
if (!recurse) {
|
|
qobject_unref(response);
|
|
return;
|
|
}
|
|
|
|
g_assert(qdict_haskey(response, "return"));
|
|
list = qobject_to(QList, qdict_get(response, "return"));
|
|
QLIST_FOREACH_ENTRY(list, entry) {
|
|
tuple = qobject_to(QDict, qlist_entry_obj(entry));
|
|
bool is_child = strstart(qdict_get_str(tuple, "type"), "child<", NULL);
|
|
bool is_link = strstart(qdict_get_str(tuple, "type"), "link<", NULL);
|
|
|
|
if (is_child || is_link) {
|
|
child_path = g_strdup_printf("%s/%s",
|
|
path, qdict_get_str(tuple, "name"));
|
|
test_properties(child_path, is_child);
|
|
g_free(child_path);
|
|
} else {
|
|
const char *prop = qdict_get_str(tuple, "name");
|
|
g_test_message("Testing property %s.%s", path, prop);
|
|
tmp = qmp("{ 'execute': 'qom-get',"
|
|
" 'arguments': { 'path': %s,"
|
|
" 'property': %s } }",
|
|
path, prop);
|
|
/* qom-get may fail but should not, e.g., segfault. */
|
|
g_assert(tmp);
|
|
qobject_unref(tmp);
|
|
}
|
|
}
|
|
qobject_unref(response);
|
|
}
|
|
|
|
static void test_machine(gconstpointer data)
|
|
{
|
|
const char *machine = data;
|
|
char *args;
|
|
QDict *response;
|
|
|
|
args = g_strdup_printf("-machine %s", machine);
|
|
qtest_start(args);
|
|
|
|
test_properties("/machine", true);
|
|
|
|
response = qmp("{ 'execute': 'quit' }");
|
|
g_assert(qdict_haskey(response, "return"));
|
|
qobject_unref(response);
|
|
|
|
qtest_end();
|
|
g_free(args);
|
|
g_free((void *)machine);
|
|
}
|
|
|
|
static void add_machine_test_case(const char *mname)
|
|
{
|
|
const char *arch = qtest_get_arch();
|
|
|
|
if (!is_blacklisted(arch, mname)) {
|
|
char *path = g_strdup_printf("qom/%s", mname);
|
|
qtest_add_data_func(path, g_strdup(mname), test_machine);
|
|
g_free(path);
|
|
}
|
|
}
|
|
|
|
int main(int argc, char **argv)
|
|
{
|
|
g_test_init(&argc, &argv, NULL);
|
|
|
|
qtest_cb_for_every_machine(add_machine_test_case, g_test_quick());
|
|
|
|
return g_test_run();
|
|
}
|