mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-07-21 10:24:33 +00:00
01ec0f3a92
This doubly linked list is common for all the multifd and migration
threads so we need to avoid concurrent access.
Add a mutex to protect the data from concurrent access. This fixes a
crash when removing two MigrationThread objects from the list at the
same time during cleanup of multifd threads.
Fixes: 671326201d ("migration: Introduce interface query-migrationthreads")
Signed-off-by: Fabiano Rosas <farosas@suse.de>
Reviewed-by: Peter Xu <peterx@redhat.com>
Reviewed-by: Juan Quintela <quintela@redhat.com>
Message-Id: <20230607161306.31425-3-farosas@suse.de>
Signed-off-by: Juan Quintela <quintela@redhat.com>
65 lines
1.6 KiB
C
65 lines
1.6 KiB
C
/*
|
|
* Migration Threads info
|
|
*
|
|
* Copyright (c) 2022 HUAWEI TECHNOLOGIES CO., LTD.
|
|
*
|
|
* Authors:
|
|
* Jiang Jiacheng <jiangjiacheng@huawei.com>
|
|
*
|
|
* This work is licensed under the terms of the GNU GPL, version 2 or later.
|
|
* See the COPYING file in the top-level directory.
|
|
*/
|
|
|
|
#include "qemu/osdep.h"
|
|
#include "qemu/queue.h"
|
|
#include "qemu/lockable.h"
|
|
#include "threadinfo.h"
|
|
|
|
QemuMutex migration_threads_lock;
|
|
static QLIST_HEAD(, MigrationThread) migration_threads;
|
|
|
|
static void __attribute__((constructor)) migration_threads_init(void)
|
|
{
|
|
qemu_mutex_init(&migration_threads_lock);
|
|
}
|
|
|
|
MigrationThread *migration_threads_add(const char *name, int thread_id)
|
|
{
|
|
MigrationThread *thread = g_new0(MigrationThread, 1);
|
|
thread->name = name;
|
|
thread->thread_id = thread_id;
|
|
|
|
WITH_QEMU_LOCK_GUARD(&migration_threads_lock) {
|
|
QLIST_INSERT_HEAD(&migration_threads, thread, node);
|
|
}
|
|
|
|
return thread;
|
|
}
|
|
|
|
void migration_threads_remove(MigrationThread *thread)
|
|
{
|
|
QEMU_LOCK_GUARD(&migration_threads_lock);
|
|
if (thread) {
|
|
QLIST_REMOVE(thread, node);
|
|
g_free(thread);
|
|
}
|
|
}
|
|
|
|
MigrationThreadInfoList *qmp_query_migrationthreads(Error **errp)
|
|
{
|
|
MigrationThreadInfoList *head = NULL;
|
|
MigrationThreadInfoList **tail = &head;
|
|
MigrationThread *thread = NULL;
|
|
|
|
QEMU_LOCK_GUARD(&migration_threads_lock);
|
|
QLIST_FOREACH(thread, &migration_threads, node) {
|
|
MigrationThreadInfo *info = g_new0(MigrationThreadInfo, 1);
|
|
info->name = g_strdup(thread->name);
|
|
info->thread_id = thread->thread_id;
|
|
|
|
QAPI_LIST_APPEND(tail, info);
|
|
}
|
|
|
|
return head;
|
|
}
|