Kevin Wolf d3007d348a block: Fix crash when loading snapshot on inactive node ... bdrv_is_read_only() only checks if the node is configured to be read-only eventually, but even if it returns false, writing to the node may not be permitted at the moment (because it's inactive). bdrv_is_writable() checks that the node can be written to right now, and this is what the snapshot operations really need. Change bdrv_can_snapshot() to use bdrv_is_writable() to fix crashes like the following: $ ./qemu-system-x86_64 -hda /tmp/test.qcow2 -loadvm foo -incoming defer qemu-system-x86_64: ../block/io.c:1990: int bdrv_co_write_req_prepare(BdrvChild *, int64_t, int64_t, BdrvTrackedRequest *, int): Assertion `!(bs->open_flags & BDRV_O_INACTIVE)' failed. The resulting error message after this patch isn't perfect yet, but at least it doesn't crash any more: $ ./qemu-system-x86_64 -hda /tmp/test.qcow2 -loadvm foo -incoming defer qemu-system-x86_64: Device 'ide0-hd0' is writable but does not support snapshots Signed-off-by: Kevin Wolf <kwolf@redhat.com> Message-ID: <20231201142520.32255-2-kwolf@redhat.com> Signed-off-by: Kevin Wolf <kwolf@redhat.com>		2023-12-21 22:49:27 +01:00
..
export	export/vhost-user-blk: Fix consecutive drains	2023-11-28 14:56:32 +01:00
monitor	block: Mark bdrv_skip_implicit_filters() and callers GRAPH_RDLOCK	2023-11-07 19:14:19 +01:00
accounting.c	block: add missed block_acct_setup with new block device init procedure	2022-09-30 18:42:34 +02:00
aio_task.c
amend.c	block: Mark BlockDriver callbacks for amend job GRAPH_RDLOCK	2023-05-10 14:16:54 +02:00
backup.c	block: Fix deadlocks in bdrv_graph_wrunlock()	2023-11-21 12:45:21 +01:00
blkdebug.c	block: Take graph lock for most of .bdrv_open	2023-11-08 17:56:18 +01:00
blkio.c	util/defer-call: move defer_call() to util/	2023-10-31 15:41:42 +01:00
blklogwrites.c	block: Fix deadlocks in bdrv_graph_wrunlock()	2023-11-21 12:45:21 +01:00
blkreplay.c	block: Protect bs->file with graph_lock	2023-11-08 17:56:18 +01:00
blkverify.c	block: Fix deadlocks in bdrv_graph_wrunlock()	2023-11-21 12:45:21 +01:00
block-backend.c	block: Fix deadlocks in bdrv_graph_wrunlock()	2023-11-21 12:45:21 +01:00
block-copy.c	block: Mark bdrv_chain_contains() and callers GRAPH_RDLOCK	2023-11-07 19:14:19 +01:00
block-gen.h	block-coroutine-wrapper.py: support also basic return types	2022-12-15 16:07:43 +01:00
block-ram-registrar.c	block: add BlockRAMRegistrar	2022-10-26 14:56:42 -04:00
bochs.c	block: Take graph lock for most of .bdrv_open	2023-11-08 17:56:18 +01:00
cloop.c	block: Take graph lock for most of .bdrv_open	2023-11-08 17:56:18 +01:00
commit.c	block: Fix deadlocks in bdrv_graph_wrunlock()	2023-11-21 12:45:21 +01:00
copy-before-write.c	block: Protect bs->file with graph_lock	2023-11-08 17:56:18 +01:00
copy-before-write.h	block/copy-before-write.h: global state API + assertions	2022-03-04 18:18:25 +01:00
copy-on-read.c	block: Take graph lock for most of .bdrv_open	2023-11-08 17:56:18 +01:00
copy-on-read.h	block: Mark bdrv_(un)freeze_backing_chain() and callers GRAPH_RDLOCK	2023-11-07 19:14:19 +01:00
coroutines.h	nbd: Mark nbd_co_do_establish_connection() and callers GRAPH_RDLOCK	2023-05-10 14:16:53 +02:00
create.c	block: Call .bdrv_co_create(_opts) unlocked	2023-05-19 19:12:12 +02:00
crypto.c	block: Protect bs->file with graph_lock	2023-11-08 17:56:18 +01:00
crypto.h
curl.c	block: Mark bdrv_apply_auto_read_only() and callers GRAPH_RDLOCK	2023-10-12 16:31:33 +02:00
dirty-bitmap.c	block: Mark bdrv_*_dirty_bitmap() and callers GRAPH_RDLOCK	2023-02-23 19:49:32 +01:00
dmg-bz2.c
dmg-lzfse.c	block/dmg: Ignore C99 prototype declaration mismatch from <lzfse.h>	2023-03-30 15:03:36 +02:00
dmg.c	block: Protect bs->file with graph_lock	2023-11-08 17:56:18 +01:00
dmg.h	block/dmg: Declare a type definition for DMG uncompress function	2023-04-24 13:53:44 -04:00
file-posix.c	block/file-posix: set up Linux AIO and io_uring in the current thread	2023-12-21 22:49:27 +01:00
file-win32.c	thread-pool: avoid passing the pool parameter every time	2023-04-25 13:17:28 +02:00
filter-compress.c	block: Take graph lock for most of .bdrv_open	2023-11-08 17:56:18 +01:00
gluster.c	block: Mark bdrv_apply_auto_read_only() and callers GRAPH_RDLOCK	2023-10-12 16:31:33 +02:00
graph-lock.c	block: Fix deadlocks in bdrv_graph_wrunlock()	2023-11-21 12:45:21 +01:00
io.c	block: Add missing GRAPH_RDLOCK annotations	2023-11-08 17:56:17 +01:00
io_uring.c	virtio: use defer_call() in virtio_irqfd_notify()	2023-10-31 15:42:14 +01:00
iscsi-opts.c
iscsi.c	block: Mark bdrv_apply_auto_read_only() and callers GRAPH_RDLOCK	2023-10-12 16:31:33 +02:00
linux-aio.c	virtio: use defer_call() in virtio_irqfd_notify()	2023-10-31 15:42:14 +01:00
meson.build	util/defer-call: move defer_call() to util/	2023-10-31 15:41:42 +01:00
mirror.c	block: Fix deadlocks in bdrv_graph_wrunlock()	2023-11-21 12:45:21 +01:00
nbd.c	block: Mark bdrv_apply_auto_read_only() and callers GRAPH_RDLOCK	2023-10-12 16:31:33 +02:00
nfs.c	block: Mark bdrv_refresh_filename() and callers GRAPH_RDLOCK	2023-10-12 16:31:33 +02:00
null.c	block: Convert bdrv_get_allocated_file_size() to co_wrapper	2023-02-01 16:52:32 +01:00
nvme.c	block/nvme: nvme_process_completion() fix bound for cid	2023-11-06 15:00:28 +00:00
parallels-ext.c	block: Protect bs->file with graph_lock	2023-11-08 17:56:18 +01:00
parallels.c	block: Protect bs->file with graph_lock	2023-11-08 17:56:18 +01:00
parallels.h	block: Protect bs->file with graph_lock	2023-11-08 17:56:18 +01:00
preallocate.c	block: Protect bs->file with graph_lock	2023-11-08 17:56:18 +01:00
progress_meter.c	coroutine: Clean up superfluous inclusion of qemu/lockable.h	2023-01-19 10:18:28 +01:00
qapi-sysemu.c	block: Fix locking in media change monitor commands	2023-10-31 13:51:28 +01:00
qapi.c	block: Mark bdrv_refresh_filename() and callers GRAPH_RDLOCK	2023-10-12 16:31:33 +02:00
qcow.c	block: Take graph lock for most of .bdrv_open	2023-11-08 17:56:18 +01:00
qcow2-bitmap.c	qcow2: Take locks for accessing bs->file	2023-11-08 17:56:17 +01:00
qcow2-cache.c	qcow2: Mark qcow2_signal_corruption() and callers GRAPH_RDLOCK	2023-10-12 16:31:33 +02:00
qcow2-cluster.c	qcow2: Take locks for accessing bs->file	2023-11-08 17:56:17 +01:00
qcow2-refcount.c	qcow2: Mark qcow2_signal_corruption() and callers GRAPH_RDLOCK	2023-10-12 16:31:33 +02:00
qcow2-snapshot.c	qcow2: mark various functions as coroutine_fn and GRAPH_RDLOCK	2023-04-25 13:17:28 +02:00
qcow2-threads.c	thread-pool: avoid passing the pool parameter every time	2023-04-25 13:17:28 +02:00
qcow2.c	block: Fix deadlocks in bdrv_graph_wrunlock()	2023-11-21 12:45:21 +01:00
qcow2.h	qcow2: Take locks for accessing bs->file	2023-11-08 17:56:17 +01:00
qed-check.c	qed: mark more functions as coroutine_fns and GRAPH_RDLOCK	2023-06-28 09:46:20 +02:00
qed-cluster.c
qed-l2-cache.c	osdep: Move memalign-related functions to their own header	2022-03-07 13:16:49 +00:00
qed-table.c	block: use bdrv_co_debug_event in coroutine context	2023-06-28 09:46:34 +02:00
qed.c	block: Protect bs->file with graph_lock	2023-11-08 17:56:18 +01:00
qed.h	block: Protect bs->file with graph_lock	2023-11-08 17:56:18 +01:00
quorum.c	block: Fix deadlocks in bdrv_graph_wrunlock()	2023-11-21 12:45:21 +01:00
raw-format.c	block: Protect bs->file with graph_lock	2023-11-08 17:56:18 +01:00
rbd.c	block: Mark bdrv_apply_auto_read_only() and callers GRAPH_RDLOCK	2023-10-12 16:31:33 +02:00
replication.c	block: Fix deadlocks in bdrv_graph_wrunlock()	2023-11-21 12:45:21 +01:00
reqlist.c	block/reqlist: add reqlist_wait_all()	2022-03-07 09:33:30 +01:00
snapshot-access.c	block: Take graph lock for most of .bdrv_open	2023-11-08 17:56:18 +01:00
snapshot.c	block: Fix crash when loading snapshot on inactive node	2023-12-21 22:49:27 +01:00
ssh.c	aio: remove aio_disable_external() API	2023-05-30 17:37:26 +02:00
stream.c	stream: Fix AioContext locking during bdrv_graph_wrlock()	2023-11-21 12:45:21 +01:00
throttle-groups.c	block: mark mixed functions that can suspend	2023-09-26 18:09:08 +02:00
throttle.c	block: Take graph lock for most of .bdrv_open	2023-11-08 17:56:18 +01:00
trace-events	nbd/client: Accept 64-bit block status chunks	2023-10-05 11:02:08 -05:00
trace.h
vdi.c	block: Take graph lock for most of .bdrv_open	2023-11-08 17:56:18 +01:00
vhdx-endian.c
vhdx-log.c	vhdx: Take locks for accessing bs->file	2023-11-08 17:56:18 +01:00
vhdx.c	vhdx: Take locks for accessing bs->file	2023-11-08 17:56:18 +01:00
vhdx.h	vhdx: Take locks for accessing bs->file	2023-11-08 17:56:18 +01:00
vmdk.c	vmdk: Don't corrupt desc file in vmdk_write_cid	2023-11-28 14:56:32 +01:00
vpc.c	block: Take graph lock for most of .bdrv_open	2023-11-08 17:56:18 +01:00
vvfat.c	cpr: relax blockdev migration blockers	2023-11-01 16:13:59 +01:00
win32-aio.c	aio: remove aio_disable_external() API	2023-05-30 17:37:26 +02:00
write-threshold.c	include/block: Untangle inclusion loops	2023-01-20 07:24:28 +01:00