mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-11-05 20:35:44 +00:00
a15fcc3cf6
We have a couple places in the code base that want to deep-clone
one QAPI object into another, and they were resorting to serializing
the struct out to QObject then reparsing it. A much more efficient
version can be done by adding a new clone visitor.
Since cloning is still relatively uncommon, expose the use of the
new visitor via a QAPI_CLONE() macro that takes care of type-punning
the underlying function pointer, rather than generating lots of
unused functions for types that won't be cloned. And yes, we're
relying on the compiler treating all pointers equally, even though
a strict C program cannot portably do so - but we're not the first
one in the qemu code base to expect it to work (hello, glib!).
The choice of adding a fourth visitor type deserves some explanation.
On the surface, the clone visitor is mostly an input visitor (it
takes arbitrary input - in this case, another QAPI object - and
creates a new QAPI object during the course of the visit). But
ever since commit da72ab0 consolidated enum visits based on the
visitor type, using VISITOR_INPUT would cause us to run
visit_type_str(), even though for cloning there is nothing to do
(we just copy the enum value across, without regards to its mapping
to strings). Also, since our input happens to be a QAPI object,
we can also satisfy the internal checks for VISITOR_OUTPUT. So in
the end, I settled with a new VISITOR_CLONE, and chose its value
such that many internal checks can use 'v->type & mask', sticking
to 'v->type == value' where the difference matters.
Note that we can only clone objects (including alternates) and lists,
not built-ins or enums. The visitor core hides integer width from
the actual visitor (since commit 04e070d), and as long as that's the
case, we can't clone top-level integers. Then again, those can
always be cloned by direct copy, since they are not objects with
deep pointers, so it's no real loss. And restricting cloning to
just objects and lists is cleaner than restricting it to non-integers.
As such, I documented that the clone visitor is for direct use only
by code internal to QAPI, and should not be used on incomplete objects
(other than a hack to work around the fact that we allow NULL in place
of "" in visit_type_str() in other output visitors). Note that as
written, the clone visitor will never fail on a complete object.
Scalars (including enums) not at the root of the clone copy just fine
with no additional effort while visiting the scalar, by virtue of a
g_memdup() each time we push another struct onto the stack. Cloning
a string requires deduplication of a pointer, which means it can also
provide the guarantee of an input visitor of never producing NULL
even when still accepting NULL in place of "" the way the QMP output
visitor does.
Cloning an 'any' type could be possible by incrementing the QObject
refcnt, but it's not obvious whether that is better than implementing
a QObject deep clone. So for now, we document it as unsupported,
and intentionally omit the .type_any() callback to let a developer
know their usage needs implementation.
Add testsuite coverage for several different clone situations, to
ensure that the code is working. I also tested that valgrind was
happy with the test.
Signed-off-by: Eric Blake <eblake@redhat.com>
Message-Id: <1465490926-28625-14-git-send-email-eblake@redhat.com>
Reviewed-by: Markus Armbruster <armbru@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
81 lines
1.4 KiB
Text
81 lines
1.4 KiB
Text
check-qdict
|
|
check-qfloat
|
|
check-qint
|
|
check-qjson
|
|
check-qlist
|
|
check-qnull
|
|
check-qstring
|
|
check-qom-interface
|
|
check-qom-proplist
|
|
qht-bench
|
|
rcutorture
|
|
test-aio
|
|
test-base64
|
|
test-bitops
|
|
test-blockjob-txn
|
|
test-clone-visitor
|
|
test-coroutine
|
|
test-crypto-afsplit
|
|
test-crypto-block
|
|
test-crypto-cipher
|
|
test-crypto-hash
|
|
test-crypto-ivgen
|
|
test-crypto-pbkdf
|
|
test-crypto-secret
|
|
test-crypto-tlscredsx509
|
|
test-crypto-tlscredsx509-work/
|
|
test-crypto-tlscredsx509-certs/
|
|
test-crypto-tlssession
|
|
test-crypto-tlssession-work/
|
|
test-crypto-tlssession-client/
|
|
test-crypto-tlssession-server/
|
|
test-crypto-xts
|
|
test-cutils
|
|
test-hbitmap
|
|
test-int128
|
|
test-iov
|
|
test-io-channel-buffer
|
|
test-io-channel-command
|
|
test-io-channel-command.fifo
|
|
test-io-channel-file
|
|
test-io-channel-file.txt
|
|
test-io-channel-socket
|
|
test-io-channel-tls
|
|
test-io-task
|
|
test-logging
|
|
test-mul64
|
|
test-opts-visitor
|
|
test-qapi-event.[ch]
|
|
test-qapi-types.[ch]
|
|
test-qapi-visit.[ch]
|
|
test-qdev-global-props
|
|
test-qemu-opts
|
|
test-qdist
|
|
test-qga
|
|
test-qht
|
|
test-qht-par
|
|
test-qmp-commands
|
|
test-qmp-commands.h
|
|
test-qmp-event
|
|
test-qmp-input-strict
|
|
test-qmp-input-visitor
|
|
test-qmp-introspect.[ch]
|
|
test-qmp-marshal.c
|
|
test-qmp-output-visitor
|
|
test-rcu-list
|
|
test-rfifolock
|
|
test-string-input-visitor
|
|
test-string-output-visitor
|
|
test-thread-pool
|
|
test-throttle
|
|
test-timed-average
|
|
test-visitor-serialization
|
|
test-vmstate
|
|
test-write-threshold
|
|
test-x86-cpuid
|
|
test-xbzrle
|
|
test-netfilter
|
|
test-filter-mirror
|
|
test-filter-redirector
|
|
*-test
|
|
qapi-schema/*.test.*
|