mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-10-06 19:19:41 +00:00
9c61fcc89a
The code in CONV_NATURAL_FLOAT() and CLIP_NATURAL_FLOAT() seems to use the constant 2^31-0.5 to convert float to integer and back. But the float type lacks the required precision and the constant used for the conversion is 2^31. This is equiva- lent to a [-1.f, 1.f] <-> [INT32_MIN, INT32_MAX + 1] mapping. This patch explicitly writes down the used constant. The compiler generated code doesn't change. The constant 2^31 has an exact float representation and the clang 10 compiler stops complaining about an implicit int to float conversion with a changed value. A few notes: - The conversion of 1.f to INT32_MAX + 1 doesn't overflow. The type of the destination variable is int64_t. - At a later stage one of the clip_* functions in audio/mixeng_template.h limits INT32_MAX + 1 to the integer range. - The clip_natural_float_* functions in audio/mixeng.c convert INT32_MAX and INT32_MAX + 1 to 1.f. Buglink: https://bugs.launchpad.net/bugs/1878627 Signed-off-by: Volker Rümelin <vr_qemu@t-online.de> Message-id: 20200523201712.23908-1-vr_qemu@t-online.de Signed-off-by: Gerd Hoffmann <kraxel@redhat.com> |
||
|---|---|---|
| .. | ||
| alsaaudio.c | ||
| audio.c | ||
| audio.h | ||
| audio_int.h | ||
| audio_legacy.c | ||
| audio_template.h | ||
| audio_win_int.c | ||
| audio_win_int.h | ||
| coreaudio.c | ||
| dsound_template.h | ||
| dsoundaudio.c | ||
| jackaudio.c | ||
| Makefile.objs | ||
| mixeng.c | ||
| mixeng.h | ||
| mixeng_template.h | ||
| noaudio.c | ||
| ossaudio.c | ||
| paaudio.c | ||
| rate_template.h | ||
| sdlaudio.c | ||
| spiceaudio.c | ||
| trace-events | ||
| wavaudio.c | ||
| wavcapture.c | ||