mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 18:05:37 +00:00
![]() Currently the crypto layer exposes support for a 'des-rfb' algorithm which is just normal single-DES, with the bits in each key byte reversed. This special key munging is required by the RFB protocol password authentication mechanism. Since the crypto layer is generic shared code, it makes more sense to do the key byte munging in the VNC server code, and expose normal single-DES support. Replacing cipher 'des-rfb' by 'des' looks like an incompatible interface change, but it doesn't matter. While the QMP schema allows any QCryptoCipherAlgorithm for the 'cipher-alg' field in QCryptoBlockCreateOptionsLUKS, the code restricts what can be used at runtime. Thus the only effect is a change in error message. Original behaviour: $ qemu-img create -f luks --object secret,id=sec0,data=123 -o cipher-alg=des-rfb,key-secret=sec0 demo.luks 1G Formatting 'demo.luks', fmt=luks size=1073741824 key-secret=sec0 cipher-alg=des-rfb qemu-img: demo.luks: Algorithm 'des-rfb' not supported New behaviour: $ qemu-img create -f luks --object secret,id=sec0,data=123 -o cipher-alg=des-rfb,key-secret=sec0 demo.luks 1G Formatting 'demo.luks', fmt=luks size=1073741824 key-secret=sec0 cipher-alg=des-fish qemu-img: demo.luks: Invalid parameter 'des-rfb' Reviewed-by: Markus Armbruster <armbru@redhat.com> Reviewed-by: Eric Blake <eblake@redhat.com> Signed-off-by: Daniel P. Berrangé <berrange@redhat.com> |
||
---|---|---|
.. | ||
icons | ||
keycodemapdb@6119e6e19a | ||
shader | ||
clipboard.c | ||
cocoa.m | ||
console-gl.c | ||
console.c | ||
curses.c | ||
curses_keys.h | ||
cursor.c | ||
cursor_hidden.xpm | ||
cursor_left_ptr.xpm | ||
egl-context.c | ||
egl-headless.c | ||
egl-helpers.c | ||
gtk-clipboard.c | ||
gtk-egl.c | ||
gtk-gl-area.c | ||
gtk.c | ||
input-barrier.c | ||
input-barrier.h | ||
input-keymap.c | ||
input-legacy.c | ||
input-linux.c | ||
input.c | ||
kbd-state.c | ||
keymaps.c | ||
keymaps.h | ||
meson.build | ||
qemu-pixman.c | ||
qemu-x509.h | ||
qemu.desktop | ||
sdl2-2d.c | ||
sdl2-gl.c | ||
sdl2-input.c | ||
sdl2.c | ||
shader.c | ||
spice-app.c | ||
spice-core.c | ||
spice-display.c | ||
spice-input.c | ||
spice-module.c | ||
trace-events | ||
trace.h | ||
udmabuf.c | ||
vdagent.c | ||
vgafont.h | ||
vnc-auth-sasl.c | ||
vnc-auth-sasl.h | ||
vnc-auth-vencrypt.c | ||
vnc-auth-vencrypt.h | ||
vnc-clipboard.c | ||
vnc-enc-hextile-template.h | ||
vnc-enc-hextile.c | ||
vnc-enc-tight.c | ||
vnc-enc-tight.h | ||
vnc-enc-zlib.c | ||
vnc-enc-zrle.c | ||
vnc-enc-zrle.c.inc | ||
vnc-enc-zrle.h | ||
vnc-enc-zywrle-template.c | ||
vnc-enc-zywrle.h | ||
vnc-jobs.c | ||
vnc-jobs.h | ||
vnc-palette.c | ||
vnc-palette.h | ||
vnc-stubs.c | ||
vnc-ws.c | ||
vnc-ws.h | ||
vnc.c | ||
vnc.h | ||
vnc_keysym.h | ||
win32-kbd-hook.c | ||
x_keymap.c | ||
x_keymap.h |