mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-09-06 09:55:55 +00:00
![]() if QEMU is started with used provided SLIC table blob, -acpitable sig=SLIC,oem_id='CRASH ',oem_table_id="ME",oem_rev=00002210,asl_compiler_id="",asl_compiler_rev=00000000,data=/dev/null it will assert with: hw/acpi/aml-build.c:61:build_append_padded_str: assertion failed: (len <= maxlen) and following backtrace: ... build_append_padded_str (array=0x555556afe320, str=0x555556afdb2e "CRASH ME", maxlen=0x6, pad=0x20) at hw/acpi/aml-build.c:61 acpi_table_begin (desc=0x7fffffffd1b0, array=0x555556afe320) at hw/acpi/aml-build.c:1727 build_fadt (tbl=0x555556afe320, linker=0x555557ca3830, f=0x7fffffffd318, oem_id=0x555556afdb2e "CRASH ME", oem_table_id=0x555556afdb34 "ME") at hw/acpi/aml-build.c:2064 ... which happens due to acpi_table_begin() expecting NULL terminated oem_id and oem_table_id strings, which is normally the case, but in case of user provided SLIC table, oem_id points to table's blob directly and as result oem_id became longer than expected. Fix issue by handling oem_id consistently and make acpi_get_slic_oem() return NULL terminated strings. PS: After [1] refactoring, oem_id semantics became inconsistent, where NULL terminated string was coming from machine and old way pointer into byte array coming from -acpitable option. That used to work since build_header() wasn't expecting NULL terminated string and blindly copied the 1st 6 bytes only. However commit [2] broke that by replacing build_header() with acpi_table_begin(), which was expecting NULL terminated string and was checking oem_id size. 1) |
||
---|---|---|
.. | ||
acpi-cpu-hotplug-stub.c | ||
acpi-mem-hotplug-stub.c | ||
acpi-nvdimm-stub.c | ||
acpi-pci-hotplug-stub.c | ||
acpi-stub.c | ||
acpi-x86-stub.c | ||
acpi_interface.c | ||
aml-build-stub.c | ||
aml-build.c | ||
bios-linker-loader.c | ||
core.c | ||
cpu.c | ||
cpu_hotplug.c | ||
generic_event_device.c | ||
ghes-stub.c | ||
ghes.c | ||
hmat.c | ||
hmat.h | ||
ich9.c | ||
ipmi-stub.c | ||
ipmi.c | ||
Kconfig | ||
memory_hotplug.c | ||
meson.build | ||
nvdimm.c | ||
pci.c | ||
pcihp.c | ||
piix4.c | ||
tco.c | ||
tpm.c | ||
trace-events | ||
trace.h | ||
utils.c | ||
viot.c | ||
viot.h | ||
vmgenid.c |