qemu/hw/rtc
Jessica Clarke 8380b3a453 goldfish_rtc: Fix non-atomic read behaviour of TIME_LOW/TIME_HIGH
The specification says:

   0x00  TIME_LOW   R: Get current time, then return low-order 32-bits.
   0x04  TIME_HIGH  R: Return high 32-bits from previous TIME_LOW read.

   ...

   To read the value, the kernel must perform an IO_READ(TIME_LOW),
   which returns an unsigned 32-bit value, before an IO_READ(TIME_HIGH),
   which returns a signed 32-bit value, corresponding to the higher half
   of the full value.

However, we were just returning the current time for both. If the guest
is unlucky enough to read TIME_LOW and TIME_HIGH either side of an
overflow of the lower half, it will see time be in the future, before
jumping backwards on the next read, and Linux currently relies on the
atomicity guaranteed by the spec so is affected by this. Fix this
violation of the spec by caching the correct value for TIME_HIGH
whenever TIME_LOW is read, and returning that value for any TIME_HIGH
read.

Signed-off-by: Jessica Clarke <jrtc27@jrtc27.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Message-Id: <20200718004934.83174-1-jrtc27@jrtc27.com>
Signed-off-by: Alistair Francis <alistair.francis@wdc.com>
2020-07-22 09:39:46 -07:00
..
allwinner-rtc.c hw/arm/allwinner: add RTC device support 2020-03-12 16:27:33 +00:00
aspeed_rtc.c
ds1338.c
exynos4210_rtc.c
goldfish_rtc.c goldfish_rtc: Fix non-atomic read behaviour of TIME_LOW/TIME_HIGH 2020-07-22 09:39:46 -07:00
Kconfig hw: rtc: Add Goldfish RTC device 2020-02-10 12:01:37 -08:00
m41t80.c
m48t59-internal.h hw/timer/m48t59: Convert debug printf()s to trace events 2020-02-06 10:51:24 +01:00
m48t59-isa.c isa: Convert uses of isa_create() with Coccinelle 2020-06-15 22:05:28 +02:00
m48t59.c sysbus: Convert to sysbus_realize() etc. with Coccinelle 2020-06-15 22:05:28 +02:00
Makefile.objs hw/arm/allwinner: add RTC device support 2020-03-12 16:27:33 +00:00
mc146818rtc.c isa: Convert uses of isa_create() with Coccinelle 2020-06-15 22:05:28 +02:00
pl031.c qdev: set properties with device_class_set_props() 2020-01-24 20:59:15 +01:00
sun4v-rtc.c sysbus: Convert to sysbus_realize() etc. with Coccinelle 2020-06-15 22:05:28 +02:00
trace-events hw/arm/allwinner: add RTC device support 2020-03-12 16:27:33 +00:00
twl92230.c hw/timer: Remove unused "ui/console.h" header 2020-03-09 15:59:31 +01:00
xlnx-zynqmp-rtc.c