No description
Find a file
Markus Armbruster 7d6f6933aa migration: Handle migration_incoming_setup() errors consistently
Commit b673eab4e2 "multifd: Make multifd_load_setup() get an Error
parameter" changed migration_incoming_setup() to take an Error **
argument, and adjusted the callers accordingly.  It neglected to
change adjust multifd_load_setup(): it still exit()s on error.  Clean
that up.

The error now gets propagated up two call chains: via
migration_fd_process_incoming() to rdma_accept_incoming_migration(),
and via migration_ioc_process_incoming() to
migration_channel_process_incoming().  Both chain ends report the
error with error_report_err(), but otherwise ignore it.  Behavioral
change: we no longer exit() on this error.

This is consistent with how we handle other errors here, e.g. from
multifd_recv_new_channel() via migration_ioc_process_incoming() to
migration_channel_process_incoming().  Whether it's consistently right
or consistently wrong I can't tell.

Also clean up the return value from the unusual 0 on success, 1 on
error to the more common true on success, false on error.

Cc: Juan Quintela <quintela@redhat.com>
Cc: Dr. David Alan Gilbert <dgilbert@redhat.com>
Signed-off-by: Markus Armbruster <armbru@redhat.com>
Message-Id: <20210720125408.387910-11-armbru@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
Reviewed-by: Pankaj Gupta <pankaj.gupta@ionos.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
2021-08-26 17:15:28 +02:00
.github
.gitlab/issue_templates
.gitlab-ci.d gitlab: skip many more targets in windows cross builds 2021-08-11 08:52:31 +02:00
accel accel/tcg: Remove double bswap for helper_atomic_sto_*_mmu 2021-07-30 08:23:12 -10:00
audio audio: Never send migration section 2021-08-10 10:55:57 +02:00
authz
backends migration: Unify failure check for migrate_add_blocker() 2021-08-26 17:15:28 +02:00
block block/export/fuse.c: fix musl build 2021-08-09 17:19:27 +02:00
bsd-user tcg/plugins: implement a qemu_plugin_user_exit helper 2021-07-23 17:22:16 +01:00
capstone@f8b1b83301
chardev chardev: report a simpler error about duplicated id 2021-08-05 16:15:33 +04:00
configs hw/tricore: fix inclusion of tricore_testboard 2021-07-20 20:10:21 +02:00
contrib plugins/cache: Fixed "function decl. is not a prototype" warnings 2021-07-23 17:22:16 +01:00
crypto crypto: add gnutls pbkdf provider 2021-07-14 14:15:52 +01:00
disas Hexagon (disas/hexagon.c) fix memory leak for early exit cases 2021-08-12 09:06:05 -05:00
docs qapidoc: introduce QAPISchemaIfCond.docgen() 2021-08-26 13:53:56 +02:00
dtc@85e5d83984
dump
ebpf
fpu
fsdev
gdb-xml
hw migration: Unify failure check for migrate_add_blocker() 2021-08-26 17:15:28 +02:00
include fsl-imx7: Instantiate SAI1/2/3 as unimplemented devices 2021-08-25 10:48:51 +01:00
io io: use GDateTime for formatting timestamp for websock headers 2021-07-14 14:15:52 +01:00
libdecnumber
linux-headers
linux-user linux-user/elfload: byteswap i386 registers when dumping core 2021-08-05 12:17:30 +02:00
meson@776acd2a80
migration migration: Handle migration_incoming_setup() errors consistently 2021-08-26 17:15:28 +02:00
monitor chardev: mark explicitly first argument as poisoned 2021-08-05 16:15:33 +04:00
nbd nbd/server: Mark variable unused in nbd_negotiate_meta_queries 2021-07-26 07:06:25 -10:00
net chardev: mark explicitly first argument as poisoned 2021-08-05 16:15:33 +04:00
pc-bios pseries: Update SLOF firmware image 2021-07-13 10:04:30 +10:00
plugins plugins: Fix physical address calculation for IO regions 2021-07-23 17:22:16 +01:00
po
python python: Configure tox to skip missing interpreters 2021-07-13 15:44:16 -04:00
qapi qapi: make 'if' condition strings simple identifiers 2021-08-26 13:53:56 +02:00
qga qapi: make 'if' condition strings simple identifiers 2021-08-26 13:53:56 +02:00
qobject
qom qom: use correct field name when getting/setting alias properties 2021-07-23 18:17:17 +02:00
replay
roms pseries: Update SLOF firmware image 2021-07-13 10:04:30 +10:00
scripts qapi: make 'if' condition strings simple identifiers 2021-08-26 13:53:56 +02:00
scsi error: Use error_fatal to simplify obvious fatal errors (again) 2021-08-26 17:15:28 +02:00
semihosting
slirp@a88d9ace23 Update libslirp to v4.6.1 2021-08-03 16:07:22 +04:00
softmmu error: Use error_fatal to simplify obvious fatal errors (again) 2021-08-26 17:15:28 +02:00
storage-daemon storage-daemon: Add missing build dependency to the vhost-user-blk-test 2021-08-11 13:39:50 +02:00
stubs meson: fix condition for io_uring stubs 2021-07-14 14:31:48 +01:00
subprojects/libvhost-user libvhost-user: fix -Werror=format= warnings with __u64 fields 2021-07-29 10:15:52 +02:00
target migration: Unify failure check for migrate_add_blocker() 2021-08-26 17:15:28 +02:00
tcg accel/tcg: Add CF_NO_GOTO_TB and CF_NO_GOTO_PTR 2021-07-21 07:47:04 -10:00
tests qapi: make 'if' condition strings simple identifiers 2021-08-26 13:53:56 +02:00
tools virtiofsd: Add missing newline in error message 2021-07-09 18:42:46 +02:00
trace trace: Fold mem-internal.h into mem.h 2021-07-21 07:45:38 -10:00
ui error: Use error_fatal to simplify obvious fatal errors (again) 2021-08-26 17:15:28 +02:00
util util: fix abstract socket path copy 2021-08-04 23:23:31 +04:00
.cirrus.yml cirrus: delete FreeBSD and macOS jobs 2021-07-14 14:33:53 +01:00
.dir-locals.el
.editorconfig
.exrc
.gdbinit
.gitattributes
.gitignore gitignore: Update with some filetypes 2021-07-23 17:22:15 +01:00
.gitlab-ci.yml docs: Document GitLab custom CI/CD variables 2021-07-29 07:56:01 +02:00
.gitmodules
.gitpublish
.mailmap MAINTAINERS: Name and email address change 2021-08-10 16:42:16 +01:00
.patchew.yml
.readthedocs.yml
.travis.yml hw/usb/ccid: remove references to NSS 2021-07-14 14:33:53 +01:00
block.c block: Add option to use driver whitelist even in tools 2021-07-20 13:14:45 +02:00
blockdev-nbd.c
blockdev.c block: Make blockdev-reopen stable API 2021-07-09 13:19:11 +02:00
blockjob.c
configure Bugfixes. 2021-07-29 16:07:02 +01:00
COPYING
COPYING.LIB
cpu.c accel/tcg: Record singlestep_enabled in tb->cflags 2021-07-21 07:47:05 -10:00
cpus-common.c
disas.c
gdbstub.c
gitdm.config contrib/gitdm: add a new interns group-map for GSoC/Outreachy work 2021-07-23 17:22:16 +01:00
hmp-commands-info.hx monitor/tcg: move tcg hmp commands to accel/tcg, register them dynamically 2021-07-09 18:21:33 +02:00
hmp-commands.hx
iothread.c iothread: add aio-max-batch parameter 2021-07-21 13:47:50 +01:00
job-qmp.c
job.c
Kconfig meson: Introduce target-specific Kconfig 2021-07-09 18:21:34 +02:00
Kconfig.host
LICENSE
MAINTAINERS MAINTAINERS: update virtio-gpu entry. 2021-08-11 08:39:16 +02:00
Makefile Makefile: ignore long options 2021-07-29 10:15:51 +02:00
memory_ldst.c.inc
meson.build meson: fix logic for gnutls check 2021-08-06 15:36:11 +00:00
meson_options.txt
module-common.c
os-posix.c
os-win32.c
page-vary-common.c
page-vary.c
qemu-bridge-helper.c
qemu-edid.c
qemu-img-cmds.hx
qemu-img.c error: Use error_fatal to simplify obvious fatal errors (again) 2021-08-26 17:15:28 +02:00
qemu-io-cmds.c block: Acquire AioContexts during bdrv_reopen_multiple() 2021-07-09 13:19:11 +02:00
qemu-io.c error: Use error_fatal to simplify obvious fatal errors (again) 2021-08-26 17:15:28 +02:00
qemu-keymap.c
qemu-nbd.c error: Use error_fatal to simplify obvious fatal errors (again) 2021-08-26 17:15:28 +02:00
qemu-options.hx qemu-options.hx: Fix formatting of -machine memory-backend option 2021-07-27 10:57:39 +01:00
qemu.nsi
qemu.sasl
README.rst
replication.c
thunk.c
trace-events cpu: Add breakpoint tracepoints 2021-07-09 21:31:11 -07:00
VERSION Open 6.2 development tree 2021-08-25 10:25:12 +01:00
version.rc

===========
QEMU README
===========

QEMU is a generic and open source machine & userspace emulator and
virtualizer.

QEMU is capable of emulating a complete machine in software without any
need for hardware virtualization support. By using dynamic translation,
it achieves very good performance. QEMU can also integrate with the Xen
and KVM hypervisors to provide emulated hardware while allowing the
hypervisor to manage the CPU. With hypervisor support, QEMU can achieve
near native performance for CPUs. When QEMU emulates CPUs directly it is
capable of running operating systems made for one machine (e.g. an ARMv7
board) on a different machine (e.g. an x86_64 PC board).

QEMU is also capable of providing userspace API virtualization for Linux
and BSD kernel interfaces. This allows binaries compiled against one
architecture ABI (e.g. the Linux PPC64 ABI) to be run on a host using a
different architecture ABI (e.g. the Linux x86_64 ABI). This does not
involve any hardware emulation, simply CPU and syscall emulation.

QEMU aims to fit into a variety of use cases. It can be invoked directly
by users wishing to have full control over its behaviour and settings.
It also aims to facilitate integration into higher level management
layers, by providing a stable command line interface and monitor API.
It is commonly invoked indirectly via the libvirt library when using
open source applications such as oVirt, OpenStack and virt-manager.

QEMU as a whole is released under the GNU General Public License,
version 2. For full licensing details, consult the LICENSE file.


Documentation
=============

Documentation can be found hosted online at
`<https://www.qemu.org/documentation/>`_. The documentation for the
current development version that is available at
`<https://www.qemu.org/docs/master/>`_ is generated from the ``docs/``
folder in the source tree, and is built by `Sphinx
<https://www.sphinx-doc.org/en/master/>_`.


Building
========

QEMU is multi-platform software intended to be buildable on all modern
Linux platforms, OS-X, Win32 (via the Mingw64 toolchain) and a variety
of other UNIX targets. The simple steps to build QEMU are:


.. code-block:: shell

  mkdir build
  cd build
  ../configure
  make

Additional information can also be found online via the QEMU website:

* `<https://qemu.org/Hosts/Linux>`_
* `<https://qemu.org/Hosts/Mac>`_
* `<https://qemu.org/Hosts/W32>`_


Submitting patches
==================

The QEMU source code is maintained under the GIT version control system.

.. code-block:: shell

   git clone https://gitlab.com/qemu-project/qemu.git

When submitting patches, one common approach is to use 'git
format-patch' and/or 'git send-email' to format & send the mail to the
qemu-devel@nongnu.org mailing list. All patches submitted must contain
a 'Signed-off-by' line from the author. Patches should follow the
guidelines set out in the `style section
<https://www.qemu.org/docs/master/devel/style.html>` of
the Developers Guide.

Additional information on submitting patches can be found online via
the QEMU website

* `<https://qemu.org/Contribute/SubmitAPatch>`_
* `<https://qemu.org/Contribute/TrivialPatches>`_

The QEMU website is also maintained under source control.

.. code-block:: shell

  git clone https://gitlab.com/qemu-project/qemu-web.git

* `<https://www.qemu.org/2017/02/04/the-new-qemu-website-is-up/>`_

A 'git-publish' utility was created to make above process less
cumbersome, and is highly recommended for making regular contributions,
or even just for sending consecutive patch series revisions. It also
requires a working 'git send-email' setup, and by default doesn't
automate everything, so you may want to go through the above steps
manually for once.

For installation instructions, please go to

*  `<https://github.com/stefanha/git-publish>`_

The workflow with 'git-publish' is:

.. code-block:: shell

  $ git checkout master -b my-feature
  $ # work on new commits, add your 'Signed-off-by' lines to each
  $ git publish

Your patch series will be sent and tagged as my-feature-v1 if you need to refer
back to it in the future.

Sending v2:

.. code-block:: shell

  $ git checkout my-feature # same topic branch
  $ # making changes to the commits (using 'git rebase', for example)
  $ git publish

Your patch series will be sent with 'v2' tag in the subject and the git tip
will be tagged as my-feature-v2.

Bug reporting
=============

The QEMU project uses GitLab issues to track bugs. Bugs
found when running code built from QEMU git or upstream released sources
should be reported via:

* `<https://gitlab.com/qemu-project/qemu/-/issues>`_

If using QEMU via an operating system vendor pre-built binary package, it
is preferable to report bugs to the vendor's own bug tracker first. If
the bug is also known to affect latest upstream code, it can also be
reported via GitLab.

For additional information on bug reporting consult:

* `<https://qemu.org/Contribute/ReportABug>`_


ChangeLog
=========

For version history and release notes, please visit
`<https://wiki.qemu.org/ChangeLog/>`_ or look at the git history for
more detailed information.


Contact
=======

The QEMU community can be contacted in a number of ways, with the two
main methods being email and IRC

* `<mailto:qemu-devel@nongnu.org>`_
* `<https://lists.nongnu.org/mailman/listinfo/qemu-devel>`_
* #qemu on irc.oftc.net

Information on additional methods of contacting the community can be
found online via the QEMU website:

* `<https://qemu.org/Contribute/StartHere>`_