mirror of
https://gitlab.com/qemu-project/qemu
synced 2024-11-05 20:35:44 +00:00
cd6b1674d6
I completely botched up the merged[0] rST conversion of this document by
accidentally dropping entire hunks (!) of text. :-( I made it very hard
for reviewers to spot it, as the omitted text was buried deep in the
document. To fix my hatchet job, I reconverted the "SubmitAPatch"
wiki[1] page from scratch and replaced the existing rST with it, while
making sure I incorporated previous feedback.
In summary, in this reconverted edition:
- I did a careful (to the extent my eyes allowed) para-by-para
comparison of the wiki and the rST to make sure I didn't omit
anything accidentally.
- I made sure to work in the cosmetic feedback[2] that Thomas Huth
pointed out in the merged (and botched) edition:
- fix the hyperlinks in "Split up long patches"
- replace ".". with "does not end with a dot" (in "Write a meaningful
commit message" section)
- replace "---" with ``---`` so that it doesn't render as an em-dash
(there were two other occurrences; I fixed those too)
- Use "QEMU" spelling consistently in prose usage
- Add a consistent "refer to git-config" link where appropriate
Thanks to Thomas Huth and Alex Bennée for noticing it on IRC. And sorry
for my sloppiness.
Fixes: 9f73de8df0 ("docs: rSTify the "SubmitAPatch" wiki")
[0] https://gitlab.com/qemu-project/qemu/-/commit/9f73de8df033
[1] https://wiki.qemu.org/index.php?title=Contribute/SubmitAPatch&oldid=10387
[2] https://lists.nongnu.org/archive/html/qemu-devel/2021-11/msg03600.html
Signed-off-by: Kashyap Chamarthy <kchamart@redhat.com>
Message-Id: <20211119193118.949698-2-kchamart@redhat.com>
Reviewed-by: Eric Blake <eblake@redhat.com>
[thuth: Some more cosmetical changes, fixed links from external to internal]
Signed-off-by: Thomas Huth <thuth@redhat.com>
52 lines
1.6 KiB
ReStructuredText
52 lines
1.6 KiB
ReStructuredText
.. _trivial-patches:
|
|
|
|
Trivial Patches
|
|
===============
|
|
|
|
Overview
|
|
--------
|
|
|
|
Trivial patches that change just a few lines of code sometimes languish
|
|
on the mailing list even though they require only a small amount of
|
|
review. This is often the case for patches that do not fall under an
|
|
actively maintained subsystem and therefore fall through the cracks.
|
|
|
|
The trivial patches team take on the task of reviewing and building pull
|
|
requests for patches that:
|
|
|
|
- Do not fall under an actively maintained subsystem.
|
|
- Are single patches or short series (max 2-4 patches).
|
|
- Only touch a few lines of code.
|
|
|
|
**You should hint that your patch is a candidate by CCing
|
|
qemu-trivial@nongnu.org.**
|
|
|
|
Repositories
|
|
------------
|
|
|
|
Since the trivial patch team rotates maintainership there is only one
|
|
active repository at a time:
|
|
|
|
- git://github.com/vivier/qemu.git trivial-patches - `browse <https://github.com/vivier/qemu/tree/trivial-patches>`__
|
|
|
|
Workflow
|
|
--------
|
|
|
|
The trivial patches team rotates the duty of collecting trivial patches
|
|
amongst its members. A team member's job is to:
|
|
|
|
1. Identify trivial patches on the development mailing list.
|
|
2. Review trivial patches, merge them into a git tree, and reply to state
|
|
that the patch is queued.
|
|
3. Send pull requests to the development mailing list once a week.
|
|
|
|
A single team member can be on duty as long as they like. The suggested
|
|
time is 1 week before handing off to the next member.
|
|
|
|
Team
|
|
----
|
|
|
|
If you would like to join the trivial patches team, contact Laurent
|
|
Vivier. The current team includes:
|
|
|
|
- `Laurent Vivier <mailto:laurent@vivier.eu>`__
|